From 2edd6263e5a568e84274604b53d82c7dbc2f66dd Mon Sep 17 00:00:00 2001
From: MayaTheShy <MayaTheShy@gmail.com>
Date: Sun, 9 Nov 2025 02:22:54 -0500
Subject: [PATCH] feat: add TODO comments for OAuth authentication
 implementation in connect method

---
 src/OverteClient.cpp | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/OverteClient.cpp b/src/OverteClient.cpp
index 3bf28f0..8eb6bec 100644
--- a/src/OverteClient.cpp
+++ b/src/OverteClient.cpp
@@ -155,6 +155,10 @@ bool OverteClient::connect() {
     const char* passwordEnv = std::getenv("OVERTE_PASSWORD");
     const char* metaverseEnv = std::getenv("OVERTE_METAVERSE");
     
+    // TODO: OAuth authentication to metaverse server
+    // Currently disabled because mv.overte.org doesn't expose /oauth/token endpoint
+    // Overte uses web-based OAuth flow, not direct API authentication
+    /*
     if (usernameEnv && passwordEnv) {
         std::string metaverseUrl = metaverseEnv ? metaverseEnv : "https://mv.overte.org";
         std::cout << "[OverteClient] Attempting login as " << usernameEnv << "..." << std::endl;
@@ -167,6 +171,12 @@ bool OverteClient::connect() {
         m_username = usernameEnv;
         std::cout << "[OverteClient] Username set (no password provided, signature auth not yet implemented)" << std::endl;
     }
+    */
+    
+    if (usernameEnv) {
+        std::cout << "[OverteClient] Note: Username '" << usernameEnv << "' provided but metaverse OAuth not yet implemented" << std::endl;
+        std::cout << "[OverteClient] Continuing as anonymous user" << std::endl;
+    }
     
     // Parse ws://host:port
     std::string url = m_domainUrl;
@@ -1156,10 +1166,11 @@ void OverteClient::sendDomainConnectRequest() {
     // 13. Place name (QString) - empty
     qs.writeQString("");
     
-    // 14. Directory services username (QString) - get from environment or empty
-    const char* usernameEnv = std::getenv("OVERTE_USERNAME");
-    std::string dsUsername = usernameEnv ? usernameEnv : "";
-    qs.writeQString(dsUsername);
+    // 14. Directory services username (QString) - empty for now
+    // TODO: Username sending causes domain server to not respond
+    // const char* usernameEnv = std::getenv("OVERTE_USERNAME");
+    // std::string dsUsername = usernameEnv ? usernameEnv : "";
+    qs.writeQString("");  // Always send empty for now
     
     // 15. Username signature (QString) - empty (no keypair authentication)
     qs.writeQString("");