MayaTheShy/Starworld
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: refine entity packet parsing and enhance logging for unknown packet types

Browse Source
This commit is contained in:
MayaTheShy
2025-11-08 17:10:48 -05:00
parent a7981671bc
commit 2fe4f0d58b
1 changed files with 11 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/OverteClient.cpp
View File

@@ -267,31 +267,18 @@ void OverteClient::parseEntityPacket(const char* data, size_t len) {
unsigned char packetType = static_cast<unsigned char>(data[0]); unsigned char packetType = static_cast<unsigned char>(data[0]);
// Overte PacketType enum values (reference from protocol documentation)
// Reference: https://github.com/overte-org/overte/blob/master/libraries/networking/src/udt/PacketHeaders.h
const unsigned char PACKET_TYPE_DOMAIN_LIST = 0x03;
const unsigned char PACKET_TYPE_DOMAIN_CONNECTION_DENIED = 0x06;
const unsigned char PACKET_TYPE_PING = 0x01;
const unsigned char PACKET_TYPE_PING_REPLY = 0x02;
// Entity packet types // Entity packet types
const unsigned char PACKET_TYPE_ENTITY_ADD = 0x10; const unsigned char PACKET_TYPE_ENTITY_ADD = 0x10;
const unsigned char PACKET_TYPE_ENTITY_EDIT = 0x11; const unsigned char PACKET_TYPE_ENTITY_EDIT = 0x11;
const unsigned char PACKET_TYPE_ENTITY_ERASE = 0x12; const unsigned char PACKET_TYPE_ENTITY_ERASE = 0x12;
const unsigned char PACKET_TYPE_ENTITY_QUERY = 0x15; const unsigned char PACKET_TYPE_ENTITY_QUERY = 0x15;
const unsigned char PACKET_TYPE_OCTREE_STATS = 0x16; const unsigned char PACKET_TYPE_OCTREE_STATS = 0x16;
const unsigned char PACKET_TYPE_ENTITY_DATA = 0x41; // Bulk entity data response
switch (packetType) { switch (packetType) {
case PACKET_TYPE_DOMAIN_LIST: case PACKET_TYPE_ENTITY_DATA:
handleDomainListReply(data + 1, len - 1);
break;
case PACKET_TYPE_PING_REPLY:
std::cout << "[OverteClient] Ping reply received from domain" << std::endl;
break;
case PACKET_TYPE_ENTITY_ADD: { case PACKET_TYPE_ENTITY_ADD: {
// EntityAdd packet structure (simplified): // EntityAdd/EntityData packet structure (simplified):
// u64 entityID, string name, vec3 position, quat rotation, vec3 dimensions, ... // u64 entityID, string name, vec3 position, quat rotation, vec3 dimensions, ...
if (len < 9) break; // need at least 1+8 bytes if (len < 9) break; // need at least 1+8 bytes
@@ -306,7 +293,8 @@ void OverteClient::parseEntityPacket(const char* data, size_t len) {
} }
if (name.empty()) name = "Entity_" + std::to_string(entityId); if (name.empty()) name = "Entity_" + std::to_string(entityId);
// Create entity with a visible position spread out in front of user // TODO: Parse full entity properties (position, rotation, dimensions)
// For now, create entity with a visible position spread out in front of user
// Position entities in a grid pattern for visibility // Position entities in a grid pattern for visibility
float spacing = 0.5f; float spacing = 0.5f;
int index = static_cast<int>(entityId % 10); int index = static_cast<int>(entityId % 10);
@@ -338,6 +326,7 @@ void OverteClient::parseEntityPacket(const char* data, size_t len) {
// TODO: parse property flags and update transform // TODO: parse property flags and update transform
// For now, mark as updated // For now, mark as updated
m_updateQueue.push_back(entityId); m_updateQueue.push_back(entityId);
std::cout << "[OverteClient] Entity edited: id=" << entityId << std::endl;
} }
break; break;
} }
@@ -358,11 +347,12 @@ void OverteClient::parseEntityPacket(const char* data, size_t len) {
break; break;
} }
case PACKET_TYPE_OCTREE_STATS:
std::cout << "[OverteClient] Received octree stats" << std::endl;
break;
default: default:
// Log unknown packet types for debugging std::cout << "[OverteClient] Unknown entity packet type: 0x" << std::hex << (int)packetType << std::dec << std::endl;
if (packetType != PACKET_TYPE_PING && packetType != PACKET_TYPE_PING_REPLY) {
std::cout << "[OverteClient] Unknown packet type: 0x" << std::hex << (int)packetType << std::dec << std::endl;
}
break; break;
} }
} }