MayaTheShy/Starworld
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: ensure DomainConnectRequest does not include source ID before local ID is assigned

Browse Source
This commit is contained in:
MayaTheShy
2025-11-10 00:05:22 -05:00
parent d507902a73
commit d14f50d356
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/OverteClient.cpp
View File

@@ -1232,11 +1232,10 @@ void OverteClient::handleDomainConnectionDenied(const char* data, size_t len) {
void OverteClient::sendDomainConnectRequest() { void OverteClient::sendDomainConnectRequest() {
if (!m_udpReady || m_udpFd == -1) return; if (!m_udpReady || m_udpFd == -1) return;
// Create NLPacket with DomainConnectRequest type and correct version // DomainConnectRequest is in NON_SOURCED_PACKETS - it should NOT have a source ID field
NLPacket packet(PacketType::DomainConnectRequest, PacketVersions::DomainConnectRequest_SocketTypes, true); // because we don't have a Local ID yet (server assigns it in DomainList response)
NLPacket packet(PacketType::DomainConnectRequest, PacketVersions::DomainConnectRequest_SocketTypes, false);
packet.setSequenceNumber(m_sequenceNumber++); packet.setSequenceNumber(m_sequenceNumber++);
// DomainConnectRequest is sent BEFORE we have a local ID, so don't set source ID
// The server will assign us an ID in the DomainList response
// Build payload using Qt wire format (match Overte's NodeList.cpp structure exactly) // Build payload using Qt wire format (match Overte's NodeList.cpp structure exactly)
QtStream qs; QtStream qs;