MayaTheShy/Starworld
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: update sendPing to include source ID and HMAC verification hash for improved packet integrity

Browse Source
This commit is contained in:
MayaTheShy
2025-11-10 01:46:05 -05:00
parent b416628824
commit d67fc08ed5
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/OverteClient.cpp
View File

@@ -1541,13 +1541,10 @@ void OverteClient::sendPing(int fd, const sockaddr_storage& addr, socklen_t addr
// Create NLPacket for Ping with correct version // Create NLPacket for Ping with correct version
NLPacket packet(PacketType::Ping, PacketVersions::Ping_IncludeConnectionID, false); NLPacket packet(PacketType::Ping, PacketVersions::Ping_IncludeConnectionID, false);
// EXPERIMENTAL: Try sending as non-sourced packet to avoid hash verification issues // Set source ID and sequence number
// The server should still be able to identify us from our source socket address if (m_localID != 0) {
// if (m_localID != 0) { packet.setSourceID(m_localID);
// packet.setSourceID(m_localID); }
// }
// Set sequence number
packet.setSequenceNumber(m_sequenceNumber++); packet.setSequenceNumber(m_sequenceNumber++);
// Add timestamp (microseconds since epoch) // Add timestamp (microseconds since epoch)
@@ -1558,6 +1555,10 @@ void OverteClient::sendPing(int fd, const sockaddr_storage& addr, socklen_t addr
// Ping type (0 = local, 1 = public) // Ping type (0 = local, 1 = public)
packet.writeUInt8(0); packet.writeUInt8(0);
// Write HMAC verification hash using null UUID as key
uint8_t nullUUID[16] = {0};
packet.writeVerificationHash(nullUUID);
const auto& data = packet.getData(); const auto& data = packet.getData();
// Debug: show destination address // Debug: show destination address