MayaTheShy/Starworld
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: move helper functions to anonymous namespace for better encapsulation

Browse Source
This commit is contained in:
MayaTheShy
2025-11-09 00:01:36 -05:00
parent e9f218d52e
commit df5a9797fd
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/NLPacketCodec.cpp
View File

@@ -158,15 +158,17 @@ PacketType NLPacket::getType(const uint8_t* data, size_t size) {
return static_cast<PacketType>(data[sizeof(uint32_t)]); return static_cast<PacketType>(data[sizeof(uint32_t)]);
} }
namespace {
// --- Helpers to parse Overte header enums to ensure exact version numbers --- // --- Helpers to parse Overte header enums to ensure exact version numbers ---
static std::string readFileToString(const std::string& path) { std::string readFileToString(const std::string& path) {
std::ifstream in(path); std::ifstream in(path);
if (!in.is_open()) return {}; if (!in.is_open()) return {};
std::ostringstream ss; ss << in.rdbuf(); std::ostringstream ss; ss << in.rdbuf();
return ss.str(); return ss.str();
} }
static std::unordered_map<std::string, int> parseEnumValues(const std::string& content, const std::string& enumName) { std::unordered_map<std::string, int> parseEnumValues(const std::string& content, const std::string& enumName) {
std::unordered_map<std::string, int> values; std::unordered_map<std::string, int> values;
std::string startToken = "enum class " + enumName; std::string startToken = "enum class " + enumName;
auto startPos = content.find(startToken); auto startPos = content.find(startToken);
@@ -217,7 +219,7 @@ static std::unordered_map<std::string, int> parseEnumValues(const std::string& c
return values; return values;
} }
static int parsePacketTypeCount(const std::string& content) { int parsePacketTypeCount(const std::string& content) {
// Count identifiers in PacketTypeEnum::Value until NUM_PACKET_TYPE // Count identifiers in PacketTypeEnum::Value until NUM_PACKET_TYPE
auto pos = content.find("enum class Value : uint8_t"); auto pos = content.find("enum class Value : uint8_t");
if (pos == std::string::npos) return 106; // fallback if (pos == std::string::npos) return 106; // fallback