mirror of
https://github.com/instructkr/claw-code.git
synced 2026-06-06 01:42:47 -04:00
Compare commits
13 Commits
9c8375da99
...
22fdaeae2c
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
22fdaeae2c | ||
|
|
4522490bd5 | ||
|
|
cd58c054ca | ||
|
|
94579eace5 | ||
|
|
2ab2f44e1d | ||
|
|
fa35018769 | ||
|
|
94be902ce1 | ||
|
|
bcc5bfde9c | ||
|
|
9522674c87 | ||
|
|
c91a3062d5 | ||
|
|
54d785d0c0 | ||
|
|
36218ac1b1 | ||
|
|
6388a2ba3f |
27
ROADMAP.md
27
ROADMAP.md
@@ -1244,8 +1244,7 @@ Model name prefix now wins unconditionally over env-var presence. Regression tes
|
|||||||
|
|
||||||
45. **`claw dump-manifests` fails with opaque "No such file or directory"** — dogfooded 2026-04-09. `claw dump-manifests` emits `error: failed to extract manifests: No such file or directory (os error 2)` with no indication of which file or directory is missing. **Partial fix at `47aa1a5`+1**: error message now includes `looked in: <path>` so the build-tree path is visible, what manifests are, or how to fix it. Fix shape: (a) surface the missing path in the error message; (b) add a pre-check that explains what manifests are and where they should be (e.g. `.claw/manifests/` or the plugins directory); (c) if the command is only valid after `claw init` or after installing plugins, say so explicitly. Source: Jobdori dogfood 2026-04-09.
|
45. **`claw dump-manifests` fails with opaque "No such file or directory"** — dogfooded 2026-04-09. `claw dump-manifests` emits `error: failed to extract manifests: No such file or directory (os error 2)` with no indication of which file or directory is missing. **Partial fix at `47aa1a5`+1**: error message now includes `looked in: <path>` so the build-tree path is visible, what manifests are, or how to fix it. Fix shape: (a) surface the missing path in the error message; (b) add a pre-check that explains what manifests are and where they should be (e.g. `.claw/manifests/` or the plugins directory); (c) if the command is only valid after `claw init` or after installing plugins, say so explicitly. Source: Jobdori dogfood 2026-04-09.
|
||||||
|
|
||||||
45. **`claw dump-manifests` fails with opaque `No such file or directory`** — **done (verified 2026-04-12):** current `main` now accepts `claw dump-manifests --manifests-dir PATH`, pre-checks for the required upstream manifest files (`src/commands.ts`, `src/tools.ts`, `src/entrypoints/cli.tsx`), and replaces the opaque os error with guidance that points users to `CLAUDE_CODE_UPSTREAM` or `--manifests-dir`. Fresh proof: parser coverage for both flag forms, unit coverage for missing-manifest and explicit-path flows, and `output_format_contract` JSON coverage via the new flag all pass. **Original filing below.**
|
45. **`claw dump-manifests` fails with opaque `No such file or directory`** — **done (verified 2026-06-03):** current `main` now emits a self-contained Rust resolver inventory for `claw dump-manifests` without requiring upstream TypeScript files, build-machine paths, or `CLAUDE_CODE_UPSTREAM`. Explicit `--manifests-dir PATH` scopes resolver discovery to another directory and missing/not-directory values emit typed `missing_manifests` guidance. Fresh proof: parser coverage for both flag forms, unit coverage for self-contained default, explicit-directory, and missing-directory flows, plus `output_format_contract` JSON coverage all pass. **Original filing below.**
|
||||||
45. **`claw dump-manifests` fails with opaque `No such file or directory`** — **done (verified 2026-04-12):** current `main` now accepts `claw dump-manifests --manifests-dir PATH`, pre-checks for the required upstream manifest files (`src/commands.ts`, `src/tools.ts`, `src/entrypoints/cli.tsx`), and replaces the opaque os error with guidance that points users to `CLAUDE_CODE_UPSTREAM` or `--manifests-dir`. Fresh proof: parser coverage for both flag forms, unit coverage for missing-manifest and explicit-path flows, and `output_format_contract` JSON coverage via the new flag all pass. **Original filing below.**
|
|
||||||
46. **`/tokens`, `/cache`, `/stats` were dead spec — parse arms missing** — dogfooded 2026-04-09. All three had spec entries with `resume_supported: true` but no parse arms, producing the circular error "Unknown slash command: /tokens — Did you mean /tokens". Also `SlashCommand::Stats` existed but was unimplemented in both REPL and resume dispatch. **Done at `60ec2ae` 2026-04-09**: `"tokens" | "cache"` now alias to `SlashCommand::Stats`; `Stats` is wired in both REPL and resume path with full JSON output. Source: Jobdori dogfood.
|
46. **`/tokens`, `/cache`, `/stats` were dead spec — parse arms missing** — dogfooded 2026-04-09. All three had spec entries with `resume_supported: true` but no parse arms, producing the circular error "Unknown slash command: /tokens — Did you mean /tokens". Also `SlashCommand::Stats` existed but was unimplemented in both REPL and resume dispatch. **Done at `60ec2ae` 2026-04-09**: `"tokens" | "cache"` now alias to `SlashCommand::Stats`; `Stats` is wired in both REPL and resume path with full JSON output. Source: Jobdori dogfood.
|
||||||
|
|
||||||
47. **`/diff` fails with cryptic "unknown option 'cached'" outside a git repo; resume /diff used wrong CWD** — dogfooded 2026-04-09. `claw --resume <session> /diff` in a non-git directory produced `git diff --cached failed: error: unknown option 'cached'` because git falls back to `--no-index` mode outside a git tree. Also resume `/diff` used `session_path.parent()` (the `.claw/sessions/<id>/` dir) as CWD for the diff — never a git repo. **Done at `aef85f8` 2026-04-09**: `render_diff_report_for()` now checks `git rev-parse --is-inside-work-tree` first and returns a clear "no git repository" message; resume `/diff` uses `std::env::current_dir()`. Source: Jobdori dogfood.
|
47. **`/diff` fails with cryptic "unknown option 'cached'" outside a git repo; resume /diff used wrong CWD** — dogfooded 2026-04-09. `claw --resume <session> /diff` in a non-git directory produced `git diff --cached failed: error: unknown option 'cached'` because git falls back to `--no-index` mode outside a git tree. Also resume `/diff` used `session_path.parent()` (the `.claw/sessions/<id>/` dir) as CWD for the diff — never a git repo. **Done at `aef85f8` 2026-04-09**: `render_diff_report_for()` now checks `git rev-parse --is-inside-work-tree` first and returns a clear "no git repository" message; resume `/diff` uses `std::env::current_dir()`. Source: Jobdori dogfood.
|
||||||
@@ -1547,7 +1546,7 @@ Original filing (2026-04-13): user requested a `-acp` parameter to support ACP p
|
|||||||
|
|
||||||
**Source.** Jobdori dogfood 2026-04-17 against `/tmp/cd3` on main HEAD `e58c194` in response to Clawhip pinpoint nudge at `1494653681222811751`. Distinct from #80/#81/#82 (status/error surfaces lie about *static* runtime state): this is a surface that lies about *time itself*, and the lie is smeared into every live-agent system prompt, not just a single error string or status field.
|
**Source.** Jobdori dogfood 2026-04-17 against `/tmp/cd3` on main HEAD `e58c194` in response to Clawhip pinpoint nudge at `1494653681222811751`. Distinct from #80/#81/#82 (status/error surfaces lie about *static* runtime state): this is a surface that lies about *time itself*, and the lie is smeared into every live-agent system prompt, not just a single error string or status field.
|
||||||
|
|
||||||
84. **`claw dump-manifests` default search path is the build machine's absolute filesystem path baked in at compile time — broken and information-leaking for any user running a distributed binary** — dogfooded 2026-04-17 on main HEAD `70a0f0c` from `/tmp/cd4` (fresh workspace). Running `claw dump-manifests` with no arguments emits:
|
84. **DONE — `claw dump-manifests` no longer bakes or leaks the build machine's absolute filesystem path** — fixed 2026-06-03 in `fix: make dump-manifests self-contained`. The runtime default now uses the current workspace and emits the Rust resolver inventory directly, so distributed binaries no longer depend on upstream TypeScript source files or compile-time `CARGO_MANIFEST_DIR` paths. Explicit `--manifests-dir` remains as a discovery-root override and invalid roots return typed `missing_manifests` diagnostics. Original filing below: running `claw dump-manifests` with no arguments emitted:
|
||||||
```
|
```
|
||||||
error: Manifest source files are missing.
|
error: Manifest source files are missing.
|
||||||
repo root: /Users/yeongyu/clawd/claw-code
|
repo root: /Users/yeongyu/clawd/claw-code
|
||||||
@@ -6303,7 +6302,7 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed)
|
|||||||
|
|
||||||
422. **`export --output-format json` and `--resume latest` report the same "no managed sessions" scenario using two different `kind` codes — `no_managed_sessions` vs `session_load_failed` — making "no session found" undetectable by a single kind-code check** — dogfooded 2026-04-30 KST (UTC+9) by Jobdori on `e939777f`. Running `claw export --output-format json` with no session present returns (on stderr, exit 1): `{"error":"no managed sessions found in .claw/sessions/<fingerprint>/","hint":"Start \`claw\` to create a session, then rerun with \`--resume latest\`.\nNote: claw partitions sessions per workspace fingerprint; sessions from other CWDs are invisible.","kind":"no_managed_sessions","type":"error"}`. Running `claw --resume latest /status --output-format json` with no session present returns (on stderr, exit 1): `{"error":"failed to restore session: no managed sessions found in .claw/sessions/<fingerprint>/","hint":"Start \`claw\` to create a session, then rerun with \`--resume latest\`.\nNote: claw partitions sessions per workspace fingerprint; sessions from other CWDs are invisible.","kind":"session_load_failed","type":"error"}`. Both describe the same root condition — there are no sessions to operate on — but they expose it via different `kind` discriminants. Automation that checks `kind == "no_managed_sessions"` to detect a cold workspace will miss the `--resume` path's `session_load_failed`, and vice versa. A wrapper that guards "run with --resume only if a session exists" must special-case both codes. The hint text is identical between them, suggesting the messages are logically equivalent. Additionally neither code matches the proposed canonical names `session_not_found` / `session_load_failed` as stable `ErrorKind` discriminants described in ROADMAP #77's fix shape, which explicitly proposes typed error-kind codes for session lifecycle failures. **Required fix shape:** (a) unify "no sessions found for this workspace fingerprint" under a single canonical `kind` code — either `no_managed_sessions` or `session_not_found` — used consistently by every command path that encounters an empty session registry; (b) if `session_load_failed` is a more general category (covering e.g. corrupt session files, IO errors, schema version mismatches), it should nest a concrete `reason:"no_managed_sessions"` or `reason:"session_not_found"` sub-field so callers can distinguish "empty registry" from "found but unreadable"; (c) align with the canonical error-kind contract proposed in #77; (d) add regression coverage proving `export` and `--resume latest` in an empty workspace both return an error with the same top-level `kind` code. **Why this matters:** session guard-rails in orchestration need a single stable `kind` to detect cold workspaces without enumerating all possible no-session synonyms. Two divergent codes for the same condition make defensive automation brittle and contradict the promise of machine-readable error envelopes. Source: Jobdori live dogfood, `e939777f`, 2026-04-30 KST (UTC+9).
|
422. **`export --output-format json` and `--resume latest` report the same "no managed sessions" scenario using two different `kind` codes — `no_managed_sessions` vs `session_load_failed` — making "no session found" undetectable by a single kind-code check** — dogfooded 2026-04-30 KST (UTC+9) by Jobdori on `e939777f`. Running `claw export --output-format json` with no session present returns (on stderr, exit 1): `{"error":"no managed sessions found in .claw/sessions/<fingerprint>/","hint":"Start \`claw\` to create a session, then rerun with \`--resume latest\`.\nNote: claw partitions sessions per workspace fingerprint; sessions from other CWDs are invisible.","kind":"no_managed_sessions","type":"error"}`. Running `claw --resume latest /status --output-format json` with no session present returns (on stderr, exit 1): `{"error":"failed to restore session: no managed sessions found in .claw/sessions/<fingerprint>/","hint":"Start \`claw\` to create a session, then rerun with \`--resume latest\`.\nNote: claw partitions sessions per workspace fingerprint; sessions from other CWDs are invisible.","kind":"session_load_failed","type":"error"}`. Both describe the same root condition — there are no sessions to operate on — but they expose it via different `kind` discriminants. Automation that checks `kind == "no_managed_sessions"` to detect a cold workspace will miss the `--resume` path's `session_load_failed`, and vice versa. A wrapper that guards "run with --resume only if a session exists" must special-case both codes. The hint text is identical between them, suggesting the messages are logically equivalent. Additionally neither code matches the proposed canonical names `session_not_found` / `session_load_failed` as stable `ErrorKind` discriminants described in ROADMAP #77's fix shape, which explicitly proposes typed error-kind codes for session lifecycle failures. **Required fix shape:** (a) unify "no sessions found for this workspace fingerprint" under a single canonical `kind` code — either `no_managed_sessions` or `session_not_found` — used consistently by every command path that encounters an empty session registry; (b) if `session_load_failed` is a more general category (covering e.g. corrupt session files, IO errors, schema version mismatches), it should nest a concrete `reason:"no_managed_sessions"` or `reason:"session_not_found"` sub-field so callers can distinguish "empty registry" from "found but unreadable"; (c) align with the canonical error-kind contract proposed in #77; (d) add regression coverage proving `export` and `--resume latest` in an empty workspace both return an error with the same top-level `kind` code. **Why this matters:** session guard-rails in orchestration need a single stable `kind` to detect cold workspaces without enumerating all possible no-session synonyms. Two divergent codes for the same condition make defensive automation brittle and contradict the promise of machine-readable error envelopes. Source: Jobdori live dogfood, `e939777f`, 2026-04-30 KST (UTC+9).
|
||||||
|
|
||||||
407. **`config --output-format json` returns `files[].loaded:false` with no `load_error`, `not_found`, or `skip_reason` field — automation cannot distinguish "file does not exist", "file exists but parse failed", and "file exists but was skipped by policy" from the same `loaded:false` value; also `loaded_files` and `merged_keys` are bare integers with no per-file attribution** — dogfooded 2026-04-30 by Jobdori on `e939777f`. Running `./claw --output-format json config` on a workspace with 5 discovered config files returns `{"kind":"config","cwd":"...","files":[{"loaded":false,"path":"/Users/yeongyu/.claw.json","source":"user"},{"loaded":true,"path":"/Users/yeongyu/.claw/settings.json","source":"user"},{"loaded":true,"path":"/Users/yeongyu/clawd/claw-code/.claw.json","source":"project"},{"loaded":false,"path":"/Users/yeongyu/clawd/claw-code/.claw/settings.json","source":"project"},{"loaded":false,"path":"/Users/yeongyu/clawd/claw-code/.claw/settings.local.json","source":"local"}],"loaded_files":2,"merged_keys":2}`. Three of five files have `loaded:false` with no accompanying `not_found:true`, `parse_error`, `io_error`, or `skip_reason`; automation must stat each path separately to guess why. Also `loaded_files:2` and `merged_keys:2` are bare counts — ambiguous whether `merged_keys:2` means 2 total top-level JSON keys across all files or 2 unique merged settings. **Required fix shape:** (a) add `not_found: bool` and optional `load_error: string` to each `files[]` entry so callers can distinguish missing, parse-broken, and policy-skipped files without filesystem probing; (b) document or rename `merged_keys` as `merged_setting_count` or `total_merged_keys` to remove the int-semantics ambiguity; (c) optionally add `merged_keys_by_file: [{path, keys}]` for attribution; (d) add regression coverage proving `files[]` entries with `loaded:false` carry at minimum `not_found` distinguishing non-existent paths from load failures. Source: Jobdori live dogfood, `e939777f`, 2026-04-30.
|
407. **DONE — `config --output-format json` returns structured file load states instead of bare `loaded:false` ambiguity** — fixed 2026-06-03 in `fix: report config file load statuses`. `claw config --output-format json` now emits `files[].status` (`loaded`, `not_found`, `skipped`, `load_error`), `reason`/`skip_reason`, and `detail` where applicable, plus top-level `load_error`, `merged_key_count`, and `merged_keys_meaning`. The config list surface is best-effort so one broken settings file no longer erases the rest of the discovery report, while section-specific config requests still preserve the typed nonzero parse-error envelope. Regression coverage: `inspect_classifies_missing_loaded_and_legacy_skipped_files`, `inspect_reports_parse_errors_but_keeps_valid_merged_config`, `config_json_reports_structured_unloaded_file_reasons_407`, `config_json_list_reports_parse_errors_without_dropping_file_statuses_407`, and existing `config_parse_error_has_typed_error_kind_and_hint_764`.
|
||||||
|
|
||||||
|
|
||||||
408. **`status --output-format json` `workspace.changed_files` is ambiguous — on a workspace with 5 untracked files, `changed_files:5`, `staged_files:0`, `unstaged_files:0`, `untracked_files:5`; it is unclear whether `changed_files` is the sum of all four git-status categories or only a subset; automation cannot tell if `changed_files:5` means "5 tracked modified" or "5 total non-clean files including untracked"** — dogfooded 2026-04-30 by Jobdori on `e939777f`. Running `./claw --output-format json status` returns `{"workspace":{"changed_files":5,"staged_files":0,"unstaged_files":0,"untracked_files":5,...}}` — `changed_files==untracked_files==5` with staged and unstaged both zero. The field name `changed_files` implies "modified tracked files" but the value equals the untracked count, not `staged+unstaged`. Without a comment or documented definition, automation must probe whether `changed_files = staged + unstaged` (excludes untracked) or `changed_files = staged + unstaged + untracked + conflicted` (total dirty). Also `git_state:"dirty · 5 files · 5 untracked"` repeats the same data as a prose string alongside the structured integer fields — redundant human-readable string alongside machine-readable integers. **Required fix shape:** (a) document and stabilize `changed_files` as either `tracked_dirty_count` (staged+unstaged only) or `total_non-clean_count` (staged+unstaged+untracked+conflicted) and rename to remove the ambiguity; (b) ensure a machine consumer can compute `is_clean` as a single boolean field without interpreting `git_state` prose; (c) deprecate or remove `git_state` prose string now that all its constituent counts are available as integers; (d) add regression coverage proving `changed_files` semantics against a workspace with staged, unstaged, untracked, and conflicted files. Source: Jobdori live dogfood, `e939777f`, 2026-04-30.
|
408. **`status --output-format json` `workspace.changed_files` is ambiguous — on a workspace with 5 untracked files, `changed_files:5`, `staged_files:0`, `unstaged_files:0`, `untracked_files:5`; it is unclear whether `changed_files` is the sum of all four git-status categories or only a subset; automation cannot tell if `changed_files:5` means "5 tracked modified" or "5 total non-clean files including untracked"** — dogfooded 2026-04-30 by Jobdori on `e939777f`. Running `./claw --output-format json status` returns `{"workspace":{"changed_files":5,"staged_files":0,"unstaged_files":0,"untracked_files":5,...}}` — `changed_files==untracked_files==5` with staged and unstaged both zero. The field name `changed_files` implies "modified tracked files" but the value equals the untracked count, not `staged+unstaged`. Without a comment or documented definition, automation must probe whether `changed_files = staged + unstaged` (excludes untracked) or `changed_files = staged + unstaged + untracked + conflicted` (total dirty). Also `git_state:"dirty · 5 files · 5 untracked"` repeats the same data as a prose string alongside the structured integer fields — redundant human-readable string alongside machine-readable integers. **Required fix shape:** (a) document and stabilize `changed_files` as either `tracked_dirty_count` (staged+unstaged only) or `total_non-clean_count` (staged+unstaged+untracked+conflicted) and rename to remove the ambiguity; (b) ensure a machine consumer can compute `is_clean` as a single boolean field without interpreting `git_state` prose; (c) deprecate or remove `git_state` prose string now that all its constituent counts are available as integers; (d) add regression coverage proving `changed_files` semantics against a workspace with staged, unstaged, untracked, and conflicted files. Source: Jobdori live dogfood, `e939777f`, 2026-04-30.
|
||||||
@@ -6345,31 +6344,31 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed)
|
|||||||
422. **Unknown top-level subcommands fall through to chat prompt path instead of returning `unknown_subcommand` error — typos silently send the subcommand string as a chat message to the configured LLM** — dogfooded 2026-05-11 by Jobdori on `b98b9a71` in response to Clawhip pinpoint nudge at `1503215095088676956`. Reproduction: `unset ANTHROPIC_AUTH_TOKEN; export ANTHROPIC_API_KEY=fake-key-for-routing-test; claw completely-bogus-subcommand --output-format json` returns `{"error":"api returned 401 Unauthorized (authentication_error) [trace req_011...]: invalid x-api-key","kind":"api_http_error"}` — proving the unknown token reached the Anthropic API endpoint as a chat prompt. With valid credentials, the bogus subcommand string would be silently consumed as a chat message, billing the user for a typo and producing whatever continuation the LLM generates. **Pre-error path:** `claw <unknown> --output-format json` with no creds returns `kind:"missing_credentials"` (the auth gate fires first), masking the routing bug. Only with creds present does the fallthrough manifest as the actual prompt being sent. **Sibling exit-code bug:** when the chat-path 401 returns, the JSON envelope is `kind:"api_http_error"` but exit code is **0**, while `cli_parse` errors (e.g. `--no-such-flag`) and `missing_credentials` errors correctly exit **1**. Exit-code parity between error envelopes is broken — automation that gates on `$?` will treat the 401-as-chat as success. **Required fix shape:** (a) reserve unknown top-level tokens that match no registered subcommand and emit `kind:"unknown_subcommand"` with `unknown:<token>` field and exit code 1, BEFORE the chat fallback path; (b) when a token is intended as a chat prompt, require an explicit verb (`prompt`, `chat`, `ask`) or `--prompt` flag; (c) ensure exit codes are non-zero for all `kind:*_error` envelopes; (d) regression test: `claw <bogus> --output-format json` with valid auth returns `kind:"unknown_subcommand"` exit 1, never reaches the API. **Why this matters:** automation that calls `claw <subcommand>` with a programmatically constructed verb (typo, version drift, refactored command) silently bills tokens and produces hallucinated output instead of a typed error. Cross-cluster with #108 (CLI fallthrough discovered earlier) — #422 is the post-#108 audit confirming the routing bug still bites with valid credentials. Source: Jobdori live dogfood, `b98b9a71`, 2026-05-11.
|
422. **Unknown top-level subcommands fall through to chat prompt path instead of returning `unknown_subcommand` error — typos silently send the subcommand string as a chat message to the configured LLM** — dogfooded 2026-05-11 by Jobdori on `b98b9a71` in response to Clawhip pinpoint nudge at `1503215095088676956`. Reproduction: `unset ANTHROPIC_AUTH_TOKEN; export ANTHROPIC_API_KEY=fake-key-for-routing-test; claw completely-bogus-subcommand --output-format json` returns `{"error":"api returned 401 Unauthorized (authentication_error) [trace req_011...]: invalid x-api-key","kind":"api_http_error"}` — proving the unknown token reached the Anthropic API endpoint as a chat prompt. With valid credentials, the bogus subcommand string would be silently consumed as a chat message, billing the user for a typo and producing whatever continuation the LLM generates. **Pre-error path:** `claw <unknown> --output-format json` with no creds returns `kind:"missing_credentials"` (the auth gate fires first), masking the routing bug. Only with creds present does the fallthrough manifest as the actual prompt being sent. **Sibling exit-code bug:** when the chat-path 401 returns, the JSON envelope is `kind:"api_http_error"` but exit code is **0**, while `cli_parse` errors (e.g. `--no-such-flag`) and `missing_credentials` errors correctly exit **1**. Exit-code parity between error envelopes is broken — automation that gates on `$?` will treat the 401-as-chat as success. **Required fix shape:** (a) reserve unknown top-level tokens that match no registered subcommand and emit `kind:"unknown_subcommand"` with `unknown:<token>` field and exit code 1, BEFORE the chat fallback path; (b) when a token is intended as a chat prompt, require an explicit verb (`prompt`, `chat`, `ask`) or `--prompt` flag; (c) ensure exit codes are non-zero for all `kind:*_error` envelopes; (d) regression test: `claw <bogus> --output-format json` with valid auth returns `kind:"unknown_subcommand"` exit 1, never reaches the API. **Why this matters:** automation that calls `claw <subcommand>` with a programmatically constructed verb (typo, version drift, refactored command) silently bills tokens and produces hallucinated output instead of a typed error. Cross-cluster with #108 (CLI fallthrough discovered earlier) — #422 is the post-#108 audit confirming the routing bug still bites with valid credentials. Source: Jobdori live dogfood, `b98b9a71`, 2026-05-11.
|
||||||
|
|
||||||
|
|
||||||
423. **`claw prompt` does not read prompt text from stdin when no positional prompt arg is provided — `echo "what is 2+2" | claw prompt --output-format json` returns `kind:"unknown" error:"prompt subcommand requires a prompt string"` instead of consuming stdin** — dogfooded 2026-05-11 by Jobdori on `3c563fa1` in response to Clawhip pinpoint nudge at `1503222644739276951`. Reproduction: `echo "what is 2+2" | claw prompt --output-format json` → `{"error":"prompt subcommand requires a prompt string","hint":null,"kind":"unknown","type":"error"}` exit 1. Same for `claw prompt --output-format json` with stdin redirected from a file. The most common Unix automation pattern (`cmd | claw prompt`) is broken because the prompt subcommand only reads the positional argument, never falls through to stdin. **Sibling envelope-kind bug:** the error `kind` is `"unknown"` instead of a typed `"missing_argument"` or `"validation_error"`. The `unknown` discriminator is the catch-all bucket — automation that switches on `kind` to differentiate input-validation errors from runtime errors gets no signal here. **Required fix shape:** (a) when `prompt` subcommand has no positional prompt arg AND stdin is not a TTY (i.e., piped or redirected), read stdin to EOF and use that as the prompt; (b) emit `kind:"missing_argument"` (not `"unknown"`) when both positional arg and stdin are absent; (c) add `--prompt-stdin` or `--stdin` opt-in flag for explicit control; (d) regression tests: `echo X | claw prompt --output-format json` reaches the runtime with prompt=X, AND `claw prompt < /dev/null` returns `kind:"missing_argument"` exit 1. **Why this matters:** Unix pipelines are the foundation of CLI automation. Every other major CLI (curl, jq, gh, kubectl) accepts stdin as the primary input when no positional arg is given. Breaking this convention forces automation to either inline the prompt as a shell-quoted string (escaping nightmare for multiline/code) or write to a temp file first. The `kind:"unknown"` error category compounds the problem by making the failure indistinguishable from a runtime crash. Source: Jobdori live dogfood, `3c563fa1`, 2026-05-11.
|
423. **DONE — `claw prompt` reads prompt text from stdin when no positional prompt arg is provided** — fixed 2026-06-03 in `fix: read prompt subcommand input from stdin`. `parse_args()` now treats non-empty piped stdin as the prompt body for `claw prompt` when the positional prompt is empty, and supports `--stdin` / `--prompt-stdin` to append piped context to an explicit positional prompt. The existing `missing_prompt` JSON/stdout contract is preserved for closed or whitespace-only stdin. User docs now show `printf '...' | ./target/debug/claw prompt --output-format json`, and regression coverage verifies both a pure stdin prompt and explicit stdin context reach the mock Anthropic provider request and return structured JSON output.
|
||||||
|
|
||||||
|
|
||||||
424. **`--model` rejects bare canonical Anthropic model names (`claude-opus-4-7`, `claude-opus-4-6`, `claude-sonnet-4-6`) as `invalid_model_syntax` — only short aliases (`opus`, `sonnet`, `haiku`) and full prefixed form (`anthropic/claude-opus-4-7`) work; sibling: error message stale-suggests `claude-opus-4-6` not `4-7`** — dogfooded 2026-05-11 by Jobdori on `6c0c305a` in response to Clawhip pinpoint nudge at `1503230194889134103`. Reproduction: `claw --model claude-opus-4-7 status --output-format json` → `{"error":"invalid model syntax: 'claude-opus-4-7'. Expected provider/model (e.g., anthropic/claude-opus-4-6) or known alias (opus, sonnet, haiku)","kind":"invalid_model_syntax"}`. Same for `claude-opus-4-6`, `claude-sonnet-4-6`. Forcing `--model anthropic/claude-opus-4-7` works (`model:"anthropic/claude-opus-4-7"`, `model_source:"flag"`). Three problems compounded: (a) Anthropic-canonical model names without provider prefix are rejected even though the `claude-` prefix unambiguously identifies the provider; (b) the error suggests `anthropic/claude-opus-4-6` as the example — `4-7` shipped 2026-04-16 and is the current production Anthropic frontier model, the suggestion is one model behind; (c) the alias list `opus, sonnet, haiku` doesn't disambiguate version (which `opus` does the alias resolve to — `opus-4-6` or `opus-4-7`?). **Required fix shape:** (a) accept bare `claude-*` and `gpt-*` model names as canonical-named-without-prefix and route via name-prefix detection (already implemented for prefix-routed mode); (b) update the example in `invalid_model_syntax` error to current frontier (`anthropic/claude-opus-4-7`); (c) document or expose `opus` → exact-version mapping in the error message and in `claw doctor`/`status` output (`model_alias_resolved_to: "claude-opus-4-7"`); (d) regression test: `claw --model claude-opus-4-7 status --output-format json` returns `model_source:"flag"`, not `kind:"invalid_model_syntax"`. **Sibling bug observed in same probe:** `enabledPlugins` deprecation warning repeats 3 times in stderr for the same `~/.claw/settings.json` load — config file is being loaded/parsed 3 times during a single `status` invocation. **Why this matters:** every Anthropic doc, every CCAPI route, every internal tooling references models by their bare canonical name (`claude-opus-4-7`). Forcing the `anthropic/` prefix breaks copy-paste from Anthropic's own examples and adds a redundant token to every invocation. The stale `4-6` suggestion in the error message actively misdirects users away from the current model. Source: Jobdori live dogfood, `6c0c305a`, 2026-05-11.
|
424. **DONE — `--model` accepts bare canonical provider model names and Anthropic routing prefixes are stripped before provider calls** — fixed 2026-06-03 in `fix: normalize Anthropic model routing`. `validate_model_syntax()` now accepts unambiguous bare `claude-*` and `gpt-*` model IDs while preserving raw model provenance, and Anthropic `/v1/messages` plus `/v1/messages/count_tokens` request bodies strip the CLI-only `anthropic/` routing prefix so default/alias models do not reach Anthropic as `anthropic/claude-*`. Existing `qwen-*`/`grok-*` prefix-hint behavior remains intentionally unchanged for provider families whose bare names are ambiguous with DashScope/xAI routing. Regression coverage: `standard_messages_body_strips_anthropic_routing_prefix`, `send_message_strips_anthropic_routing_prefix_on_wire`, `default_model_alias_uses_anthropic_routing_prefix`, and the bare `--model=claude-opus-4-6 status` / `--model gpt-4 prompt` parser assertions in `parses_single_word_command_aliases_without_falling_back_to_prompt_mode`.
|
||||||
|
|
||||||
|
|
||||||
425. **Config file precedence (`.claw/settings.json` always wins over `.claw.json`) is undocumented in user-facing surfaces — `config --output-format json` reports both files as `loaded:true` with no `precedence_rank` or `wins_for_keys` attribution; sibling: deprecation warning fires 4× per status invocation (was 3× in #424, regression upward)** — dogfooded 2026-05-11 by Jobdori on `d7dbe951` in response to Clawhip pinpoint nudge at `1503237744451649537`. Reproduction: create `.claw.json` with `{"model":"anthropic/claude-sonnet-4-6"}` and `.claw/settings.json` with `{"model":"anthropic/claude-opus-4-7"}` in the same workspace. `claw status --output-format json` returns `model:"anthropic/claude-opus-4-7", model_source:"config"`. Reverse the files (.claw.json=opus, settings.json=sonnet) → `model:"anthropic/claude-sonnet-4-6"`. Confirmed: `.claw/settings.json` **always** wins over `.claw.json` for conflicting keys, regardless of file mtime or alphabetical order. `claw config --output-format json` reports both as `loaded:true` with no `precedence_rank`, `effective_for_keys`, or `shadowed_keys` attribution. The only signal of precedence is the final merged value in `status` — automation cannot programmatically discover which file contributed which key without re-implementing the merge logic. **Sibling bug (regression from #424):** the `enabledPlugins` deprecation warning now fires **4 times** in stderr per single `status` invocation (was 3× in #424's probe at HEAD `6c0c305a`; current HEAD `d7dbe951` shows 4×). Config load count went up by 1. **Sibling bug observed in config-section probe:** `claw config model --output-format json` with a `.claw.json` that contains a benign unknown key (e.g., `"alpha":"x"`) returns `{"error":"/path/.claw.json: unknown key \"alpha\" (line 1)","kind":"unknown"}` — the entire config command fails with a generic `unknown` kind instead of (a) tolerating unrecognized keys with a warning, or (b) emitting a typed `kind:"unknown_key"` error scoped to the offending file/key. **Required fix shape:** (a) document precedence order in `USAGE.md` (`.claw/settings.local.json > .claw/settings.json > .claw.json` for project scope; `user`/`system` scope at each layer); (b) add `precedence_rank:int` and optional `wins_for_keys:[string]` / `shadowed_keys:[string]` to each entry in `config --output-format json` `files[]`; (c) dedupe the deprecation warning to fire **once per discovered file** instead of N× per load pass; (d) make `config <section> --output-format json` tolerate unknown keys with warnings, OR emit `kind:"unknown_key"` with `path:` and `key:` fields scoped to the offending file. **Why this matters:** users mixing legacy `.claw.json` with new `.claw/settings.json` have no way to verify which file is actually controlling their runtime. The undocumented precedence + missing per-key attribution forces trial-and-error to debug config drift. Cross-references #407 (config files no load_error) and #415 (config section returns merged_keys count not values). Source: Jobdori live dogfood, `d7dbe951`, 2026-05-11.
|
425. **DONE — config JSON exposes file precedence attribution and unknown config keys are warnings** — fixed 2026-06-03 in `fix: attribute config precedence in JSON`. Runtime config inspection now reports every discovered file with `precedence_rank`, `wins_for_keys`, and `shadowed_keys`, so `.claw/settings.json` overriding legacy `.claw.json` is visible without reimplementing merge order. Unknown keys are tolerated as structured validation warnings, including `claw config <section> --output-format json`, while wrong-type errors still fail. The deprecation-warning path remains deduplicated once per process for text-mode `status`, and JSON config surfaces collect warnings structurally without stderr duplication. Docs in `USAGE.md` now spell out the precedence chain and JSON attribution fields. Regression coverage: `config_json_attributes_precedence_and_shadowed_keys_425`, `config_section_json_tolerates_unknown_keys_as_warnings_425`, `status_deduplicates_config_deprecation_warnings_per_invocation_425`, and the runtime validator unknown-key warning tests.
|
||||||
|
|
||||||
|
|
||||||
426. **`ANTHROPIC_MODEL` env var bypasses the `invalid_model_syntax` validator that `--model` enforces — bogus model strings are accepted with `status:"ok"`, deferred-failing only when the first API call is made** — dogfooded 2026-05-11 by Jobdori on `3730b459` in response to Clawhip pinpoint nudge at `1503245298800136296`. Reproduction (asymmetric validation): `claw --model bogus-model-xyz status --output-format json` returns `kind:"invalid_model_syntax"` exit 1; `ANTHROPIC_MODEL=bogus-model-xyz claw status --output-format json` returns `model:"bogus-model-xyz", model_raw:"bogus-model-xyz", model_source:"env", status:"ok"` — the doctor surface lies that the configured model is valid when it is not. The bogus model only manifests as a failure when the first prompt fires and the API rejects it with 404/400. Three sibling discoveries in the same probe: (a) **alias indirection invisible**: `ANTHROPIC_MODEL=opus claw status --output-format json` returns `model:"claude-opus-4-6", model_raw:"opus", model_source:"env"` — the `opus` alias resolves to `claude-opus-4-6` (the *previous* frontier, not the current `claude-opus-4-7` released 2026-04-16). Users typing `opus` get yesterday's model with no warning. (b) **`CLAW_MODEL` env var silently ignored**: `CLAW_MODEL=opus claw status` shows `model:"claude-opus-4-6" model_source:"default"` — the `CLAW_MODEL` env var (the project-namespaced equivalent that users expect) does not exist; only `ANTHROPIC_MODEL` is honored. No warning when a `CLAW_*` env var that looks like it should work is set. (c) **`ANTHROPIC_DEFAULT_MODEL` also silently ignored**: the longer-named env var that some Anthropic SDKs use is not recognized. **Required fix shape:** (a) symmetric validation: `ANTHROPIC_MODEL` env value must pass the same `invalid_model_syntax` check that `--model` does, and `claw status` must return `kind:"invalid_model"` / `status:"warn"` (not `status:"ok"`) when the resolved model is unrecognized; (b) expose alias resolution in `status`: add `model_alias_resolved_to:string|null` field so automation can see `opus → claude-opus-4-6`; (c) bump the `opus` alias to `claude-opus-4-7` (current frontier) or document the alias-to-version mapping policy explicitly; (d) accept `CLAW_MODEL` and `ANTHROPIC_DEFAULT_MODEL` env vars with parity to `ANTHROPIC_MODEL`, OR emit a warning when those env vars are set but unrecognized. **Why this matters:** the most common automation pattern is `export ANTHROPIC_MODEL=...` in a shell rc file. Bogus values pass silently, alias indirection hides the actual model in use, and `CLAW_MODEL` looking like a working name but doing nothing is a footgun. Cross-references #424 (bare canonical names rejected at validator level) — together #424 + #426 make model selection inconsistent across CLI flag, env var, and alias paths. Source: Jobdori live dogfood, `3730b459`, 2026-05-11.
|
426. **DONE — environment model selection is validated and status exposes alias/env provenance** — fixed 2026-06-03 in `fix: validate env model selection`. `CLAW_MODEL`, `ANTHROPIC_MODEL`, and `ANTHROPIC_DEFAULT_MODEL` now share the same env-model path before config/default fallback; prompt/REPL startup validates the resolved model before provider construction; and `status --output-format json` reports invalid env/config models as `status:"warn"` with `model_validation_error_kind:"invalid_model"` while preserving workspace/config/sandbox context. Status JSON now includes `model_alias_resolved_to` and `model_env_var`, making alias expansion and the winning env var auditable. The built-in/default `opus` alias now targets `anthropic/claude-opus-4-7` / `claude-opus-4-7`, with docs updated in `USAGE.md` and `rust/README.md`; the API alias table keeps token-limit metadata for both `claude-opus-4-7` and legacy `claude-opus-4-6`. Regression coverage: `status_json_accepts_namespaced_model_env_and_surfaces_alias_426`, `status_json_warns_on_invalid_model_env_426`, model alias/unit tests, and provider alias tests.
|
||||||
|
|
||||||
|
|
||||||
427. **Subcommand `--help` paths (`resume`, `session`, `compact`) hit the auth gate and trigger config validation before returning static help — `claw resume --help` with no credentials returns `missing_credentials` error instead of help text** — dogfooded 2026-05-11 by Jobdori on `1fecdf09` in response to Clawhip pinpoint nudge at `1503252843669491892`. Reproduction (no env vars, isolated `CLAW_CONFIG_HOME`): `claw resume --help` returns `{"error":"missing Anthropic credentials; export ANTHROPIC_AUTH_TOKEN or ANTHROPIC_API_KEY..."}` instead of usage text. Same for `claw session --help`, `claw compact --help`. By contrast, `claw prompt --help` and `claw --help` (top-level) return proper usage text without auth. Even worse: with a broken `.claw.json` discovered up the parent directory tree (e.g., `mcpServers.missing-command: missing string field command`), the subcommand `--help` paths fail with `[error-kind: unknown]` from config validation — config load is happening before `--help` is parsed. **Sibling exit-code bug:** `claw resume --help --output-format json` returns `kind:"missing_credentials"` but exits **0** (the exit-code parity bug from #422 reproduces on this path too — only `cli_parse` exits 1 consistently). **Sibling: `claw resume <bogus-id>` should be local-only** but also hits `missing_credentials` — `resume` of a session that doesn't exist on disk should return `kind:"session_not_found"` from a local lookup, not require API credentials. Same class as ROADMAP #357 (session list requires creds) and #369 (session help/fork require credentials) — now confirmed for `resume`. **Required fix shape:** (a) `--help` MUST short-circuit before any auth check, config load, or session resolution — emit static usage text from a compiled-in string table, no I/O; (b) `resume <id>` must check the local session store first; if the id is absent on disk, emit `kind:"session_not_found"` with `sessions_dir` field; only require auth when resuming a known-on-disk session that requires re-establishing API context; (c) ensure exit code 1 for all error envelopes including `missing_credentials` returned from a `--help` path that should never have reached the auth gate; (d) regression test: with empty `CLAW_CONFIG_HOME` and no env vars, every `claw <subcommand> --help` returns usage text on stdout, exit 0, no `kind:*_error` envelope. **Why this matters:** `--help` is the universal CLI discovery primitive. Failing `--help` because of missing API credentials or broken config files makes claw undiscoverable to users debugging an already-broken setup. Cross-references #357 (session list), #369 (session help/fork), #422 (exit code parity), #108 (subcommand fallthrough). Source: Jobdori live dogfood, `1fecdf09`, 2026-05-11.
|
427. **DONE — resume/session/compact help short-circuits locally and missing resume sessions report the session store** — fixed 2026-06-03 in `fix: keep session help local`. `claw resume --help`, `claw --resume --help`, `claw session --help`, and `claw compact --help` now route through static `LocalHelpTopic` output before config loading, session resolution, credential checks, provider startup, or slash-command interactive-only fallthrough. The direct `claw resume <session>` alias now shares the existing `--resume` restore parser, so `claw resume <missing> --output-format json` returns a local `session_not_found` restore envelope with `sessions_dir` and exit code 1 instead of reaching provider credentials. Regression coverage: `resume_session_compact_help_short_circuits_before_config_or_auth_427`, `resume_missing_session_json_reports_local_store_before_auth_427`, local help parser tests, and resume parser tests.
|
||||||
|
|
||||||
|
|
||||||
428. **Default `permission_mode` is `danger-full-access` — claw runs with FULL filesystem + network + tool access out of the box, with no opt-in flag and no warning from `doctor`** — dogfooded 2026-05-11 by Jobdori on `72048449` in response to Clawhip pinpoint nudge at `1503260393622212628`. Reproduction (no env vars, isolated `CLAW_CONFIG_HOME`, no config files, no CLI flags): `claw status --output-format json` returns `permission_mode:"danger-full-access"` as the default. The three supported modes per the validator error message are `read-only`, `workspace-write`, `danger-full-access` — and `danger-full-access` is chosen with zero user opt-in. `claw doctor --output-format json` produces a `sandbox` check with `status:"warn", summary:"sandbox was requested but is not currently active"` (because macOS lacks Linux `unshare`), but **emits no warning, info, or summary about the permission_mode itself being danger-full-access**. There is no `permissions` check in `doctor` output at all. **Required fix shape:** (a) change default `permission_mode` to `workspace-write` (safe-by-default: filesystem write limited to cwd, network limited to LLM endpoints, no arbitrary command exec); (b) require explicit `--permission-mode danger-full-access` or `--dangerously-skip-permissions` to opt into full access; (c) add a `permissions` check to `doctor --output-format json` that emits `status:"warn"` when `permission_mode == "danger-full-access"` without explicit source (flag/env/config), with details like `mode:"danger-full-access", source:"default", message:"running with full access without explicit opt-in"`; (d) document the three modes and the default in USAGE.md with one-paragraph descriptions of what each mode allows. **Sibling typed-error bug:** `claw --permission-mode bogus-mode status --output-format json` returns `kind:"unknown"` instead of `kind:"invalid_permission_mode"` — same catch-all problem as #424, #426. **Sibling flag-name asymmetry:** `--dangerously-skip-permissions` works but `--skip-permissions` (Claude Code's flag) returns `kind:"cli_parse"` `unknown option`. Users migrating from Claude Code lose the short flag name. **Why this matters:** every other security-conscious CLI (Docker, kubectl, terraform) requires explicit opt-in for dangerous modes. Defaulting to `danger-full-access` is a footgun for first-time users who pipe `curl install.sh | sh` and immediately get a tool with full filesystem write and arbitrary command exec. The doctor surface is the only diagnostic users consult before trusting the tool, and it stays silent about the most permissive setting. Cross-references #50, #87, #91, #94, #97, #101, #106, #115, #123 (permission-audit sweep) — those all cover permission *rule* and *list* surfaces; #428 covers the *mode default* itself. Source: Jobdori live dogfood, `72048449`, 2026-05-11.
|
428. **DONE — default permission mode is workspace-write with auditable permission provenance** — fixed 2026-06-03 in `fix: default to workspace-write permissions`. Fresh invocations now resolve the fallback permission mode to `workspace-write` instead of `danger-full-access`; `danger-full-access` requires an explicit `--permission-mode danger-full-access`, `--dangerously-skip-permissions`, `--skip-permissions`, env, or config opt-in. `status --output-format json` includes `permission_mode_source` and `permission_mode_env_var`, and `doctor --output-format json` includes a `permissions` check with `mode`, `source`, `source_explicit`, `message`, and tool allow/gate lists. Invalid CLI permission modes now emit typed `invalid_permission_mode` JSON errors, and docs describe the three modes plus the safe default. Regression coverage: `default_permission_mode_is_workspace_write_and_audited_428`, `explicit_danger_permission_mode_is_audited_and_alias_supported_428`, `invalid_permission_mode_json_is_typed_428`, parser default tests, classifier coverage, and `given_workspace_write_enforcer_when_web_tools_then_denied`.
|
||||||
|
|
||||||
|
|
||||||
429. **No global `--cwd`/`-C`/`--directory` flag — `claw` cannot be invoked against an arbitrary working directory without first `cd`-ing into it; `--cwd` only exists as a subcommand option for `system-prompt`, and the `cli_parse` "Did you mean --acp?" suggestion is misleading (the `--acp` flag is unrelated to directory selection)** — dogfooded 2026-05-11 by Jobdori on `ec882f4c` in response to Clawhip pinpoint nudge at `1503267943285264394`. Reproduction: `claw --cwd /tmp/claw-dog-cwd status --output-format json` → `{"error":"unknown option: --cwd","hint":"Did you mean --acp?\nRun `claw --help` for usage.","kind":"cli_parse"}`. Same error for `--cwd <relative>`, `--cwd <nonexistent>`, `--cwd <file-not-dir>`, `--cwd ""`. Inspecting `claw --help`: `--cwd PATH` appears ONLY in the usage line `claw system-prompt [--cwd PATH] [--date YYYY-MM-DD]` — it is not a global flag and is not accepted by `status`, `doctor`, `mcp list`, `init`, or any other subcommand. Users programmatically running claw against multiple workspaces must `cd` into each one before invoking, breaking the `subprocess.run(['claw', 'status', '--cwd', ws], cwd=other_dir)` pattern that every other major CLI (cargo `-C`, git `-C`, npm `--prefix`, gh `--repo` semantically, kubectl `--kubeconfig`+`--context`) supports. **Sibling misleading-suggestion bug:** the `cli_parse` error's `hint` field suggests `Did you mean --acp?` for `--cwd`. `--acp` is the alias for ACP/Zed editor integration (entirely unrelated to working directory). The Levenshtein-distance auto-complete is matching on first-character similarity without considering semantic relatedness. Users following the hint get a totally orthogonal feature. **Required fix shape:** (a) add a global `--cwd PATH` / `-C PATH` flag accepted before any subcommand, parsed in the global flag pre-pass; (b) validate the path exists and is a directory; emit `kind:"invalid_cwd"` with `path:` and `reason:` (`"not_found"`/`"not_a_directory"`/`"empty"`) when validation fails; (c) document the precedence: `--cwd` flag > `$PWD` > `env::current_dir()`; (d) fix the "Did you mean" hint algorithm to filter suggestions by semantic category (don't suggest `--acp` for `--cwd`; suggest `claw system-prompt --cwd PATH` if the user clearly wants `cwd` override but used the wrong scope); (e) regression test: `claw --cwd /tmp status --output-format json` from any `$PWD` returns `workspace.cwd:"/private/tmp"` (or `cwd:"/tmp"` after #421 fix). **Why this matters:** every claw automation orchestrator runs claw against multiple workspaces from a single parent process. Forcing `cd` before each invocation breaks parallelism (can't use shared cwd across concurrent invocations), breaks subprocess wrappers that want to pass cwd explicitly, and breaks `xargs`/`parallel`-style pipelines. Cross-references #421 (cwd canonicalization leak — fix should canonicalize but report user-input via `--cwd`). Source: Jobdori live dogfood, `ec882f4c`, 2026-05-11.
|
429. **DONE — global workspace directory override is accepted and validated before dispatch** — fixed 2026-06-03 in `fix: add global cwd override`. `claw --cwd PATH ...`, `claw -C PATH ...`, and `claw --directory PATH ...` now run as if launched from the selected workspace before config, status, doctor, MCP, skills, and other command dispatch. The override takes precedence over process `$PWD`; invalid values emit typed `invalid_cwd` JSON errors with `path` and `reason` (`not_found`, `not_a_directory`, or `empty`) instead of the old misleading `Did you mean --acp?` CLI parse path. Help/usage docs list the global flags and the precedence/validation contract. Regression coverage: `global_cwd_flag_routes_status_workspace_and_short_alias_429`, `global_cwd_flag_reports_typed_invalid_paths_429`, and classifier coverage for `invalid_cwd`.
|
||||||
|
|
||||||
|
|
||||||
430. **`dump-manifests` is documented as "emit every skill/agent/tool manifest the resolver would load for the current cwd" but actually requires the upstream Claude Code TypeScript source files (`src/commands.ts`, `src/tools.ts`, `src/entrypoints/cli.tsx`) — the command is unusable for any user who installed claw without cloning the original Claude Code repo** — dogfooded 2026-05-11 by Jobdori on `075c2144` in response to Clawhip pinpoint nudge at `1503275502046023690`. Reproduction: `claw dump-manifests --output-format json` returns `{"error":"Manifest source files are missing.","hint":"repo root: /private/tmp/claw-dog-0530\n missing: src/commands.ts, src/tools.ts, src/entrypoints/cli.tsx\n Hint: set CLAUDE_CODE_UPSTREAM=/path/to/upstream or pass \`claw dump-manifests --manifests-dir /path/to/upstream\`.","kind":"missing_manifests"}`. The fresh-main worktree at `/private/tmp/claw-dog-0530` does not contain these TypeScript files because the Rust port doesn't include the upstream TS source. The `--help` text says the command works against "the current cwd" but in practice it requires `CLAUDE_CODE_UPSTREAM=` pointing at an unshipped TS source tree. **Three sibling problems compounded:** (a) **derivative-work disclosure leak**: the error message exposes that `claw-code` is a port of Claude Code (`CLAUDE_CODE_UPSTREAM` env var name) — even if true, surfacing this in a casual diagnostic message couples user-facing behavior to upstream provenance details. (b) **kind drift**: `claw dump-manifests --manifests-dir /tmp/nonexistent --output-format json` returns `kind:"unknown"`, while `claw dump-manifests` (no override) returns `kind:"missing_manifests"`. Same root cause (no usable upstream), two different `kind` discriminators — automation cannot switch on a single error type. (c) **export-positional-arg silently dropped**: probed in the same run — `claw export <bogus-positional>` ignores the path and returns `kind:"no_managed_sessions"` regardless of what positional arg was passed. The `--help` advertises `[PATH]` as the output-file destination but the path is discarded before validation, indistinguishable from invocation with no args. **Required fix shape:** (a) make `dump-manifests` emit the manifests claw-code itself ships with (Rust-resolver-discovered skills/agents/tools), independent of any upstream TS source — that matches the `--help` description; (b) if upstream-comparison is genuinely needed for parity work, move it to a separate command like `parity dump-upstream-manifests` and remove the upstream dependency from `dump-manifests`; (c) standardize on one error `kind` for the manifest-missing failure mode (`missing_manifests` is more descriptive than `unknown`); (d) `claw export <PATH>` must validate the path positional arg before the session-discovery check, so users see `kind:"invalid_output_path"` (or similar) when the path is malformed instead of always seeing `kind:"no_managed_sessions"`. **Why this matters:** `dump-manifests` is the inventory surface a downstream automation lane would call to learn what claw can do in the current workspace. If it's broken without upstream TS source, downstream lanes can't introspect — they have to fall back to `agents list`/`skills list`/`mcp list` separately and re-aggregate. Cross-references #422 (kind:unknown for unknown_subcommand), #423 (kind:unknown for missing_argument), #428 (kind:unknown for invalid_permission_mode) — `kind:"unknown"` keeps appearing as the catch-all for surfaces that should have typed kinds. Source: Jobdori live dogfood, `075c2144`, 2026-05-11.
|
430. **DONE — `dump-manifests` emits the self-contained Rust resolver inventory instead of requiring upstream Claude Code TypeScript source files** — fixed 2026-06-03 in `fix: make dump-manifests self-contained`. `claw dump-manifests --output-format json` now succeeds from an installed workspace with `source:"rust-resolver"`, command/tool/agent/skill/bootstrap manifests, no `CLAUDE_CODE_UPSTREAM` hint, and no `src/commands.ts` dependency. Explicit `--manifests-dir` scopes resolver discovery to another directory and missing/not-directory roots emit typed `missing_manifests` JSON. Sibling export diagnostics now validate explicit positional/`--output` paths before session discovery and return typed `invalid_output_path` JSON with `path` and `reason`. Regression coverage: `dump_manifests_defaults_to_rust_resolver_inventory`, `dump_manifests_scopes_explicit_manifest_dir_without_upstream_ts`, `dump_manifests_missing_explicit_dir_has_typed_kind`, `dump_manifests_and_init_emit_json_when_requested`, `local_json_surfaces_have_non_empty_action_contract_714`, and `export_invalid_output_path_reports_typed_json_430`.
|
||||||
|
|
||||||
|
|
||||||
431. **`skills uninstall <name>` requires Anthropic credentials despite being a local filesystem operation — `claw skills uninstall nonexistent-skill-xyz --output-format json` returns `kind:"missing_credentials"` instead of resolving locally that the skill doesn't exist** — dogfooded 2026-05-11 by Jobdori on `328fd114` in response to Clawhip pinpoint nudge at `1503275502046023690` (sibling probe to #430). Reproduction (no creds, isolated `CLAW_CONFIG_HOME`): `claw skills uninstall nonexistent-skill-xyz --output-format json` returns `{"error":"missing Anthropic credentials; export ANTHROPIC_AUTH_TOKEN or ANTHROPIC_API_KEY...","kind":"missing_credentials"}`. Uninstalling a skill is a pure local filesystem operation: read the skills directory, find the named skill, remove its files. There is no semantic reason to require API credentials. Same class of bug as #357 (`session list` requires creds), #369 (`session help/fork` require creds), and #427 (`resume <bogus-id>` requires creds). **Three sibling findings in same probe:** (a) `claw skills install <bogus-name>` returns `{"error":"No such file or directory (os error 2)","kind":"unknown"}` — leaks raw OS error string with no hint about expected install source format (path vs name vs URL?), and the catch-all `kind:"unknown"` again instead of typed `kind:"skill_install_source_not_found"`. (b) `claw skills install` (no args) returns `action:"help"` with `unexpected:"install"` — but `install` IS a documented subcommand. The handler treats it as "unknown action" instead of "missing required argument". Should emit `kind:"missing_argument"` with `argument:"install_source"`. (c) `claw agents create my-agent` returns `action:"help"` with `unexpected:"create my-agent"` — there is no agent-creation surface at all. Users must hand-craft `.claw/agents/<name>.md` files with no scaffolding command, while `claw init` only creates the top-level `.claw/` skeleton. **Required fix shape:** (a) `skills uninstall <name>` must be local-first: enumerate the local skills dir, return `kind:"skill_not_found"` (with `skills_dir:` and `available_names:[]` fields) for missing, or remove the files and return `kind:"skills"` with `action:"uninstall", removed:<name>` for present skills; (b) `skills install <source>` must distinguish source forms (`path:`, `name:`, `url:`) and emit `kind:"invalid_install_source"` with the parsed-and-failed reason; (c) `skills install` (no args) emits `kind:"missing_argument"` with `argument:"install_source"`; (d) add `claw agents create <name>` (or `claw init agent <name>`) that scaffolds `.claw/agents/<name>.md` with a stub frontmatter; or document explicitly that agents are user-authored only. **Why this matters:** lifecycle commands (`uninstall`, `install`, `create`) are the primary surface for managing claw's extension surface area. If `uninstall` requires API creds, an offline user who fat-fingered an install can't undo it. If `install` returns a raw OS error, automation can't programmatically recover. If `agents create` doesn't exist, agent authoring is undocumented file-touching only. Cross-references #357, #369, #427 (auth-gate-on-local-ops cluster), and #422/#423/#428/#430 (`kind:"unknown"` catch-all cluster). Source: Jobdori live dogfood, `328fd114`, 2026-05-11.
|
431. **DONE — `skills uninstall <name>` resolves locally instead of requiring Anthropic credentials** — fixed 2026-06-03 in `fix: keep skills lifecycle local`. `claw skills uninstall nonexistent-skill-xyz --output-format json` now stays on the local skills lifecycle surface and emits `kind:"skills"`, `action:"uninstall"`, `error_kind:"skill_not_found"`, `skills_dir`, `available_names`, and a hint without provider credentials. `claw skills install` no-arg emits typed `missing_argument` with `argument:"install_source"`; `claw skills install <bogus-name>` emits typed `invalid_install_source` with `source`, `source_kind`, `reason`, and a recovery hint. Installed skill roundtrips remove the installed files through the shared local lifecycle helper. `claw agents create <name>` now scaffolds `.claw/agents/<name>.toml` and lists through the existing TOML agent discovery surface. Regression coverage: `skills_lifecycle_errors_have_typed_local_json_795_431`, `skills_install_uninstall_roundtrip_stays_local_431`, `agents_create_scaffolds_toml_and_lists_locally_431`, local command routing tests, parser discriminant tests, and command help/docs assertions.
|
||||||
|
|
||||||
|
|
||||||
432. **`--allowedTools` validator inconsistency: tool name list is half snake_case (`bash`, `read_file`, `write_file`, `edit_file`, `glob_search`, `grep_search`) and half PascalCase (`WebFetch`, `WebSearch`, `TodoWrite`, `Skill`, `Agent`, `Sleep`) with three UPPERCASE entries (`REPL`, `LSP`, `MCP`); accepts undocumented CamelCase aliases (`Read`, `Write`, `Edit`) and silently translates them to snake_case; argument parsing consumes the next positional when value is missing** — dogfooded 2026-05-11 by Jobdori on `fad53e2d` in response to Clawhip pinpoint nudge at `1503283046856655029`. Reproduction: `claw --allowedTools status --output-format json` → `{"error":"unsupported tool in --allowedTools: status (expected one of: bash, read_file, write_file, edit_file, glob_search, grep_search, WebFetch, WebSearch, TodoWrite, Skill, Agent, ToolSearch, NotebookEdit, Sleep, SendUserMessage, Config, EnterPlanMode, ExitPlanMode, StructuredOutput, REPL, PowerShell, AskUserQuestion, TaskCreate, RunTaskPacket, TaskGet, TaskList, TaskStop, TaskUpdate, TaskOutput, WorkerCreate, WorkerGet, WorkerObserve, WorkerResolveTrust, WorkerAwaitReady, WorkerSendPrompt, WorkerRestart, WorkerTerminate, WorkerObserveCompletion, TeamCreate, TeamDelete, CronCreate, CronDelete, CronList, LSP, ListMcpResources, ReadMcpResource, McpAuth, RemoteTrigger, MCP, TestingPermission)","kind":"unknown"}`. The `status` subcommand was consumed as the `--allowedTools` value because the flag parser doesn't distinguish missing-value from end-of-flag-args. The error reveals **the supported tool list mixes naming conventions inconsistently within a single error message**: snake_case (`bash`, `read_file`, `write_file`, `edit_file`, `glob_search`, `grep_search`), PascalCase (`WebFetch`, `WebSearch`, `TodoWrite`, `Skill`, `Agent`, `Sleep`, `Config`, `PowerShell`, `AskUserQuestion`, `TaskCreate`, `WorkerCreate`, `TeamCreate`, `CronCreate`), UPPERCASE (`REPL`, `LSP`, `MCP`), and CamelCase compounds (`McpAuth`, `RemoteTrigger`). **Hidden alias mapping**: `claw --allowedTools Read,Write,Edit status --output-format json` is accepted and returns `allowed_tools.entries:["edit_file","read_file","write_file"]` — proving the validator has an undocumented CamelCase→snake_case alias map (`Read`→`read_file`, `Write`→`write_file`, `Edit`→`edit_file`) that is not surfaced in the error message. Users who copy-paste tool names from Claude Code documentation work, users who copy from the validator error don't. **Sibling missing-value bug:** `claw --allowedTools status` with `status` as a positional subcommand is interpreted as `--allowedTools=status`, swallowing the subcommand. The flag parser must require a value for `--allowedTools` and emit `kind:"missing_argument"` when followed by a recognized subcommand or `--`-prefixed flag instead of silently treating the next arg as a tool name. **Sibling typed-kind bug:** both errors use `kind:"unknown"` instead of typed `kind:"invalid_tool_name"` / `kind:"missing_argument"` — the catch-all keeps appearing (#422/#423/#424/#428/#430/#431/#432). **Required fix shape:** (a) standardize the canonical tool-name registry on one casing convention (snake_case is most CLI-ergonomic) and update both the registry and all CamelCase aliases; (b) document and expose the alias map (`tool_aliases:{Read:"read_file",...}`) in `claw doctor`/`status` and in the validator error; (c) flag parser must require a value for `--allowedTools` and refuse to consume a recognized subcommand or `-`/`--`-prefixed token as the value, emit `kind:"missing_argument"` with `argument:"--allowedTools"`; (d) emit `kind:"invalid_tool_name"` with `tool_name:` and `available:[]` fields instead of `kind:"unknown"`; (e) regression test that `claw --allowedTools <subcommand>` rejects with `missing_argument`, and that the canonical name list in errors uses the same casing as the alias map. **Why this matters:** `--allowedTools` is the primary surface for restricting claw's tool surface area (security-relevant). Inconsistent naming between the validator error and the alias map means users following the error message guidance pick names that work in some places and fail in others. The missing-value bug silently swallows a subcommand, leading to confusing "unsupported tool: status" errors when the user actually wanted to run `claw status`. Cross-references #94/#97/#101/#106/#115/#123 (permission-rule audit), #428 (default permission_mode), #422/#423/#424/#428/#430/#431 (`kind:"unknown"` catch-all). Source: Jobdori live dogfood, `fad53e2d`, 2026-05-11.
|
432. **`--allowedTools` validator inconsistency: tool name list is half snake_case (`bash`, `read_file`, `write_file`, `edit_file`, `glob_search`, `grep_search`) and half PascalCase (`WebFetch`, `WebSearch`, `TodoWrite`, `Skill`, `Agent`, `Sleep`) with three UPPERCASE entries (`REPL`, `LSP`, `MCP`); accepts undocumented CamelCase aliases (`Read`, `Write`, `Edit`) and silently translates them to snake_case; argument parsing consumes the next positional when value is missing** — dogfooded 2026-05-11 by Jobdori on `fad53e2d` in response to Clawhip pinpoint nudge at `1503283046856655029`. Reproduction: `claw --allowedTools status --output-format json` → `{"error":"unsupported tool in --allowedTools: status (expected one of: bash, read_file, write_file, edit_file, glob_search, grep_search, WebFetch, WebSearch, TodoWrite, Skill, Agent, ToolSearch, NotebookEdit, Sleep, SendUserMessage, Config, EnterPlanMode, ExitPlanMode, StructuredOutput, REPL, PowerShell, AskUserQuestion, TaskCreate, RunTaskPacket, TaskGet, TaskList, TaskStop, TaskUpdate, TaskOutput, WorkerCreate, WorkerGet, WorkerObserve, WorkerResolveTrust, WorkerAwaitReady, WorkerSendPrompt, WorkerRestart, WorkerTerminate, WorkerObserveCompletion, TeamCreate, TeamDelete, CronCreate, CronDelete, CronList, LSP, ListMcpResources, ReadMcpResource, McpAuth, RemoteTrigger, MCP, TestingPermission)","kind":"unknown"}`. The `status` subcommand was consumed as the `--allowedTools` value because the flag parser doesn't distinguish missing-value from end-of-flag-args. The error reveals **the supported tool list mixes naming conventions inconsistently within a single error message**: snake_case (`bash`, `read_file`, `write_file`, `edit_file`, `glob_search`, `grep_search`), PascalCase (`WebFetch`, `WebSearch`, `TodoWrite`, `Skill`, `Agent`, `Sleep`, `Config`, `PowerShell`, `AskUserQuestion`, `TaskCreate`, `WorkerCreate`, `TeamCreate`, `CronCreate`), UPPERCASE (`REPL`, `LSP`, `MCP`), and CamelCase compounds (`McpAuth`, `RemoteTrigger`). **Hidden alias mapping**: `claw --allowedTools Read,Write,Edit status --output-format json` is accepted and returns `allowed_tools.entries:["edit_file","read_file","write_file"]` — proving the validator has an undocumented CamelCase→snake_case alias map (`Read`→`read_file`, `Write`→`write_file`, `Edit`→`edit_file`) that is not surfaced in the error message. Users who copy-paste tool names from Claude Code documentation work, users who copy from the validator error don't. **Sibling missing-value bug:** `claw --allowedTools status` with `status` as a positional subcommand is interpreted as `--allowedTools=status`, swallowing the subcommand. The flag parser must require a value for `--allowedTools` and emit `kind:"missing_argument"` when followed by a recognized subcommand or `--`-prefixed flag instead of silently treating the next arg as a tool name. **Sibling typed-kind bug:** both errors use `kind:"unknown"` instead of typed `kind:"invalid_tool_name"` / `kind:"missing_argument"` — the catch-all keeps appearing (#422/#423/#424/#428/#430/#431/#432). **Required fix shape:** (a) standardize the canonical tool-name registry on one casing convention (snake_case is most CLI-ergonomic) and update both the registry and all CamelCase aliases; (b) document and expose the alias map (`tool_aliases:{Read:"read_file",...}`) in `claw doctor`/`status` and in the validator error; (c) flag parser must require a value for `--allowedTools` and refuse to consume a recognized subcommand or `-`/`--`-prefixed token as the value, emit `kind:"missing_argument"` with `argument:"--allowedTools"`; (d) emit `kind:"invalid_tool_name"` with `tool_name:` and `available:[]` fields instead of `kind:"unknown"`; (e) regression test that `claw --allowedTools <subcommand>` rejects with `missing_argument`, and that the canonical name list in errors uses the same casing as the alias map. **Why this matters:** `--allowedTools` is the primary surface for restricting claw's tool surface area (security-relevant). Inconsistent naming between the validator error and the alias map means users following the error message guidance pick names that work in some places and fail in others. The missing-value bug silently swallows a subcommand, leading to confusing "unsupported tool: status" errors when the user actually wanted to run `claw status`. Cross-references #94/#97/#101/#106/#115/#123 (permission-rule audit), #428 (default permission_mode), #422/#423/#424/#428/#430/#431 (`kind:"unknown"` catch-all). Source: Jobdori live dogfood, `fad53e2d`, 2026-05-11.
|
||||||
@@ -7756,7 +7755,7 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed)
|
|||||||
|
|
||||||
794. **`claw plugins install /nonexistent/path` returned `error_kind:"unknown"` + `hint:null`** — dogfooded 2026-05-27 on `57a57ef7`. The error message `"plugin source '/path' was not found"` had no classifier arm, falling to `"unknown"`. Fix: added `plugin_source_not_found` classifier arm (`message.contains("plugin source") && message.contains("was not found")`); added `"plugin_source_not_found"` → `"Check that the path or URL is correct..."` to `fallback_hint_for_error_kind`. Unit test assertion added to `test_classify_error_kind`; integration test `plugins_install_not_found_path_returns_typed_kind_794` added. 56 CLI contract tests pass. [SCOPE: claw-code] Source: Jobdori plugins install probe on `57a57ef7`, 2026-05-27.
|
794. **`claw plugins install /nonexistent/path` returned `error_kind:"unknown"` + `hint:null`** — dogfooded 2026-05-27 on `57a57ef7`. The error message `"plugin source '/path' was not found"` had no classifier arm, falling to `"unknown"`. Fix: added `plugin_source_not_found` classifier arm (`message.contains("plugin source") && message.contains("was not found")`); added `"plugin_source_not_found"` → `"Check that the path or URL is correct..."` to `fallback_hint_for_error_kind`. Unit test assertion added to `test_classify_error_kind`; integration test `plugins_install_not_found_path_returns_typed_kind_794` added. 56 CLI contract tests pass. [SCOPE: claw-code] Source: Jobdori plugins install probe on `57a57ef7`, 2026-05-27.
|
||||||
|
|
||||||
795. **`claw skills install /nonexistent` returned `skill_not_found + hint:null` and `claw skills uninstall x` returned `unsupported_skills_action + hint:null`** — dogfooded 2026-05-27 on `491f179a`. Both error kinds were missing from `fallback_hint_for_error_kind` table, so even though classify returned a typed kind, the hint field was always null. Fix: added `"skill_not_found"` → hint suggesting `claw skills list` / `claw skills install`; added `"unsupported_skills_action"` → hint listing supported actions. Integration test `skills_install_not_found_and_unsupported_action_have_hints_795` covers both paths. 57 CLI contract tests pass. [SCOPE: claw-code] Source: Jobdori skills lifecycle probe on `491f179a`, 2026-05-27.
|
795. **`claw skills install /nonexistent` returned `skill_not_found + hint:null` and `claw skills uninstall x` returned `unsupported_skills_action + hint:null`** — dogfooded 2026-05-27 on `491f179a`. Both error kinds were missing from `fallback_hint_for_error_kind` table, so even though classify returned a typed kind, the hint field was always null. Fix: added `skill_not_found` and `unsupported_skills_action` fallback hints. ROADMAP #431 later moved the lifecycle surface fully local: install failures now emit typed `invalid_install_source`, uninstall failures emit local `skill_not_found` with `skills_dir` and `available_names`, and the combined regression is covered by `skills_lifecycle_errors_have_typed_local_json_795_431` plus the install/uninstall roundtrip test. [SCOPE: claw-code] Source: Jobdori skills lifecycle probe on `491f179a`, 2026-05-27.
|
||||||
|
|
||||||
796. **`claw agents show <name> <extra>` and `claw skills show <name> <extra>` returned confusing `agent_not_found`/`skill_not_found` for the concatenated "name extra" string** — dogfooded 2026-05-27 on `18b4cee5`. `join_optional_args` passes all tokens as a space-joined string; both `show` handlers called `split_once(' ')` to extract the name but did not check if the remainder (after the first split) contained additional tokens. Extra positional args (including `--flags`) became part of the "name", silently mangling the lookup. Fix: added second `split_once(' ')` on the extracted name; if the result has two parts, return `unexpected_extra_args` with a usage hint. Valid single-name lookups are unaffected. Two new integration tests `agents_show_extra_positional_arg_returns_unexpected_extra_796`, `skills_show_extra_positional_arg_returns_unexpected_extra_796`. 59 CLI contract tests pass. [SCOPE: claw-code] Source: Jobdori agents/skills show extra-arg probe on `18b4cee5`, 2026-05-27.
|
796. **`claw agents show <name> <extra>` and `claw skills show <name> <extra>` returned confusing `agent_not_found`/`skill_not_found` for the concatenated "name extra" string** — dogfooded 2026-05-27 on `18b4cee5`. `join_optional_args` passes all tokens as a space-joined string; both `show` handlers called `split_once(' ')` to extract the name but did not check if the remainder (after the first split) contained additional tokens. Extra positional args (including `--flags`) became part of the "name", silently mangling the lookup. Fix: added second `split_once(' ')` on the extracted name; if the result has two parts, return `unexpected_extra_args` with a usage hint. Valid single-name lookups are unaffected. Two new integration tests `agents_show_extra_positional_arg_returns_unexpected_extra_796`, `skills_show_extra_positional_arg_returns_unexpected_extra_796`. 59 CLI contract tests pass. [SCOPE: claw-code] Source: Jobdori agents/skills show extra-arg probe on `18b4cee5`, 2026-05-27.
|
||||||
797. **DONE — Installed `claw version --output-format json` reports `git_sha:null` / `Git SHA unknown`, so dogfood cannot tie the binary under test to a source revision** — dogfooded 2026-05-27 from `#clawcode-building-in-public` using an installed binary in a clean `ultraworkers/claw-code` checkout. The gap was that version/status/doctor did not provide a structured executable-vs-workspace provenance object when build metadata was missing or stale. [SCOPE: claw-code]
|
797. **DONE — Installed `claw version --output-format json` reports `git_sha:null` / `Git SHA unknown`, so dogfood cannot tie the binary under test to a source revision** — dogfooded 2026-05-27 from `#clawcode-building-in-public` using an installed binary in a clean `ultraworkers/claw-code` checkout. The gap was that version/status/doctor did not provide a structured executable-vs-workspace provenance object when build metadata was missing or stale. [SCOPE: claw-code]
|
||||||
|
|||||||
83
USAGE.md
83
USAGE.md
@@ -86,6 +86,12 @@ cd rust
|
|||||||
./target/debug/claw prompt "summarize this repository"
|
./target/debug/claw prompt "summarize this repository"
|
||||||
```
|
```
|
||||||
|
|
||||||
|
Pipe prompt text through stdin when automation already produces the prompt body:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
printf 'summarize this repository\n' | ./target/debug/claw prompt --output-format json
|
||||||
|
```
|
||||||
|
|
||||||
### Shorthand prompt mode
|
### Shorthand prompt mode
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
@@ -187,17 +193,20 @@ cd rust
|
|||||||
./target/debug/claw --permission-mode read-only prompt "summarize Cargo.toml"
|
./target/debug/claw --permission-mode read-only prompt "summarize Cargo.toml"
|
||||||
./target/debug/claw --permission-mode workspace-write prompt "update README.md"
|
./target/debug/claw --permission-mode workspace-write prompt "update README.md"
|
||||||
./target/debug/claw --allowedTools read,glob "inspect the runtime crate"
|
./target/debug/claw --allowedTools read,glob "inspect the runtime crate"
|
||||||
|
./target/debug/claw --cwd ../other-workspace status --output-format json
|
||||||
```
|
```
|
||||||
|
|
||||||
Supported permission modes:
|
Global workspace override flags: `--cwd PATH`, `-C PATH`, and `--directory PATH` are accepted before any subcommand. They are validated before command dispatch and take precedence over the process `$PWD`; invalid paths return typed `invalid_cwd` JSON errors in JSON mode.
|
||||||
|
|
||||||
- `read-only`
|
Supported permission modes (default: `workspace-write`):
|
||||||
- `workspace-write`
|
|
||||||
- `danger-full-access`
|
- `read-only` allows inspection-only local tools such as file reads, glob/grep searches, local skills, and status-style reporting. It does not allow workspace mutation, network-fetch/search tools, or arbitrary command execution.
|
||||||
|
- `workspace-write` is the safe default. It allows reads plus direct file-editing tools inside the current workspace, including write/edit/notebook/config/plan-mode updates, while still gating network-fetch/search tools, arbitrary shell execution, subagent launches, REPL subprocesses, and other full-access tools behind an explicit escalation.
|
||||||
|
- `danger-full-access` allows every registered tool requirement, including arbitrary command execution, web fetch/search, subagent launches, subprocess REPLs, and unrestricted tool access. Select it only with an explicit `--permission-mode danger-full-access`, `--dangerously-skip-permissions`, `--skip-permissions`, env, or config opt-in.
|
||||||
|
|
||||||
Model aliases currently supported by the CLI:
|
Model aliases currently supported by the CLI:
|
||||||
|
|
||||||
- `opus` → `claude-opus-4-6`
|
- `opus` → `claude-opus-4-7`
|
||||||
- `sonnet` → `claude-sonnet-4-6`
|
- `sonnet` → `claude-sonnet-4-6`
|
||||||
- `haiku` → `claude-haiku-4-5-20251213`
|
- `haiku` → `claude-haiku-4-5-20251213`
|
||||||
|
|
||||||
@@ -292,6 +301,18 @@ cd rust
|
|||||||
./target/debug/claw --model "llama3.2" prompt "summarize this repository in one sentence"
|
./target/debug/claw --model "llama3.2" prompt "summarize this repository in one sentence"
|
||||||
```
|
```
|
||||||
|
|
||||||
|
For Ollama tags with punctuation (for example `qwen2.5-coder:7b`), `OPENAI_BASE_URL` selects the local OpenAI-compatible route even when `OPENAI_API_KEY` is unset:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
export OPENAI_BASE_URL="http://127.0.0.1:11434/v1"
|
||||||
|
unset OPENAI_API_KEY
|
||||||
|
|
||||||
|
cd rust
|
||||||
|
./target/debug/claw --model "qwen2.5-coder:7b" prompt "reply with ready"
|
||||||
|
```
|
||||||
|
|
||||||
|
If the local server exposes a slash-containing model ID, prefix it with `local/` so Claw selects the OpenAI-compatible transport while sending the remainder verbatim on the wire: `--model "local/Qwen/Qwen3.6-27B-FP8"`.
|
||||||
|
|
||||||
### OpenRouter
|
### OpenRouter
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
@@ -334,7 +355,7 @@ Reasoning variants (`qwen-qwq-*`, `qwq-*`, `*-thinking`) automatically strip `te
|
|||||||
|
|
||||||
The OpenAI-compatible backend also serves as the gateway for **OpenRouter**, **Ollama**, and any other service that speaks the OpenAI `/v1/chat/completions` wire format — just point `OPENAI_BASE_URL` at the service.
|
The OpenAI-compatible backend also serves as the gateway for **OpenRouter**, **Ollama**, and any other service that speaks the OpenAI `/v1/chat/completions` wire format — just point `OPENAI_BASE_URL` at the service.
|
||||||
|
|
||||||
**Model-name prefix routing:** If a model name starts with `openai/`, `gpt-`, `qwen/`, `qwen-`, `kimi/`, or `kimi-`, the provider is selected by the prefix regardless of which env vars are set. This prevents accidental misrouting to Anthropic when multiple credentials exist in the environment. For the default OpenAI API, `openai/` is a routing prefix and is stripped before the request hits the wire. For a custom `OPENAI_BASE_URL`, slash-containing OpenAI-compatible slugs (for example OpenRouter-style `openai/gpt-4.1-mini`) are preserved so the gateway receives the model ID it expects.
|
**Model-name prefix routing:** If a model name starts with `openai/`, `local/`, `gpt-`, `qwen/`, `qwen-`, `kimi/`, or `kimi-`, the provider is selected by the prefix regardless of which env vars are set. This prevents accidental misrouting to Anthropic when multiple credentials exist in the environment. For the default OpenAI API and local/private OpenAI-compatible endpoints, `openai/` is a routing prefix and is stripped before the request hits the wire. For non-local custom `OPENAI_BASE_URL` gateways, slash-containing OpenAI-compatible slugs (for example OpenRouter-style `openai/gpt-4.1-mini`) are preserved so the gateway receives the model ID it expects. The `local/` prefix is an explicit escape hatch for local slash-containing model IDs: it is stripped while the rest of the model ID is sent verbatim.
|
||||||
|
|
||||||
### Tested models and aliases
|
### Tested models and aliases
|
||||||
|
|
||||||
@@ -342,7 +363,7 @@ These are the models registered in the built-in alias table with known token lim
|
|||||||
|
|
||||||
| Alias | Resolved model name | Provider | Max output tokens | Context window |
|
| Alias | Resolved model name | Provider | Max output tokens | Context window |
|
||||||
|---|---|---|---|---|
|
|---|---|---|---|---|
|
||||||
| `opus` | `claude-opus-4-6` | Anthropic | 32 000 | 200 000 |
|
| `opus` | `claude-opus-4-7` | Anthropic | 32 000 | 200 000 |
|
||||||
| `sonnet` | `claude-sonnet-4-6` | Anthropic | 64 000 | 200 000 |
|
| `sonnet` | `claude-sonnet-4-6` | Anthropic | 64 000 | 200 000 |
|
||||||
| `haiku` | `claude-haiku-4-5-20251213` | Anthropic | 64 000 | 200 000 |
|
| `haiku` | `claude-haiku-4-5-20251213` | Anthropic | 64 000 | 200 000 |
|
||||||
| `grok` / `grok-3` | `grok-3` | xAI | 64 000 | 131 072 |
|
| `grok` / `grok-3` | `grok-3` | xAI | 64 000 | 131 072 |
|
||||||
@@ -354,7 +375,7 @@ These are the models registered in the built-in alias table with known token lim
|
|||||||
| `gpt-4.1` / `gpt-4.1-mini` / `gpt-4.1-nano` | same | OpenAI-compatible | 32 768 | 1 047 576 |
|
| `gpt-4.1` / `gpt-4.1-mini` / `gpt-4.1-nano` | same | OpenAI-compatible | 32 768 | 1 047 576 |
|
||||||
| `gpt-5.4` / `gpt-5.4-mini` / `gpt-5.4-nano` | same | OpenAI-compatible | 128 000 | 1 000 000 / 400 000 |
|
| `gpt-5.4` / `gpt-5.4-mini` / `gpt-5.4-nano` | same | OpenAI-compatible | 128 000 | 1 000 000 / 400 000 |
|
||||||
|
|
||||||
Any model name that does not match an alias is passed through verbatim after provider routing is resolved. This is how you use OpenRouter model slugs (`openai/gpt-4.1-mini` with a custom `OPENAI_BASE_URL`), Ollama tags (`llama3.2`), or full Anthropic model IDs (`claude-sonnet-4-20250514`).
|
Any model name that does not match an alias is passed through verbatim after provider routing is resolved. This is how you use OpenRouter model slugs (`openai/gpt-4.1-mini` with a custom `OPENAI_BASE_URL`), Ollama tags (`llama3.2` or `qwen2.5-coder:7b`), slash-containing local IDs (`local/Qwen/Qwen3.6-27B-FP8`), or full Anthropic model IDs (`claude-sonnet-4-20250514`).
|
||||||
|
|
||||||
### User-defined aliases
|
### User-defined aliases
|
||||||
|
|
||||||
@@ -364,7 +385,7 @@ You can add custom aliases in any settings file (`~/.claw/settings.json`, `.claw
|
|||||||
{
|
{
|
||||||
"aliases": {
|
"aliases": {
|
||||||
"fast": "claude-haiku-4-5-20251213",
|
"fast": "claude-haiku-4-5-20251213",
|
||||||
"smart": "claude-opus-4-6",
|
"smart": "claude-opus-4-7",
|
||||||
"cheap": "grok-3-mini"
|
"cheap": "grok-3-mini"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -372,13 +393,15 @@ You can add custom aliases in any settings file (`~/.claw/settings.json`, `.claw
|
|||||||
|
|
||||||
Local project settings override user-level settings. Aliases resolve through the built-in table, so `"fast": "haiku"` also works.
|
Local project settings override user-level settings. Aliases resolve through the built-in table, so `"fast": "haiku"` also works.
|
||||||
|
|
||||||
|
Model selection precedence is CLI flag, environment, config, then default. The environment model slot accepts `CLAW_MODEL`, `ANTHROPIC_MODEL`, and `ANTHROPIC_DEFAULT_MODEL` in that order; aliases from those variables are resolved and validated before provider startup. `claw --output-format json status` exposes `model_raw`, `model_alias_resolved_to`, and `model_env_var` so automation can see the winning value.
|
||||||
|
|
||||||
### How provider detection works
|
### How provider detection works
|
||||||
|
|
||||||
1. If the resolved model name starts with `claude` → Anthropic.
|
1. If the resolved model name starts with `claude` → Anthropic.
|
||||||
2. If it starts with `grok` → xAI.
|
2. If it starts with `grok` → xAI.
|
||||||
3. If it starts with `openai/` or `gpt-` → OpenAI-compatible.
|
3. If it starts with `openai/`, `local/`, or `gpt-` → OpenAI-compatible.
|
||||||
4. If it starts with `qwen/`, `qwen-`, `kimi/`, or `kimi-` → DashScope-compatible OpenAI wire format.
|
4. If it starts with `qwen/`, `qwen-`, `kimi/`, or `kimi-` → DashScope-compatible OpenAI wire format.
|
||||||
5. If `OPENAI_BASE_URL` and `OPENAI_API_KEY` are set, unknown model names route to the OpenAI-compatible client for local/gateway servers.
|
5. If `OPENAI_BASE_URL` is set, local-looking unknown model names such as `llama3.2` or `qwen2.5-coder:7b` route to the OpenAI-compatible client for local/gateway servers.
|
||||||
6. Otherwise, `claw` checks which credential is set: Anthropic first, then OpenAI, then xAI. If only `OPENAI_BASE_URL` is set, it still routes to OpenAI-compatible for authless local servers.
|
6. Otherwise, `claw` checks which credential is set: Anthropic first, then OpenAI, then xAI. If only `OPENAI_BASE_URL` is set, it still routes to OpenAI-compatible for authless local servers.
|
||||||
7. If nothing matches, it defaults to Anthropic.
|
7. If nothing matches, it defaults to Anthropic.
|
||||||
|
|
||||||
@@ -454,11 +477,12 @@ let client = build_http_client_with(&config).expect("proxy client");
|
|||||||
|
|
||||||
## Skills
|
## Skills
|
||||||
|
|
||||||
Use `/skills list` in the interactive REPL or `claw skills --output-format json` from the direct CLI to inspect installed skills. For offline/local installs, install the directory that contains `SKILL.md`, then verify the discovered name before invoking it:
|
Use `/skills list` in the interactive REPL or `claw skills --output-format json` from the direct CLI to inspect installed skills. For offline/local installs, install the directory that contains `SKILL.md`, then verify the discovered name before invoking it. `skills install`, `skills uninstall`, and `agents create` are local filesystem lifecycle commands; they do not require provider credentials.
|
||||||
|
|
||||||
```text
|
```text
|
||||||
/skills install /absolute/path/to/my-skill
|
/skills install /absolute/path/to/my-skill
|
||||||
/skills list
|
/skills list
|
||||||
|
/skills uninstall my-skill
|
||||||
/skills my-skill
|
/skills my-skill
|
||||||
```
|
```
|
||||||
|
|
||||||
@@ -471,6 +495,7 @@ cd rust
|
|||||||
./target/debug/claw status
|
./target/debug/claw status
|
||||||
./target/debug/claw sandbox
|
./target/debug/claw sandbox
|
||||||
./target/debug/claw agents
|
./target/debug/claw agents
|
||||||
|
./target/debug/claw agents create my-agent
|
||||||
./target/debug/claw mcp
|
./target/debug/claw mcp
|
||||||
./target/debug/claw skills
|
./target/debug/claw skills
|
||||||
./target/debug/claw system-prompt --cwd .. --date 2026-04-04
|
./target/debug/claw system-prompt --cwd .. --date 2026-04-04
|
||||||
@@ -490,6 +515,7 @@ git clone https://github.com/Xquik-dev/tweetclaw
|
|||||||
cd claw-code/rust
|
cd claw-code/rust
|
||||||
./target/debug/claw skills install ../../tweetclaw/skills/tweetclaw
|
./target/debug/claw skills install ../../tweetclaw/skills/tweetclaw
|
||||||
./target/debug/claw skills show tweetclaw
|
./target/debug/claw skills show tweetclaw
|
||||||
|
./target/debug/claw skills uninstall tweetclaw
|
||||||
```
|
```
|
||||||
|
|
||||||
TweetClaw gives `claw` users a local skill guide for OpenClaw/Xquik workflows
|
TweetClaw gives `claw` users a local skill guide for OpenClaw/Xquik workflows
|
||||||
@@ -497,6 +523,15 @@ such as tweet search, reply search, follower export, monitors, webhooks, and
|
|||||||
approval-gated posting. Configure any Xquik credentials outside the prompt and
|
approval-gated posting. Configure any Xquik credentials outside the prompt and
|
||||||
avoid pasting API keys into chat.
|
avoid pasting API keys into chat.
|
||||||
|
|
||||||
|
## Author a local agent
|
||||||
|
|
||||||
|
`claw agents create <name>` scaffolds a local `.claw/agents/<name>.toml` file for the current workspace. The scaffold is intentionally small so you can edit the description, model, and reasoning effort before listing or invoking agents:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
./target/debug/claw agents create release-checker
|
||||||
|
./target/debug/claw agents list
|
||||||
|
```
|
||||||
|
|
||||||
## Session management
|
## Session management
|
||||||
|
|
||||||
REPL turns are persisted under `.claw/sessions/` in the current workspace.
|
REPL turns are persisted under `.claw/sessions/` in the current workspace.
|
||||||
@@ -519,6 +554,30 @@ Runtime config is loaded in this order, with later entries overriding earlier on
|
|||||||
4. `<repo>/.claw/settings.json`
|
4. `<repo>/.claw/settings.json`
|
||||||
5. `<repo>/.claw/settings.local.json`
|
5. `<repo>/.claw/settings.local.json`
|
||||||
|
|
||||||
|
The list is also the precedence chain: project-local settings override project settings, project settings override the legacy project `.claw.json`, and project files override user files. `claw --output-format json config` includes each discovered file's `precedence_rank`, `wins_for_keys`, and `shadowed_keys` so automation can see which file controls each effective key without reimplementing the merge order.
|
||||||
|
|
||||||
|
## Hook configuration
|
||||||
|
|
||||||
|
`hooks.PreToolUse`, `hooks.PostToolUse`, and `hooks.PostToolUseFailure` accept either legacy command strings or object-style entries with a `matcher` and nested command hooks:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"hooks": {
|
||||||
|
"PreToolUse": [
|
||||||
|
"echo legacy hook",
|
||||||
|
{
|
||||||
|
"matcher": "Bash",
|
||||||
|
"hooks": [
|
||||||
|
{ "type": "command", "command": "scripts/audit-bash.sh" }
|
||||||
|
]
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Object-style matchers are optional. When present, they match tool names case-insensitively and support `*` wildcards plus comma or pipe separated alternatives. Nested hook `type` may be omitted or set to `"command"`; each nested command runs in configuration order.
|
||||||
|
|
||||||
## Project instruction rules
|
## Project instruction rules
|
||||||
|
|
||||||
In addition to root instruction files such as `CLAUDE.md`, `AGENTS.md`, `.claw/CLAUDE.md`, `.claude/CLAUDE.md`, and `.claw/instructions.md`, `claw` loads sorted Markdown/text rule files from:
|
In addition to root instruction files such as `CLAUDE.md`, `AGENTS.md`, `.claw/CLAUDE.md`, `.claude/CLAUDE.md`, and `.claw/instructions.md`, `claw` loads sorted Markdown/text rule files from:
|
||||||
|
|||||||
@@ -148,12 +148,12 @@ pub const DEFAULT_DASHSCOPE_BASE_URL: &str = "https://dashscope.aliyuncs.com/com
|
|||||||
**Affected models:** Slash-containing model IDs routed through the OpenAI-compatible provider, especially custom gateways configured with `OPENAI_BASE_URL` such as OpenRouter, local routers, or other `/v1/chat/completions` services.
|
**Affected models:** Slash-containing model IDs routed through the OpenAI-compatible provider, especially custom gateways configured with `OPENAI_BASE_URL` such as OpenRouter, local routers, or other `/v1/chat/completions` services.
|
||||||
|
|
||||||
**Behavior:**
|
**Behavior:**
|
||||||
- The default OpenAI API treats `openai/` as a routing prefix and sends the bare model name on the wire.
|
- The default OpenAI API and local/private OpenAI-compatible base URLs treat `openai/` as a routing prefix and send the bare model name on the wire.
|
||||||
- Custom OpenAI-compatible base URLs preserve slash-containing slugs such as `openai/gpt-4.1-mini` so the gateway receives the exact model ID it expects.
|
- Non-local custom OpenAI-compatible base URLs preserve slash-containing slugs such as `openai/gpt-4.1-mini` so gateways like OpenRouter receive the exact model ID they expect. Local slash-containing model IDs can use `local/`, which strips only that escape-hatch prefix and sends the remainder verbatim.
|
||||||
- `MessageRequest::extra_body` passes through custom request JSON after core fields are populated. This supports provider-specific options such as `web_search_options` and `parallel_tool_calls`.
|
- `MessageRequest::extra_body` passes through custom request JSON after core fields are populated. This supports provider-specific options such as `web_search_options` and `parallel_tool_calls`.
|
||||||
- Protected core fields (`model`, `messages`, `stream`, `tools`, `tool_choice`, `max_tokens`, `max_completion_tokens`) cannot be overridden through `extra_body`.
|
- Protected core fields (`model`, `messages`, `stream`, `tools`, `tool_choice`, `max_tokens`, `max_completion_tokens`) cannot be overridden through `extra_body`.
|
||||||
|
|
||||||
**Testing:** See `custom_openai_gateway_preserves_slash_model_ids_and_extra_body_params` in `openai_compat_integration.rs` and `extra_body_params_are_passed_through_without_overriding_core_fields` in `openai_compat.rs`.
|
**Testing:** See `custom_openai_gateway_preserves_slash_model_ids_and_extra_body_params` in `openai_compat_integration.rs`, `wire_model_strips_openai_prefix_for_default_and_local_preserves_custom_gateways`, `local_routing_prefix_strips_only_escape_hatch`, and `extra_body_params_are_passed_through_without_overriding_core_fields` in `openai_compat.rs`.
|
||||||
|
|
||||||
## Implementation Details
|
## Implementation Details
|
||||||
|
|
||||||
|
|||||||
@@ -13,7 +13,7 @@ If you need the most polished daily-driver experience for a specific non-Claude
|
|||||||
|
|
||||||
## OpenAI-compatible routing basics
|
## OpenAI-compatible routing basics
|
||||||
|
|
||||||
Set `OPENAI_BASE_URL` to the server’s `/v1` endpoint and set `OPENAI_API_KEY` to either the required token or a harmless placeholder for local servers that expect an Authorization header. The model name must match what the server exposes.
|
Set `OPENAI_BASE_URL` to the server’s `/v1` endpoint and set `OPENAI_API_KEY` to either the required token or a harmless placeholder for local servers that expect an Authorization header. Authless local/private OpenAI-compatible servers can leave `OPENAI_API_KEY` unset. The model name must match what the server exposes.
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
export OPENAI_BASE_URL="http://127.0.0.1:11434/v1"
|
export OPENAI_BASE_URL="http://127.0.0.1:11434/v1"
|
||||||
@@ -24,8 +24,8 @@ claw --model "qwen3:latest" prompt "Reply exactly HELLO_WORLD_123"
|
|||||||
Routing notes:
|
Routing notes:
|
||||||
|
|
||||||
- Use the `openai/` prefix for OpenAI-compatible gateways when you need prefix routing to win over ambient Anthropic credentials, for example `--model "openai/gpt-4.1-mini"` with OpenRouter.
|
- Use the `openai/` prefix for OpenAI-compatible gateways when you need prefix routing to win over ambient Anthropic credentials, for example `--model "openai/gpt-4.1-mini"` with OpenRouter.
|
||||||
- For local servers, prefer the exact model ID reported by the server (`qwen3:latest`, `llama3.2`, `Qwen/Qwen2.5-Coder-7B-Instruct`, etc.). If your local gateway exposes slash-containing IDs, use that exact slug.
|
- For local servers, prefer the exact model ID reported by the server (`qwen3:latest`, `llama3.2`, etc.). If your local gateway exposes slash-containing IDs, prefix the exact slug with `local/` so Claw routes through OpenAI-compatible transport while sending the rest verbatim, for example `--model "local/Qwen/Qwen2.5-Coder-7B-Instruct"`.
|
||||||
- If you have multiple provider keys in your environment, remove unrelated keys while smoke-testing a local route or choose a model prefix that unambiguously selects the intended provider.
|
- If you have multiple provider keys in your environment, `OPENAI_BASE_URL` plus local-looking tags such as `llama3.2` or `qwen2.5-coder:7b` selects the local OpenAI-compatible route; use `local/` for slash-containing local IDs.
|
||||||
- Tool workflows need model/server support for OpenAI-compatible tool calls. Plain prompt smoke tests can pass even when slash/tool workflows still fail because the server returns an incompatible tool-call shape.
|
- Tool workflows need model/server support for OpenAI-compatible tool calls. Plain prompt smoke tests can pass even when slash/tool workflows still fail because the server returns an incompatible tool-call shape.
|
||||||
|
|
||||||
## Raw `/v1/chat/completions` smoke test
|
## Raw `/v1/chat/completions` smoke test
|
||||||
@@ -58,11 +58,11 @@ In another shell:
|
|||||||
|
|
||||||
```bash
|
```bash
|
||||||
export OPENAI_BASE_URL="http://127.0.0.1:11434/v1"
|
export OPENAI_BASE_URL="http://127.0.0.1:11434/v1"
|
||||||
export OPENAI_API_KEY="local-dev-token"
|
unset OPENAI_API_KEY
|
||||||
claw --model "qwen3:latest" prompt "Reply exactly HELLO_WORLD_123"
|
claw --model "qwen3:latest" prompt "Reply exactly HELLO_WORLD_123"
|
||||||
```
|
```
|
||||||
|
|
||||||
If Ollama is running without auth and your build accepts authless local OpenAI-compatible servers, `unset OPENAI_API_KEY` is also acceptable. Use a placeholder token rather than a real cloud API key for local testing.
|
If Ollama is running without auth, `unset OPENAI_API_KEY` is acceptable. Use a placeholder token rather than a real cloud API key if your local server requires an Authorization header.
|
||||||
|
|
||||||
## llama.cpp server
|
## llama.cpp server
|
||||||
|
|
||||||
|
|||||||
1
rust/Cargo.lock
generated
1
rust/Cargo.lock
generated
@@ -2244,7 +2244,6 @@ version = "0.1.3"
|
|||||||
dependencies = [
|
dependencies = [
|
||||||
"api",
|
"api",
|
||||||
"commands",
|
"commands",
|
||||||
"compat-harness",
|
|
||||||
"crossterm",
|
"crossterm",
|
||||||
"log",
|
"log",
|
||||||
"mock-anthropic-service",
|
"mock-anthropic-service",
|
||||||
|
|||||||
@@ -15,7 +15,7 @@ cargo run -p rusty-claude-cli -- --help
|
|||||||
cargo build --workspace
|
cargo build --workspace
|
||||||
|
|
||||||
# Run the interactive REPL
|
# Run the interactive REPL
|
||||||
cargo run -p rusty-claude-cli -- --model claude-opus-4-6
|
cargo run -p rusty-claude-cli -- --model claude-opus-4-7
|
||||||
|
|
||||||
# One-shot prompt
|
# One-shot prompt
|
||||||
cargo run -p rusty-claude-cli -- prompt "explain this codebase"
|
cargo run -p rusty-claude-cli -- prompt "explain this codebase"
|
||||||
@@ -100,7 +100,7 @@ Primary artifacts:
|
|||||||
| Slash commands (including `/skills`, `/agents`, `/mcp`, `/doctor`, `/plugin`, `/subagent`) | ✅ |
|
| Slash commands (including `/skills`, `/agents`, `/mcp`, `/doctor`, `/plugin`, `/subagent`) | ✅ |
|
||||||
| Hooks (`/hooks`, config-backed lifecycle hooks) | ✅ |
|
| Hooks (`/hooks`, config-backed lifecycle hooks) | ✅ |
|
||||||
| Plugin management surfaces | ✅ |
|
| Plugin management surfaces | ✅ |
|
||||||
| Skills inventory / install surfaces | ✅ |
|
| Skills inventory / install / uninstall surfaces | ✅ |
|
||||||
| Machine-readable JSON output across core CLI surfaces | ✅ |
|
| Machine-readable JSON output across core CLI surfaces | ✅ |
|
||||||
|
|
||||||
## Model Aliases
|
## Model Aliases
|
||||||
@@ -109,7 +109,7 @@ Short names resolve to the latest model versions:
|
|||||||
|
|
||||||
| Alias | Resolves To |
|
| Alias | Resolves To |
|
||||||
|-------|------------|
|
|-------|------------|
|
||||||
| `opus` | `claude-opus-4-6` |
|
| `opus` | `claude-opus-4-7` |
|
||||||
| `sonnet` | `claude-sonnet-4-6` |
|
| `sonnet` | `claude-sonnet-4-6` |
|
||||||
| `haiku` | `claude-haiku-4-5-20251213` |
|
| `haiku` | `claude-haiku-4-5-20251213` |
|
||||||
|
|
||||||
@@ -124,7 +124,8 @@ Flags:
|
|||||||
--model MODEL
|
--model MODEL
|
||||||
--output-format text|json
|
--output-format text|json
|
||||||
--permission-mode MODE
|
--permission-mode MODE
|
||||||
--dangerously-skip-permissions
|
--cwd PATH, -C PATH, --directory PATH
|
||||||
|
--dangerously-skip-permissions, --skip-permissions
|
||||||
--allowedTools TOOLS
|
--allowedTools TOOLS
|
||||||
--resume [SESSION.jsonl|session-id|latest]
|
--resume [SESSION.jsonl|session-id|latest]
|
||||||
--version, -V
|
--version, -V
|
||||||
@@ -146,6 +147,7 @@ Top-level commands:
|
|||||||
```
|
```
|
||||||
|
|
||||||
`claw acp` is a local discoverability surface for editor-first users: it reports the current ACP/Zed status without starting the runtime. As of April 16, 2026, claw-code does **not** ship an ACP/Zed daemon or JSON-RPC entrypoint yet, and `claw acp serve` is only a status alias until the real protocol surface lands. Status queries exit 0 and expose the same machine-readable contract via `--output-format json`; malformed ACP invocations exit 1 with `kind: unsupported_acp_invocation`.
|
`claw acp` is a local discoverability surface for editor-first users: it reports the current ACP/Zed status without starting the runtime. As of April 16, 2026, claw-code does **not** ship an ACP/Zed daemon or JSON-RPC entrypoint yet, and `claw acp serve` is only a status alias until the real protocol surface lands. Status queries exit 0 and expose the same machine-readable contract via `--output-format json`; malformed ACP invocations exit 1 with `kind: unsupported_acp_invocation`.
|
||||||
|
`claw dump-manifests` is self-contained: it emits the Rust resolver inventory for the selected workspace (commands, tools, agents, skills, and bootstrap phases) without requiring an upstream Claude Code TypeScript checkout. Use `--manifests-dir PATH` only to scope resolver discovery to another directory.
|
||||||
|
|
||||||
The command surface is moving quickly. For the canonical live help text, run:
|
The command surface is moving quickly. For the canonical live help text, run:
|
||||||
|
|
||||||
@@ -166,8 +168,8 @@ The REPL now exposes a much broader surface than the original minimal shell:
|
|||||||
- plugin management: `/plugin` (with aliases `/plugins`, `/marketplace`)
|
- plugin management: `/plugin` (with aliases `/plugins`, `/marketplace`)
|
||||||
|
|
||||||
Notable claw-first surfaces now available directly in slash form:
|
Notable claw-first surfaces now available directly in slash form:
|
||||||
- `/skills [list|install <path>|help]`
|
- `/skills [list|show <name>|install <path>|uninstall <name>|help]`
|
||||||
- `/agents [list|help]`
|
- `/agents [list|show <name>|create <name>|help]`
|
||||||
- `/mcp [list|show <server>|help]`
|
- `/mcp [list|show <server>|help]`
|
||||||
- `/doctor`
|
- `/doctor`
|
||||||
- `/plugin [list|install <path>|enable <name>|disable <name>|uninstall <id>|update <id>]`
|
- `/plugin [list|install <path>|enable <name>|disable <name>|uninstall <id>|update <id>]`
|
||||||
@@ -184,7 +186,7 @@ rust/
|
|||||||
└── crates/
|
└── crates/
|
||||||
├── api/ # Provider clients + streaming + request preflight
|
├── api/ # Provider clients + streaming + request preflight
|
||||||
├── commands/ # Shared slash-command registry + help rendering
|
├── commands/ # Shared slash-command registry + help rendering
|
||||||
├── compat-harness/ # TS manifest extraction harness
|
├── compat-harness/ # Compatibility/parity harness utilities
|
||||||
├── mock-anthropic-service/ # Deterministic local Anthropic-compatible mock
|
├── mock-anthropic-service/ # Deterministic local Anthropic-compatible mock
|
||||||
├── plugins/ # Plugin metadata, manager, install/enable/disable surfaces
|
├── plugins/ # Plugin metadata, manager, install/enable/disable surfaces
|
||||||
├── runtime/ # Session, config, permissions, MCP, prompts, auth/runtime loop
|
├── runtime/ # Session, config, permissions, MCP, prompts, auth/runtime loop
|
||||||
@@ -197,7 +199,7 @@ rust/
|
|||||||
|
|
||||||
- **api** — provider clients, SSE streaming, request/response types, auth (`ANTHROPIC_API_KEY` + bearer-token support), request-size/context-window preflight
|
- **api** — provider clients, SSE streaming, request/response types, auth (`ANTHROPIC_API_KEY` + bearer-token support), request-size/context-window preflight
|
||||||
- **commands** — slash command definitions, parsing, help text generation, JSON/text command rendering
|
- **commands** — slash command definitions, parsing, help text generation, JSON/text command rendering
|
||||||
- **compat-harness** — extracts tool/prompt manifests from upstream TS source
|
- **compat-harness** — compatibility and parity helpers for comparing behavior with upstream fixtures
|
||||||
- **mock-anthropic-service** — deterministic `/v1/messages` mock for CLI parity tests and local harness runs
|
- **mock-anthropic-service** — deterministic `/v1/messages` mock for CLI parity tests and local harness runs
|
||||||
- **plugins** — plugin metadata, install/enable/disable/update flows, plugin tool definitions, hook integration surfaces
|
- **plugins** — plugin metadata, install/enable/disable/update flows, plugin tool definitions, hook integration surfaces
|
||||||
- **runtime** — `ConversationRuntime`, config loading, session persistence, permission policy, MCP client lifecycle, system prompt assembly, usage tracking
|
- **runtime** — `ConversationRuntime`, config loading, session persistence, permission policy, MCP client lifecycle, system prompt assembly, usage tracking
|
||||||
@@ -210,8 +212,8 @@ rust/
|
|||||||
- **~20K lines** of Rust
|
- **~20K lines** of Rust
|
||||||
- **9 crates** in workspace
|
- **9 crates** in workspace
|
||||||
- **Binary name:** `claw`
|
- **Binary name:** `claw`
|
||||||
- **Default model:** `claude-opus-4-6`
|
- **Default model:** `claude-opus-4-7`
|
||||||
- **Default permissions:** `danger-full-access`
|
- **Default permissions:** `workspace-write`
|
||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
||||||
|
|||||||
@@ -161,7 +161,7 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn resolves_existing_and_grok_aliases() {
|
fn resolves_existing_and_grok_aliases() {
|
||||||
assert_eq!(resolve_model_alias("opus"), "claude-opus-4-6");
|
assert_eq!(resolve_model_alias("opus"), "claude-opus-4-7");
|
||||||
assert_eq!(resolve_model_alias("grok"), "grok-3");
|
assert_eq!(resolve_model_alias("grok"), "grok-3");
|
||||||
assert_eq!(resolve_model_alias("grok-mini"), "grok-3-mini");
|
assert_eq!(resolve_model_alias("grok-mini"), "grok-3-mini");
|
||||||
}
|
}
|
||||||
@@ -235,4 +235,22 @@ mod tests {
|
|||||||
other => panic!("Expected ProviderClient::OpenAi for qwen-plus, got: {other:?}"),
|
other => panic!("Expected ProviderClient::OpenAi for qwen-plus, got: {other:?}"),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn local_openai_base_url_routes_authless_ollama_models() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _base_url = EnvVarGuard::set("OPENAI_BASE_URL", Some("http://127.0.0.1:11434/v1"));
|
||||||
|
let _openai_key = EnvVarGuard::set("OPENAI_API_KEY", None);
|
||||||
|
let _anthropic_key = EnvVarGuard::set("ANTHROPIC_API_KEY", Some("test-anthropic-key"));
|
||||||
|
let _anthropic_token = EnvVarGuard::set("ANTHROPIC_AUTH_TOKEN", None);
|
||||||
|
|
||||||
|
let client = ProviderClient::from_model("qwen2.5-coder:7b")
|
||||||
|
.expect("local model should route to OpenAI-compatible client without auth");
|
||||||
|
match client {
|
||||||
|
ProviderClient::OpenAi(openai_client) => {
|
||||||
|
assert_eq!(openai_client.base_url(), "http://127.0.0.1:11434/v1")
|
||||||
|
}
|
||||||
|
other => panic!("Expected ProviderClient::OpenAi for local model, got: {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -468,8 +468,7 @@ impl AnthropicClient {
|
|||||||
request: &MessageRequest,
|
request: &MessageRequest,
|
||||||
) -> Result<reqwest::Response, ApiError> {
|
) -> Result<reqwest::Response, ApiError> {
|
||||||
let request_url = format!("{}/v1/messages", self.base_url.trim_end_matches('/'));
|
let request_url = format!("{}/v1/messages", self.base_url.trim_end_matches('/'));
|
||||||
let mut request_body = self.request_profile.render_json_body(request)?;
|
let request_body = render_standard_messages_body(&self.request_profile, request)?;
|
||||||
strip_unsupported_beta_body_fields(&mut request_body);
|
|
||||||
let request_builder = self.build_request(&request_url).json(&request_body);
|
let request_builder = self.build_request(&request_url).json(&request_body);
|
||||||
request_builder.send().await.map_err(ApiError::from)
|
request_builder.send().await.map_err(ApiError::from)
|
||||||
}
|
}
|
||||||
@@ -529,8 +528,7 @@ impl AnthropicClient {
|
|||||||
"{}/v1/messages/count_tokens",
|
"{}/v1/messages/count_tokens",
|
||||||
self.base_url.trim_end_matches('/')
|
self.base_url.trim_end_matches('/')
|
||||||
);
|
);
|
||||||
let mut request_body = self.request_profile.render_json_body(request)?;
|
let request_body = render_standard_messages_body(&self.request_profile, request)?;
|
||||||
strip_unsupported_beta_body_fields(&mut request_body);
|
|
||||||
let response = self
|
let response = self
|
||||||
.build_request(&request_url)
|
.build_request(&request_url)
|
||||||
.json(&request_body)
|
.json(&request_body)
|
||||||
@@ -977,6 +975,21 @@ fn enrich_bearer_auth_error(error: ApiError, auth: &AuthSource) -> ApiError {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn anthropic_wire_model(model: &str) -> &str {
|
||||||
|
model.strip_prefix("anthropic/").unwrap_or(model)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_standard_messages_body(
|
||||||
|
request_profile: &AnthropicRequestProfile,
|
||||||
|
request: &MessageRequest,
|
||||||
|
) -> Result<Value, serde_json::Error> {
|
||||||
|
let mut wire_request = request.clone();
|
||||||
|
wire_request.model = anthropic_wire_model(&request.model).to_string();
|
||||||
|
let mut body = request_profile.render_json_body(&wire_request)?;
|
||||||
|
strip_unsupported_beta_body_fields(&mut body);
|
||||||
|
Ok(body)
|
||||||
|
}
|
||||||
|
|
||||||
/// Remove beta-only body fields that the standard `/v1/messages` and
|
/// Remove beta-only body fields that the standard `/v1/messages` and
|
||||||
/// `/v1/messages/count_tokens` endpoints reject as `Extra inputs are not
|
/// `/v1/messages/count_tokens` endpoints reject as `Extra inputs are not
|
||||||
/// permitted`. The `betas` opt-in is communicated via the `anthropic-beta`
|
/// permitted`. The `betas` opt-in is communicated via the `anthropic-beta`
|
||||||
@@ -1550,6 +1563,27 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn standard_messages_body_strips_anthropic_routing_prefix() {
|
||||||
|
let client = AnthropicClient::new("test-key");
|
||||||
|
let request = MessageRequest {
|
||||||
|
model: "anthropic/claude-opus-4-6".to_string(),
|
||||||
|
max_tokens: 64,
|
||||||
|
messages: vec![],
|
||||||
|
system: None,
|
||||||
|
tools: None,
|
||||||
|
tool_choice: None,
|
||||||
|
stream: false,
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
|
||||||
|
let rendered = super::render_standard_messages_body(client.request_profile(), &request)
|
||||||
|
.expect("body should render");
|
||||||
|
|
||||||
|
assert_eq!(rendered["model"], serde_json::json!("claude-opus-4-6"));
|
||||||
|
assert!(rendered.get("betas").is_none());
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn enrich_bearer_auth_error_appends_sk_ant_hint_on_401_with_pure_bearer_token() {
|
fn enrich_bearer_auth_error_appends_sk_ant_hint_on_401_with_pure_bearer_token() {
|
||||||
// given
|
// given
|
||||||
|
|||||||
@@ -211,7 +211,7 @@ pub fn resolve_model_alias(model: &str) -> String {
|
|||||||
.find_map(|(alias, metadata)| {
|
.find_map(|(alias, metadata)| {
|
||||||
(*alias == lower).then_some(match metadata.provider {
|
(*alias == lower).then_some(match metadata.provider {
|
||||||
ProviderKind::Anthropic => match *alias {
|
ProviderKind::Anthropic => match *alias {
|
||||||
"opus" => "claude-opus-4-6",
|
"opus" => "claude-opus-4-7",
|
||||||
"sonnet" => "claude-sonnet-4-6",
|
"sonnet" => "claude-sonnet-4-6",
|
||||||
"haiku" => "claude-haiku-4-5-20251213",
|
"haiku" => "claude-haiku-4-5-20251213",
|
||||||
_ => trimmed,
|
_ => trimmed,
|
||||||
@@ -262,6 +262,14 @@ pub fn metadata_for_model(model: &str) -> Option<ProviderMetadata> {
|
|||||||
default_base_url: openai_compat::DEFAULT_OPENAI_BASE_URL,
|
default_base_url: openai_compat::DEFAULT_OPENAI_BASE_URL,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
if canonical.starts_with("local/") {
|
||||||
|
return Some(ProviderMetadata {
|
||||||
|
provider: ProviderKind::OpenAi,
|
||||||
|
auth_env: "OPENAI_API_KEY",
|
||||||
|
base_url_env: "OPENAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_OPENAI_BASE_URL,
|
||||||
|
});
|
||||||
|
}
|
||||||
// Alibaba DashScope compatible-mode endpoint. Routes qwen/* and bare
|
// Alibaba DashScope compatible-mode endpoint. Routes qwen/* and bare
|
||||||
// qwen-* model names (qwen-max, qwen-plus, qwen-turbo, qwen-qwq, etc.)
|
// qwen-* model names (qwen-max, qwen-plus, qwen-turbo, qwen-qwq, etc.)
|
||||||
// to the OpenAI-compat client pointed at DashScope's /compatible-mode/v1.
|
// to the OpenAI-compat client pointed at DashScope's /compatible-mode/v1.
|
||||||
@@ -337,17 +345,21 @@ pub fn provider_diagnostics_for_model(model: &str) -> ProviderDiagnostics {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn looks_like_local_openai_model(model: &str) -> bool {
|
||||||
|
model.contains(':') || model.contains('.')
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn detect_provider_kind(model: &str) -> ProviderKind {
|
pub fn detect_provider_kind(model: &str) -> ProviderKind {
|
||||||
if let Some(metadata) = metadata_for_model(model) {
|
let resolved_model = resolve_model_alias(model);
|
||||||
|
if let Some(metadata) = metadata_for_model(&resolved_model) {
|
||||||
return metadata.provider;
|
return metadata.provider;
|
||||||
}
|
}
|
||||||
// When OPENAI_BASE_URL is set, the user explicitly configured an
|
// When OPENAI_BASE_URL is set and the unknown model name looks like a
|
||||||
// OpenAI-compatible endpoint. Prefer it over the Anthropic fallback
|
// local server tag (for example `llama3.2` or `qwen2.5-coder:7b`), prefer
|
||||||
// even when the model name has no recognized prefix — this is the
|
// the OpenAI-compatible endpoint over ambient Anthropic credentials.
|
||||||
// common case for local providers (Ollama, LM Studio, vLLM, etc.)
|
if std::env::var_os("OPENAI_BASE_URL").is_some()
|
||||||
// where model names like "qwen2.5-coder:7b" don't match any prefix.
|
&& looks_like_local_openai_model(&resolved_model)
|
||||||
if std::env::var_os("OPENAI_BASE_URL").is_some() && openai_compat::has_api_key("OPENAI_API_KEY")
|
|
||||||
{
|
{
|
||||||
return ProviderKind::OpenAi;
|
return ProviderKind::OpenAi;
|
||||||
}
|
}
|
||||||
@@ -608,7 +620,7 @@ pub fn model_token_limit(model: &str) -> Option<ModelTokenLimit> {
|
|||||||
let canonical = resolve_model_alias(model);
|
let canonical = resolve_model_alias(model);
|
||||||
let base_model = canonical.rsplit('/').next().unwrap_or(canonical.as_str());
|
let base_model = canonical.rsplit('/').next().unwrap_or(canonical.as_str());
|
||||||
match base_model {
|
match base_model {
|
||||||
"claude-opus-4-6" => Some(ModelTokenLimit {
|
"claude-opus-4-7" | "claude-opus-4-6" => Some(ModelTokenLimit {
|
||||||
max_output_tokens: 32_000,
|
max_output_tokens: 32_000,
|
||||||
context_window_tokens: 200_000,
|
context_window_tokens: 200_000,
|
||||||
}),
|
}),
|
||||||
@@ -1042,6 +1054,18 @@ mod tests {
|
|||||||
assert_eq!(kind2, ProviderKind::OpenAi);
|
assert_eq!(kind2, ProviderKind::OpenAi);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn local_prefix_routes_to_openai_not_anthropic() {
|
||||||
|
let meta = super::metadata_for_model("local/Qwen/Qwen3.6-27B-FP8")
|
||||||
|
.expect("local/ prefix must resolve to OpenAI-compatible metadata");
|
||||||
|
assert_eq!(meta.provider, ProviderKind::OpenAi);
|
||||||
|
assert_eq!(meta.auth_env, "OPENAI_API_KEY");
|
||||||
|
assert_eq!(meta.base_url_env, "OPENAI_BASE_URL");
|
||||||
|
|
||||||
|
let kind = detect_provider_kind("local/Qwen/Qwen3.6-27B-FP8");
|
||||||
|
assert_eq!(kind, ProviderKind::OpenAi);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn qwen_prefix_routes_to_dashscope_not_anthropic() {
|
fn qwen_prefix_routes_to_dashscope_not_anthropic() {
|
||||||
// User request from Discord #clawcode-get-help: web3g wants to use
|
// User request from Discord #clawcode-get-help: web3g wants to use
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
use std::borrow::Cow;
|
use std::borrow::Cow;
|
||||||
use std::collections::{BTreeMap, VecDeque};
|
use std::collections::{BTreeMap, VecDeque};
|
||||||
|
use std::net::Ipv4Addr;
|
||||||
use std::sync::atomic::{AtomicU64, Ordering};
|
use std::sync::atomic::{AtomicU64, Ordering};
|
||||||
use std::time::{Duration, SystemTime, UNIX_EPOCH};
|
use std::time::{Duration, SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
@@ -131,13 +132,22 @@ impl OpenAiCompatClient {
|
|||||||
}
|
}
|
||||||
|
|
||||||
pub fn from_env(config: OpenAiCompatConfig) -> Result<Self, ApiError> {
|
pub fn from_env(config: OpenAiCompatConfig) -> Result<Self, ApiError> {
|
||||||
let Some(api_key) = read_env_non_empty(config.api_key_env)? else {
|
let base_url = read_base_url(config);
|
||||||
return Err(ApiError::missing_credentials(
|
let api_key = match read_env_non_empty(config.api_key_env)? {
|
||||||
config.provider_name,
|
Some(api_key) => api_key,
|
||||||
config.credential_env_vars(),
|
None if config.provider_name == "OpenAI"
|
||||||
));
|
&& is_local_openai_compatible_base_url(&base_url) =>
|
||||||
|
{
|
||||||
|
"local-dev-token".to_string()
|
||||||
|
}
|
||||||
|
None => {
|
||||||
|
return Err(ApiError::missing_credentials(
|
||||||
|
config.provider_name,
|
||||||
|
config.credential_env_vars(),
|
||||||
|
));
|
||||||
|
}
|
||||||
};
|
};
|
||||||
Ok(Self::new(api_key, config))
|
Ok(Self::new(api_key, config).with_base_url(base_url))
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
@@ -915,14 +925,18 @@ pub fn model_requires_reasoning_content_in_history(model: &str) -> bool {
|
|||||||
|
|
||||||
/// Strip routing prefix (e.g., "openai/gpt-4" → "gpt-4") for the wire.
|
/// Strip routing prefix (e.g., "openai/gpt-4" → "gpt-4") for the wire.
|
||||||
/// The prefix is used only to select transport; the backend expects the
|
/// The prefix is used only to select transport; the backend expects the
|
||||||
/// bare model id.
|
/// bare model id. Use `local/` to force OpenAI-compatible routing while
|
||||||
|
/// preserving any slashes that follow the prefix.
|
||||||
#[allow(dead_code)]
|
#[allow(dead_code)]
|
||||||
fn strip_routing_prefix(model: &str) -> &str {
|
fn strip_routing_prefix(model: &str) -> &str {
|
||||||
if let Some(pos) = model.find('/') {
|
if let Some(pos) = model.find('/') {
|
||||||
let prefix = &model[..pos];
|
let prefix = &model[..pos];
|
||||||
// Only strip if the prefix before "/" is a known routing prefix,
|
// Only strip if the prefix before "/" is a known routing prefix,
|
||||||
// not if "/" appears in the middle of the model name for other reasons.
|
// not if "/" appears in the middle of the model name for other reasons.
|
||||||
if matches!(prefix, "openai" | "xai" | "grok" | "qwen" | "kimi") {
|
if matches!(
|
||||||
|
prefix,
|
||||||
|
"openai" | "xai" | "grok" | "qwen" | "kimi" | "local"
|
||||||
|
) {
|
||||||
&model[pos + 1..]
|
&model[pos + 1..]
|
||||||
} else {
|
} else {
|
||||||
model
|
model
|
||||||
@@ -932,6 +946,44 @@ fn strip_routing_prefix(model: &str) -> &str {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn normalize_base_url_for_model_routing(url: &str) -> &str {
|
||||||
|
let trimmed = url.trim_end_matches('/');
|
||||||
|
trimmed
|
||||||
|
.strip_suffix("/chat/completions")
|
||||||
|
.map(|value| value.trim_end_matches('/'))
|
||||||
|
.unwrap_or(trimmed)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn url_host(url: &str) -> &str {
|
||||||
|
let after_scheme = url.split_once("://").map_or(url, |(_, rest)| rest);
|
||||||
|
let authority = after_scheme.split(['/', '?', '#']).next().unwrap_or("");
|
||||||
|
let host_port = authority
|
||||||
|
.rsplit_once('@')
|
||||||
|
.map_or(authority, |(_, host_port)| host_port);
|
||||||
|
if host_port.starts_with('[') {
|
||||||
|
return host_port
|
||||||
|
.split(']')
|
||||||
|
.next()
|
||||||
|
.unwrap_or("")
|
||||||
|
.trim_start_matches('[');
|
||||||
|
}
|
||||||
|
host_port.split(':').next().unwrap_or("")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_local_openai_compatible_base_url(url: &str) -> bool {
|
||||||
|
let host = url_host(url.trim());
|
||||||
|
if host.eq_ignore_ascii_case("localhost") || host == "::1" {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
let Ok(address) = host.parse::<Ipv4Addr>() else {
|
||||||
|
return false;
|
||||||
|
};
|
||||||
|
let [first, second, ..] = address.octets();
|
||||||
|
matches!(first, 10 | 127)
|
||||||
|
|| first == 192 && second == 168
|
||||||
|
|| first == 172 && (16..=31).contains(&second)
|
||||||
|
}
|
||||||
|
|
||||||
fn wire_model_for_base_url<'a>(
|
fn wire_model_for_base_url<'a>(
|
||||||
model: &'a str,
|
model: &'a str,
|
||||||
config: OpenAiCompatConfig,
|
config: OpenAiCompatConfig,
|
||||||
@@ -944,26 +996,22 @@ fn wire_model_for_base_url<'a>(
|
|||||||
let lowered_prefix = prefix.to_ascii_lowercase();
|
let lowered_prefix = prefix.to_ascii_lowercase();
|
||||||
|
|
||||||
if lowered_prefix == "openai" {
|
if lowered_prefix == "openai" {
|
||||||
let trimmed_base_url = base_url.trim_end_matches('/');
|
let normalized_base_url = normalize_base_url_for_model_routing(base_url);
|
||||||
let default_openai = DEFAULT_OPENAI_BASE_URL.trim_end_matches('/');
|
let default_base_url = normalize_base_url_for_model_routing(config.default_base_url);
|
||||||
if matches!(
|
if normalized_base_url.eq_ignore_ascii_case(default_base_url)
|
||||||
lowered_prefix.as_str(),
|
|| is_local_openai_compatible_base_url(base_url)
|
||||||
"xai" | "grok" | "kimi" | "gemini" | "gemma"
|
{
|
||||||
) {
|
|
||||||
return Cow::Borrowed(&model[pos + 1..]);
|
return Cow::Borrowed(&model[pos + 1..]);
|
||||||
}
|
}
|
||||||
if config.provider_name == "OpenAI" && trimmed_base_url != default_openai {
|
return Cow::Borrowed(model);
|
||||||
// Only preserve the full slug if it's NOT a model we want to strip
|
|
||||||
if !model.contains("gemini") && !model.contains("gemma") {
|
|
||||||
return Cow::Borrowed(model);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return Cow::Borrowed(&model[pos + 1..]);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if matches!(lowered_prefix.as_str(), "xai" | "grok" | "qwen" | "kimi") {
|
if matches!(lowered_prefix.as_str(), "xai" | "grok" | "qwen" | "kimi") {
|
||||||
return Cow::Borrowed(&model[pos + 1..]);
|
return Cow::Borrowed(&model[pos + 1..]);
|
||||||
}
|
}
|
||||||
|
if lowered_prefix == "local" {
|
||||||
|
return Cow::Borrowed(&model[pos + 1..]);
|
||||||
|
}
|
||||||
|
|
||||||
Cow::Borrowed(model)
|
Cow::Borrowed(model)
|
||||||
}
|
}
|
||||||
@@ -1115,6 +1163,13 @@ fn build_chat_completion_request_for_base_url(
|
|||||||
payload[key] = value.clone();
|
payload[key] = value.clone();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// DeepSeek V4 Pro/Flash thinking mode requires this provider-specific opt-in
|
||||||
|
// and also requires assistant reasoning history to be echoed as `reasoning_content`.
|
||||||
|
// Apply it after extra_body so callers cannot accidentally override the required shape.
|
||||||
|
if model_requires_reasoning_content_in_history(wire_model) {
|
||||||
|
payload["thinking"] = json!({"type": "enabled"});
|
||||||
|
}
|
||||||
|
|
||||||
payload
|
payload
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1172,16 +1227,19 @@ pub fn translate_message(message: &InputMessage, model: &str) -> Vec<Value> {
|
|||||||
InputContentBlock::ToolResult { .. } => {}
|
InputContentBlock::ToolResult { .. } => {}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
let include_reasoning =
|
let needs_reasoning = model_requires_reasoning_content_in_history(model);
|
||||||
model_requires_reasoning_content_in_history(model) && !reasoning.is_empty();
|
if text.is_empty() && tool_calls.is_empty() && reasoning.is_empty() {
|
||||||
if text.is_empty() && tool_calls.is_empty() && !include_reasoning {
|
|
||||||
Vec::new()
|
Vec::new()
|
||||||
} else {
|
} else {
|
||||||
let mut msg = serde_json::json!({
|
let mut msg = serde_json::json!({
|
||||||
"role": "assistant",
|
"role": "assistant",
|
||||||
"content": (!text.is_empty()).then_some(text),
|
|
||||||
});
|
});
|
||||||
if include_reasoning {
|
if !text.is_empty() {
|
||||||
|
msg["content"] = json!(text);
|
||||||
|
} else if !needs_reasoning {
|
||||||
|
msg["content"] = Value::Null;
|
||||||
|
}
|
||||||
|
if needs_reasoning {
|
||||||
msg["reasoning_content"] = json!(reasoning);
|
msg["reasoning_content"] = json!(reasoning);
|
||||||
}
|
}
|
||||||
// Only include tool_calls when non-empty: some providers reject
|
// Only include tool_calls when non-empty: some providers reject
|
||||||
@@ -1698,6 +1756,7 @@ mod tests {
|
|||||||
ToolChoice, ToolDefinition, ToolResultContentBlock,
|
ToolChoice, ToolDefinition, ToolResultContentBlock,
|
||||||
};
|
};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
|
use std::borrow::Cow;
|
||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
use std::sync::{Mutex, OnceLock};
|
use std::sync::{Mutex, OnceLock};
|
||||||
|
|
||||||
@@ -1796,6 +1855,31 @@ mod tests {
|
|||||||
assert_eq!(assistant["content"], json!("answer"));
|
assert_eq!(assistant["content"], json!("answer"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn deepseek_v4_assistant_with_only_tool_calls_omits_content_and_includes_reasoning() {
|
||||||
|
let request = MessageRequest {
|
||||||
|
model: "deepseek-v4-pro".to_string(),
|
||||||
|
max_tokens: 100,
|
||||||
|
messages: vec![InputMessage {
|
||||||
|
role: "assistant".to_string(),
|
||||||
|
content: vec![InputContentBlock::ToolUse {
|
||||||
|
id: "call_1".to_string(),
|
||||||
|
name: "get_weather".to_string(),
|
||||||
|
input: json!({"city": "Paris"}),
|
||||||
|
}],
|
||||||
|
}],
|
||||||
|
stream: false,
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
|
||||||
|
let payload = build_chat_completion_request(&request, OpenAiCompatConfig::openai());
|
||||||
|
let assistant = &payload["messages"][0];
|
||||||
|
|
||||||
|
assert!(assistant.get("content").is_none());
|
||||||
|
assert_eq!(assistant["reasoning_content"], json!(""));
|
||||||
|
assert_eq!(assistant["tool_calls"].as_array().map(Vec::len), Some(1));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn deepseek_v4_flash_request_includes_reasoning_content_for_assistant_history() {
|
fn deepseek_v4_flash_request_includes_reasoning_content_for_assistant_history() {
|
||||||
// Given an assistant history turn containing thinking.
|
// Given an assistant history turn containing thinking.
|
||||||
@@ -1982,6 +2066,49 @@ mod tests {
|
|||||||
assert_eq!(payload["reasoning_effort"], json!("high"));
|
assert_eq!(payload["reasoning_effort"], json!("high"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn deepseek_v4_request_includes_thinking_parameter() {
|
||||||
|
let payload = build_chat_completion_request(
|
||||||
|
&MessageRequest {
|
||||||
|
model: "deepseek-v4-pro".to_string(),
|
||||||
|
max_tokens: 1024,
|
||||||
|
messages: vec![InputMessage::user_text("hello")],
|
||||||
|
..Default::default()
|
||||||
|
},
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
);
|
||||||
|
assert_eq!(payload["thinking"], json!({"type": "enabled"}));
|
||||||
|
assert_eq!(payload["model"], json!("deepseek-v4-pro"));
|
||||||
|
|
||||||
|
let mut extra_body = BTreeMap::new();
|
||||||
|
extra_body.insert("thinking".to_string(), json!({"type": "disabled"}));
|
||||||
|
let payload_with_override = build_chat_completion_request(
|
||||||
|
&MessageRequest {
|
||||||
|
model: "openai/deepseek-v4-flash".to_string(),
|
||||||
|
max_tokens: 1024,
|
||||||
|
messages: vec![InputMessage::user_text("hello")],
|
||||||
|
extra_body,
|
||||||
|
..Default::default()
|
||||||
|
},
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
payload_with_override["thinking"],
|
||||||
|
json!({"type": "enabled"})
|
||||||
|
);
|
||||||
|
|
||||||
|
let non_deepseek_payload = build_chat_completion_request(
|
||||||
|
&MessageRequest {
|
||||||
|
model: "gpt-4o".to_string(),
|
||||||
|
max_tokens: 64,
|
||||||
|
messages: vec![InputMessage::user_text("hello")],
|
||||||
|
..Default::default()
|
||||||
|
},
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
);
|
||||||
|
assert!(non_deepseek_payload.get("thinking").is_none());
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reasoning_effort_omitted_when_not_set() {
|
fn reasoning_effort_omitted_when_not_set() {
|
||||||
let payload = build_chat_completion_request(
|
let payload = build_chat_completion_request(
|
||||||
@@ -2069,6 +2196,28 @@ mod tests {
|
|||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn local_openai_base_url_does_not_require_api_key() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let original_base_url = std::env::var_os("OPENAI_BASE_URL");
|
||||||
|
let original_api_key = std::env::var_os("OPENAI_API_KEY");
|
||||||
|
std::env::set_var("OPENAI_BASE_URL", "http://127.0.0.1:11434/v1");
|
||||||
|
std::env::remove_var("OPENAI_API_KEY");
|
||||||
|
|
||||||
|
let client = OpenAiCompatClient::from_env(OpenAiCompatConfig::openai())
|
||||||
|
.expect("local OpenAI-compatible endpoint should not require an API key");
|
||||||
|
assert_eq!(client.base_url(), "http://127.0.0.1:11434/v1");
|
||||||
|
|
||||||
|
match original_base_url {
|
||||||
|
Some(value) => std::env::set_var("OPENAI_BASE_URL", value),
|
||||||
|
None => std::env::remove_var("OPENAI_BASE_URL"),
|
||||||
|
}
|
||||||
|
match original_api_key {
|
||||||
|
Some(value) => std::env::set_var("OPENAI_API_KEY", value),
|
||||||
|
None => std::env::remove_var("OPENAI_API_KEY"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn endpoint_builder_accepts_base_urls_and_full_endpoints() {
|
fn endpoint_builder_accepts_base_urls_and_full_endpoints() {
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
@@ -2684,6 +2833,66 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn wire_model_strips_openai_prefix_for_default_and_local_preserves_custom_gateways() {
|
||||||
|
assert_eq!(
|
||||||
|
super::wire_model_for_base_url(
|
||||||
|
"openai/gpt-4o",
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
super::DEFAULT_OPENAI_BASE_URL,
|
||||||
|
),
|
||||||
|
Cow::Borrowed("gpt-4o")
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::wire_model_for_base_url(
|
||||||
|
"openai/qwen2.5-coder:7b",
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
"http://127.0.0.1:11434/v1",
|
||||||
|
),
|
||||||
|
Cow::Borrowed("qwen2.5-coder:7b")
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::wire_model_for_base_url(
|
||||||
|
"openai/llama3.2",
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
"http://localhost:11434/v1/chat/completions",
|
||||||
|
),
|
||||||
|
Cow::Borrowed("llama3.2")
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::wire_model_for_base_url(
|
||||||
|
"openai/gpt-4.1-mini",
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
"https://openrouter.ai/api/v1",
|
||||||
|
),
|
||||||
|
Cow::Borrowed("openai/gpt-4.1-mini")
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::wire_model_for_base_url(
|
||||||
|
"openai/gpt-4.1-mini",
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
"https://not-localhost.example.com/v1",
|
||||||
|
),
|
||||||
|
Cow::Borrowed("openai/gpt-4.1-mini")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn local_routing_prefix_strips_only_escape_hatch() {
|
||||||
|
assert_eq!(
|
||||||
|
super::strip_routing_prefix("local/Qwen/Qwen3.6-27B-FP8"),
|
||||||
|
"Qwen/Qwen3.6-27B-FP8"
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::wire_model_for_base_url(
|
||||||
|
"local/Qwen/Qwen3.6-27B-FP8",
|
||||||
|
OpenAiCompatConfig::openai(),
|
||||||
|
"http://127.0.0.1:8000/v1",
|
||||||
|
),
|
||||||
|
Cow::Borrowed("Qwen/Qwen3.6-27B-FP8")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn check_request_body_size_allows_large_requests_for_openai() {
|
fn check_request_body_size_allows_large_requests_for_openai() {
|
||||||
// Create a request that exceeds DashScope's limit but is under OpenAI's 100MB limit
|
// Create a request that exceeds DashScope's limit but is under OpenAI's 100MB limit
|
||||||
|
|||||||
@@ -103,6 +103,58 @@ async fn send_message_posts_json_and_parses_response() {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn send_message_strips_anthropic_routing_prefix_on_wire() {
|
||||||
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
let server = spawn_server(
|
||||||
|
state.clone(),
|
||||||
|
vec![
|
||||||
|
http_response("200 OK", "application/json", "{\"input_tokens\":1}"),
|
||||||
|
http_response(
|
||||||
|
"200 OK",
|
||||||
|
"application/json",
|
||||||
|
concat!(
|
||||||
|
"{",
|
||||||
|
"\"id\":\"msg_prefixed\",",
|
||||||
|
"\"type\":\"message\",",
|
||||||
|
"\"role\":\"assistant\",",
|
||||||
|
"\"content\":[{\"type\":\"text\",\"text\":\"ok\"}],",
|
||||||
|
"\"model\":\"claude-opus-4-6\",",
|
||||||
|
"\"stop_reason\":\"end_turn\",",
|
||||||
|
"\"stop_sequence\":null,",
|
||||||
|
"\"usage\":{\"input_tokens\":1,\"output_tokens\":1}",
|
||||||
|
"}"
|
||||||
|
),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
|
||||||
|
let client = AnthropicClient::new("test-key").with_base_url(server.base_url());
|
||||||
|
client
|
||||||
|
.send_message(&MessageRequest {
|
||||||
|
model: "anthropic/claude-opus-4-6".to_string(),
|
||||||
|
..sample_request(false)
|
||||||
|
})
|
||||||
|
.await
|
||||||
|
.expect("request should succeed");
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
assert_eq!(
|
||||||
|
captured.len(),
|
||||||
|
2,
|
||||||
|
"count_tokens and messages requests should be captured"
|
||||||
|
);
|
||||||
|
let count_tokens_body: serde_json::Value =
|
||||||
|
serde_json::from_str(&captured[0].body).expect("count_tokens body should be json");
|
||||||
|
let messages_body: serde_json::Value =
|
||||||
|
serde_json::from_str(&captured[1].body).expect("request body should be json");
|
||||||
|
assert_eq!(captured[0].path, "/v1/messages/count_tokens");
|
||||||
|
assert_eq!(captured[1].path, "/v1/messages");
|
||||||
|
assert_eq!(count_tokens_body["model"], json!("claude-opus-4-6"));
|
||||||
|
assert_eq!(messages_body["model"], json!("claude-opus-4-6"));
|
||||||
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn send_message_blocks_oversized_requests_before_the_http_call() {
|
async fn send_message_blocks_oversized_requests_before_the_http_call() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
|||||||
@@ -159,10 +159,15 @@ async fn send_message_preserves_deepseek_reasoning_content_before_text() {
|
|||||||
},
|
},
|
||||||
]
|
]
|
||||||
);
|
);
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
let request = captured.first().expect("server should capture request");
|
||||||
|
let body: serde_json::Value = serde_json::from_str(&request.body).expect("json body");
|
||||||
|
assert_eq!(body["thinking"], json!({"type": "enabled"}));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn custom_openai_gateway_preserves_slash_model_ids_and_extra_body_params() {
|
async fn local_openai_gateway_strips_routing_prefix_and_preserves_extra_body_params() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
let body = concat!(
|
let body = concat!(
|
||||||
"{",
|
"{",
|
||||||
@@ -206,7 +211,7 @@ async fn custom_openai_gateway_preserves_slash_model_ids_and_extra_body_params()
|
|||||||
let captured = state.lock().await;
|
let captured = state.lock().await;
|
||||||
let request = captured.first().expect("captured request");
|
let request = captured.first().expect("captured request");
|
||||||
let body: serde_json::Value = serde_json::from_str(&request.body).expect("json body");
|
let body: serde_json::Value = serde_json::from_str(&request.body).expect("json body");
|
||||||
assert_eq!(body["model"], json!("openai/gpt-4.1-mini"));
|
assert_eq!(body["model"], json!("gpt-4.1-mini"));
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
body["web_search_options"],
|
body["web_search_options"],
|
||||||
json!({"search_context_size": "low"})
|
json!({"search_context_size": "low"})
|
||||||
|
|||||||
@@ -239,15 +239,15 @@ const SLASH_COMMAND_SPECS: &[SlashCommandSpec] = &[
|
|||||||
SlashCommandSpec {
|
SlashCommandSpec {
|
||||||
name: "agents",
|
name: "agents",
|
||||||
aliases: &[],
|
aliases: &[],
|
||||||
summary: "List configured agents",
|
summary: "List, show, or create configured agents",
|
||||||
argument_hint: Some("[list|help]"),
|
argument_hint: Some("[list|show <name>|create <name>|help]"),
|
||||||
resume_supported: true,
|
resume_supported: true,
|
||||||
},
|
},
|
||||||
SlashCommandSpec {
|
SlashCommandSpec {
|
||||||
name: "skills",
|
name: "skills",
|
||||||
aliases: &["skill"],
|
aliases: &["skill"],
|
||||||
summary: "List, install, or invoke available skills",
|
summary: "List, install, uninstall, or invoke available skills",
|
||||||
argument_hint: Some("[list|install <path>|help|<skill> [args]]"),
|
argument_hint: Some("[list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]"),
|
||||||
resume_supported: true,
|
resume_supported: true,
|
||||||
},
|
},
|
||||||
SlashCommandSpec {
|
SlashCommandSpec {
|
||||||
@@ -1767,13 +1767,25 @@ fn parse_list_or_help_args(
|
|||||||
args: Option<String>,
|
args: Option<String>,
|
||||||
) -> Result<Option<String>, SlashCommandParseError> {
|
) -> Result<Option<String>, SlashCommandParseError> {
|
||||||
match normalize_optional_args(args.as_deref()) {
|
match normalize_optional_args(args.as_deref()) {
|
||||||
None | Some("list" | "help" | "-h" | "--help") => Ok(args),
|
None
|
||||||
|
| Some(
|
||||||
|
"list" | "help" | "-h" | "--help" | "show" | "info" | "describe" | "create",
|
||||||
|
) => Ok(args),
|
||||||
|
Some(value)
|
||||||
|
if value.starts_with("list ")
|
||||||
|
|| value.starts_with("show ")
|
||||||
|
|| value.starts_with("info ")
|
||||||
|
|| value.starts_with("describe ")
|
||||||
|
|| value.starts_with("create ") =>
|
||||||
|
{
|
||||||
|
Ok(args)
|
||||||
|
}
|
||||||
Some(unexpected) => Err(command_error(
|
Some(unexpected) => Err(command_error(
|
||||||
&format!(
|
&format!(
|
||||||
"Unexpected arguments for /{command}: {unexpected}. Use /{command}, /{command} list, or /{command} help."
|
"Unexpected arguments for /{command}: {unexpected}. Use /{command}, /{command} list, /{command} show <name>, /{command} create <name>, or /{command} help."
|
||||||
),
|
),
|
||||||
command,
|
command,
|
||||||
&format!("/{command} [list|help]"),
|
&format!("/{command} [list|show <name>|create <name>|help]"),
|
||||||
)),
|
)),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1787,14 +1799,6 @@ fn parse_skills_args(args: Option<&str>) -> Result<Option<String>, SlashCommandP
|
|||||||
return Ok(Some(args.to_string()));
|
return Ok(Some(args.to_string()));
|
||||||
}
|
}
|
||||||
|
|
||||||
if args == "install" {
|
|
||||||
return Err(command_error(
|
|
||||||
"Usage: /skills install <path>",
|
|
||||||
"skills",
|
|
||||||
"/skills install <path>",
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
if let Some(target) = args.strip_prefix("install").map(str::trim) {
|
if let Some(target) = args.strip_prefix("install").map(str::trim) {
|
||||||
if !target.is_empty() {
|
if !target.is_empty() {
|
||||||
return Ok(Some(format!("install {target}")));
|
return Ok(Some(format!("install {target}")));
|
||||||
@@ -2195,6 +2199,30 @@ struct InstalledSkill {
|
|||||||
installed_path: PathBuf,
|
installed_path: PathBuf,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
struct UninstalledSkill {
|
||||||
|
invocation_name: String,
|
||||||
|
registry_root: PathBuf,
|
||||||
|
removed_path: PathBuf,
|
||||||
|
available_names: Vec<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
enum SkillUninstallOutcome {
|
||||||
|
Removed(UninstalledSkill),
|
||||||
|
Missing {
|
||||||
|
requested: String,
|
||||||
|
registry_root: PathBuf,
|
||||||
|
available_names: Vec<String>,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
struct CreatedAgent {
|
||||||
|
name: String,
|
||||||
|
path: PathBuf,
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
enum SkillInstallSource {
|
enum SkillInstallSource {
|
||||||
Directory { root: PathBuf, prompt_path: PathBuf },
|
Directory { root: PathBuf, prompt_path: PathBuf },
|
||||||
@@ -2422,10 +2450,32 @@ pub fn handle_agents_slash_command(args: Option<&str>, cwd: &Path) -> std::io::R
|
|||||||
}
|
}
|
||||||
Ok(render_agents_report(&matched))
|
Ok(render_agents_report(&matched))
|
||||||
}
|
}
|
||||||
|
Some("create") => Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"missing_argument: agents create requires an agent name.\nUsage: claw agents create <name>",
|
||||||
|
)),
|
||||||
|
Some(args) if args.starts_with("create ") => {
|
||||||
|
let mut parts = args.split_whitespace();
|
||||||
|
let _ = parts.next();
|
||||||
|
let Some(name) = parts.next() else {
|
||||||
|
return Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"missing_argument: agents create requires an agent name.\nUsage: claw agents create <name>",
|
||||||
|
));
|
||||||
|
};
|
||||||
|
if let Some(extra) = parts.next() {
|
||||||
|
return Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
format!("unexpected extra arguments after agent name\nUsage: claw agents create <name>\nUnexpected extra: '{extra}'"),
|
||||||
|
));
|
||||||
|
}
|
||||||
|
let agent = create_agent(name, cwd)?;
|
||||||
|
Ok(render_agent_create_report(&agent))
|
||||||
|
}
|
||||||
Some(args) if is_help_arg(args) => Ok(render_agents_usage(None)),
|
Some(args) if is_help_arg(args) => Ok(render_agents_usage(None)),
|
||||||
Some(args) => Err(std::io::Error::new(
|
Some(args) => Err(std::io::Error::new(
|
||||||
std::io::ErrorKind::InvalidInput,
|
std::io::ErrorKind::InvalidInput,
|
||||||
format!("unknown agents subcommand: {args}.\nSupported: list, show, help"),
|
format!("unknown agents subcommand: {args}.\nSupported: list, show, create, help"),
|
||||||
)),
|
)),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2522,10 +2572,32 @@ pub fn handle_agents_slash_command_json(args: Option<&str>, cwd: &Path) -> std::
|
|||||||
}
|
}
|
||||||
Ok(render_agents_report_json_with_action(cwd, &matched, "show"))
|
Ok(render_agents_report_json_with_action(cwd, &matched, "show"))
|
||||||
}
|
}
|
||||||
|
Some("create") => Ok(render_agents_missing_argument_json("create", "agent_name")),
|
||||||
|
Some(args) if args.starts_with("create ") => {
|
||||||
|
let mut parts = args.split_whitespace();
|
||||||
|
let _ = parts.next();
|
||||||
|
let Some(name) = parts.next() else {
|
||||||
|
return Ok(render_agents_missing_argument_json("create", "agent_name"));
|
||||||
|
};
|
||||||
|
if let Some(extra) = parts.next() {
|
||||||
|
return Ok(json!({
|
||||||
|
"kind": "agents",
|
||||||
|
"action": "create",
|
||||||
|
"status": "error",
|
||||||
|
"error_kind": "unexpected_extra_args",
|
||||||
|
"unexpected": extra,
|
||||||
|
"hint": format!("Usage: claw agents create <name>\nUnexpected extra: '{extra}'"),
|
||||||
|
}));
|
||||||
|
}
|
||||||
|
match create_agent(name, cwd) {
|
||||||
|
Ok(agent) => Ok(render_agent_create_report_json(&agent)),
|
||||||
|
Err(error) => Ok(render_agent_create_error_json(name, &error)),
|
||||||
|
}
|
||||||
|
}
|
||||||
Some(args) if is_help_arg(args) => Ok(render_agents_usage_json(None)),
|
Some(args) if is_help_arg(args) => Ok(render_agents_usage_json(None)),
|
||||||
Some(args) => Err(std::io::Error::new(
|
Some(args) => Err(std::io::Error::new(
|
||||||
std::io::ErrorKind::InvalidInput,
|
std::io::ErrorKind::InvalidInput,
|
||||||
format!("unknown agents subcommand: {args}.\nSupported: list, show, help"),
|
format!("unknown agents subcommand: {args}.\nSupported: list, show, create, help"),
|
||||||
)),
|
)),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2627,15 +2699,53 @@ pub fn handle_skills_slash_command(args: Option<&str>, cwd: &Path) -> std::io::R
|
|||||||
}
|
}
|
||||||
Ok(render_skills_report(&matched))
|
Ok(render_skills_report(&matched))
|
||||||
}
|
}
|
||||||
Some("install") => Ok(render_skills_usage(Some("install"))),
|
Some("install") => Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"missing_argument: skills install requires an install source.\nUsage: claw skills install <path>",
|
||||||
|
)),
|
||||||
Some(args) if args.starts_with("install ") => {
|
Some(args) if args.starts_with("install ") => {
|
||||||
let target = args["install ".len()..].trim();
|
let target = args["install ".len()..].trim();
|
||||||
if target.is_empty() {
|
if target.is_empty() {
|
||||||
return Ok(render_skills_usage(Some("install")));
|
return Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"missing_argument: skills install requires an install source.\nUsage: claw skills install <path>",
|
||||||
|
));
|
||||||
}
|
}
|
||||||
let install = install_skill(target, cwd)?;
|
let install = install_skill(target, cwd)?;
|
||||||
Ok(render_skill_install_report(&install))
|
Ok(render_skill_install_report(&install))
|
||||||
}
|
}
|
||||||
|
Some("uninstall" | "remove" | "delete") => Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"missing_argument: skills uninstall requires a skill name.\nUsage: claw skills uninstall <name>",
|
||||||
|
)),
|
||||||
|
Some(args)
|
||||||
|
if args.starts_with("uninstall ")
|
||||||
|
|| args.starts_with("remove ")
|
||||||
|
|| args.starts_with("delete ") =>
|
||||||
|
{
|
||||||
|
let (_, target) = args.split_once(' ').unwrap_or_default();
|
||||||
|
let target = target.trim();
|
||||||
|
if target.is_empty() {
|
||||||
|
return Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"missing_argument: skills uninstall requires a skill name.\nUsage: claw skills uninstall <name>",
|
||||||
|
));
|
||||||
|
}
|
||||||
|
match uninstall_skill(target)? {
|
||||||
|
SkillUninstallOutcome::Removed(skill) => Ok(render_skill_uninstall_report(&skill)),
|
||||||
|
SkillUninstallOutcome::Missing {
|
||||||
|
requested,
|
||||||
|
available_names,
|
||||||
|
..
|
||||||
|
} => Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::NotFound,
|
||||||
|
format!(
|
||||||
|
"skill '{requested}' not found\nAvailable skills: {}\nRun `claw skills list` to see available skills.",
|
||||||
|
format_optional_list(&available_names)
|
||||||
|
),
|
||||||
|
)),
|
||||||
|
}
|
||||||
|
}
|
||||||
Some(args) if is_help_arg(args) => Ok(render_skills_usage(None)),
|
Some(args) if is_help_arg(args) => Ok(render_skills_usage(None)),
|
||||||
Some(args) => Ok(render_skills_usage(Some(args))),
|
Some(args) => Ok(render_skills_usage(Some(args))),
|
||||||
}
|
}
|
||||||
@@ -2734,14 +2844,58 @@ pub fn handle_skills_slash_command_json(args: Option<&str>, cwd: &Path) -> std::
|
|||||||
}
|
}
|
||||||
Ok(render_skills_report_json_with_action(&matched, "show"))
|
Ok(render_skills_report_json_with_action(&matched, "show"))
|
||||||
}
|
}
|
||||||
Some("install") => Ok(render_skills_usage_json(Some("install"))),
|
Some("install") => Ok(render_skills_missing_argument_json(
|
||||||
|
"install",
|
||||||
|
"install_source",
|
||||||
|
"Usage: claw skills install <path>",
|
||||||
|
)),
|
||||||
Some(args) if args.starts_with("install ") => {
|
Some(args) if args.starts_with("install ") => {
|
||||||
let target = args["install ".len()..].trim();
|
let target = args["install ".len()..].trim();
|
||||||
if target.is_empty() {
|
if target.is_empty() {
|
||||||
return Ok(render_skills_usage_json(Some("install")));
|
return Ok(render_skills_missing_argument_json(
|
||||||
|
"install",
|
||||||
|
"install_source",
|
||||||
|
"Usage: claw skills install <path>",
|
||||||
|
));
|
||||||
|
}
|
||||||
|
match install_skill(target, cwd) {
|
||||||
|
Ok(install) => Ok(render_skill_install_report_json(&install)),
|
||||||
|
Err(error) => Ok(render_skill_install_error_json(target, &error)),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Some("uninstall" | "remove" | "delete") => Ok(render_skills_missing_argument_json(
|
||||||
|
"uninstall",
|
||||||
|
"skill_name",
|
||||||
|
"Usage: claw skills uninstall <name>",
|
||||||
|
)),
|
||||||
|
Some(args)
|
||||||
|
if args.starts_with("uninstall ")
|
||||||
|
|| args.starts_with("remove ")
|
||||||
|
|| args.starts_with("delete ") =>
|
||||||
|
{
|
||||||
|
let (_, target) = args.split_once(' ').unwrap_or_default();
|
||||||
|
let target = target.trim();
|
||||||
|
if target.is_empty() {
|
||||||
|
return Ok(render_skills_missing_argument_json(
|
||||||
|
"uninstall",
|
||||||
|
"skill_name",
|
||||||
|
"Usage: claw skills uninstall <name>",
|
||||||
|
));
|
||||||
|
}
|
||||||
|
match uninstall_skill(target)? {
|
||||||
|
SkillUninstallOutcome::Removed(skill) => {
|
||||||
|
Ok(render_skill_uninstall_report_json(&skill))
|
||||||
|
}
|
||||||
|
SkillUninstallOutcome::Missing {
|
||||||
|
requested,
|
||||||
|
registry_root,
|
||||||
|
available_names,
|
||||||
|
} => Ok(render_skill_uninstall_missing_json(
|
||||||
|
&requested,
|
||||||
|
®istry_root,
|
||||||
|
&available_names,
|
||||||
|
)),
|
||||||
}
|
}
|
||||||
let install = install_skill(target, cwd)?;
|
|
||||||
Ok(render_skill_install_report_json(&install))
|
|
||||||
}
|
}
|
||||||
Some(args) if is_help_arg(args) => Ok(render_skills_usage_json(None)),
|
Some(args) if is_help_arg(args) => Ok(render_skills_usage_json(None)),
|
||||||
Some(args) => Ok(render_skills_usage_json(Some(args))),
|
Some(args) => Ok(render_skills_usage_json(Some(args))),
|
||||||
@@ -2751,9 +2905,11 @@ pub fn handle_skills_slash_command_json(args: Option<&str>, cwd: &Path) -> std::
|
|||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn classify_skills_slash_command(args: Option<&str>) -> SkillSlashDispatch {
|
pub fn classify_skills_slash_command(args: Option<&str>) -> SkillSlashDispatch {
|
||||||
match normalize_optional_args(args) {
|
match normalize_optional_args(args) {
|
||||||
None | Some("list" | "help" | "-h" | "--help" | "show" | "info" | "describe") => {
|
None
|
||||||
SkillSlashDispatch::Local
|
| Some(
|
||||||
}
|
"list" | "help" | "-h" | "--help" | "show" | "info" | "describe" | "install"
|
||||||
|
| "uninstall" | "remove" | "delete",
|
||||||
|
) => SkillSlashDispatch::Local,
|
||||||
Some(args)
|
Some(args)
|
||||||
if args
|
if args
|
||||||
.split_whitespace()
|
.split_whitespace()
|
||||||
@@ -2761,7 +2917,12 @@ pub fn classify_skills_slash_command(args: Option<&str>) -> SkillSlashDispatch {
|
|||||||
{
|
{
|
||||||
SkillSlashDispatch::Local
|
SkillSlashDispatch::Local
|
||||||
}
|
}
|
||||||
Some(args) if args == "install" || args.starts_with("install ") => {
|
Some(args)
|
||||||
|
if args.starts_with("install ")
|
||||||
|
|| args.starts_with("uninstall ")
|
||||||
|
|| args.starts_with("remove ")
|
||||||
|
|| args.starts_with("delete ") =>
|
||||||
|
{
|
||||||
SkillSlashDispatch::Local
|
SkillSlashDispatch::Local
|
||||||
}
|
}
|
||||||
Some(args)
|
Some(args)
|
||||||
@@ -2806,7 +2967,7 @@ pub fn resolve_skill_invocation(
|
|||||||
message.push_str(&names.join(", "));
|
message.push_str(&names.join(", "));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
message.push_str("\n Usage: /skills [list|install <path>|help|<skill> [args]]");
|
message.push_str("\n Usage: /skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]");
|
||||||
return Err(message);
|
return Err(message);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -3461,6 +3622,103 @@ fn install_skill_into(
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn uninstall_skill(target: &str) -> std::io::Result<SkillUninstallOutcome> {
|
||||||
|
let registry_root = default_skill_install_root()?;
|
||||||
|
let requested = sanitize_skill_invocation_name(target).unwrap_or_else(|| {
|
||||||
|
target
|
||||||
|
.trim()
|
||||||
|
.trim_start_matches('/')
|
||||||
|
.trim_start_matches('$')
|
||||||
|
.to_ascii_lowercase()
|
||||||
|
});
|
||||||
|
let available_names = installed_skill_names(®istry_root)?;
|
||||||
|
let matched_name = available_names
|
||||||
|
.iter()
|
||||||
|
.find(|name| name.eq_ignore_ascii_case(&requested))
|
||||||
|
.cloned();
|
||||||
|
|
||||||
|
let Some(invocation_name) = matched_name else {
|
||||||
|
return Ok(SkillUninstallOutcome::Missing {
|
||||||
|
requested,
|
||||||
|
registry_root,
|
||||||
|
available_names,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
|
let removed_path = registry_root.join(&invocation_name);
|
||||||
|
if removed_path.is_dir() {
|
||||||
|
fs::remove_dir_all(&removed_path)?;
|
||||||
|
} else {
|
||||||
|
fs::remove_file(&removed_path)?;
|
||||||
|
}
|
||||||
|
let available_names = available_names
|
||||||
|
.into_iter()
|
||||||
|
.filter(|name| !name.eq_ignore_ascii_case(&invocation_name))
|
||||||
|
.collect();
|
||||||
|
|
||||||
|
Ok(SkillUninstallOutcome::Removed(UninstalledSkill {
|
||||||
|
invocation_name,
|
||||||
|
registry_root,
|
||||||
|
removed_path,
|
||||||
|
available_names,
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn installed_skill_names(registry_root: &Path) -> std::io::Result<Vec<String>> {
|
||||||
|
let entries = match fs::read_dir(registry_root) {
|
||||||
|
Ok(entries) => entries,
|
||||||
|
Err(error) if error.kind() == std::io::ErrorKind::NotFound => return Ok(Vec::new()),
|
||||||
|
Err(error) => return Err(error),
|
||||||
|
};
|
||||||
|
let mut names = Vec::new();
|
||||||
|
for entry in entries {
|
||||||
|
let entry = entry?;
|
||||||
|
let path = entry.path();
|
||||||
|
if path.is_dir() && path.join("SKILL.md").is_file() {
|
||||||
|
names.push(entry.file_name().to_string_lossy().to_string());
|
||||||
|
} else if path
|
||||||
|
.extension()
|
||||||
|
.is_some_and(|extension| extension.to_string_lossy().eq_ignore_ascii_case("md"))
|
||||||
|
{
|
||||||
|
if let Some(stem) = path.file_stem() {
|
||||||
|
names.push(stem.to_string_lossy().to_string());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
names.sort();
|
||||||
|
Ok(names)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn create_agent(name: &str, cwd: &Path) -> std::io::Result<CreatedAgent> {
|
||||||
|
let Some(name) = sanitize_skill_invocation_name(name) else {
|
||||||
|
return Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::InvalidInput,
|
||||||
|
"invalid_agent_name: agent name must contain at least one alphanumeric character",
|
||||||
|
));
|
||||||
|
};
|
||||||
|
let root = cwd.join(".claw").join("agents");
|
||||||
|
let path = root.join(format!("{name}.toml"));
|
||||||
|
if path.exists() {
|
||||||
|
return Err(std::io::Error::new(
|
||||||
|
std::io::ErrorKind::AlreadyExists,
|
||||||
|
format!(
|
||||||
|
"agent_already_exists: agent '{name}' already exists at {}",
|
||||||
|
path.display()
|
||||||
|
),
|
||||||
|
));
|
||||||
|
}
|
||||||
|
|
||||||
|
fs::create_dir_all(&root)?;
|
||||||
|
fs::write(
|
||||||
|
&path,
|
||||||
|
format!(
|
||||||
|
"name = \"{name}\"\ndescription = \"Describe when to use this agent.\"\nmodel_reasoning_effort = \"medium\"\n"
|
||||||
|
),
|
||||||
|
)?;
|
||||||
|
|
||||||
|
Ok(CreatedAgent { name, path })
|
||||||
|
}
|
||||||
|
|
||||||
fn default_skill_install_root() -> std::io::Result<PathBuf> {
|
fn default_skill_install_root() -> std::io::Result<PathBuf> {
|
||||||
if let Ok(claw_config_home) = env::var("CLAW_CONFIG_HOME") {
|
if let Ok(claw_config_home) = env::var("CLAW_CONFIG_HOME") {
|
||||||
return Ok(PathBuf::from(claw_config_home).join("skills"));
|
return Ok(PathBuf::from(claw_config_home).join("skills"));
|
||||||
@@ -3902,6 +4160,59 @@ fn render_agents_report_json_with_action(
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn render_agents_missing_argument_json(action: &str, argument: &str) -> Value {
|
||||||
|
json!({
|
||||||
|
"kind": "agents",
|
||||||
|
"action": action,
|
||||||
|
"status": "error",
|
||||||
|
"error_kind": "missing_argument",
|
||||||
|
"argument": argument,
|
||||||
|
"hint": "Usage: claw agents create <name>",
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_agent_create_report(agent: &CreatedAgent) -> String {
|
||||||
|
format!(
|
||||||
|
"Agents\n Result created {}\n Path {}\n Format TOML",
|
||||||
|
agent.name,
|
||||||
|
agent.path.display()
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_agent_create_report_json(agent: &CreatedAgent) -> Value {
|
||||||
|
json!({
|
||||||
|
"kind": "agents",
|
||||||
|
"status": "ok",
|
||||||
|
"action": "create",
|
||||||
|
"result": "created",
|
||||||
|
"name": &agent.name,
|
||||||
|
"path": agent.path.display().to_string(),
|
||||||
|
"format": "toml",
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_agent_create_error_json(name: &str, error: &std::io::Error) -> Value {
|
||||||
|
let message = error.to_string();
|
||||||
|
let error_kind = if message.starts_with("invalid_agent_name:") {
|
||||||
|
"invalid_agent_name"
|
||||||
|
} else if message.starts_with("agent_already_exists:")
|
||||||
|
|| error.kind() == std::io::ErrorKind::AlreadyExists
|
||||||
|
{
|
||||||
|
"agent_already_exists"
|
||||||
|
} else {
|
||||||
|
"agent_create_failed"
|
||||||
|
};
|
||||||
|
json!({
|
||||||
|
"kind": "agents",
|
||||||
|
"status": "error",
|
||||||
|
"action": "create",
|
||||||
|
"error_kind": error_kind,
|
||||||
|
"name": name,
|
||||||
|
"message": message,
|
||||||
|
"hint": "Use `claw agents create <name>` with a simple alphanumeric, dash, underscore, or dot name.",
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
fn agent_detail(agent: &AgentSummary) -> String {
|
fn agent_detail(agent: &AgentSummary) -> String {
|
||||||
let mut parts = vec![agent.name.clone()];
|
let mut parts = vec![agent.name.clone()];
|
||||||
if let Some(description) = &agent.description {
|
if let Some(description) = &agent.description {
|
||||||
@@ -4019,6 +4330,102 @@ fn render_skill_install_report_json(skill: &InstalledSkill) -> Value {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn render_skills_missing_argument_json(action: &str, argument: &str, hint: &str) -> Value {
|
||||||
|
json!({
|
||||||
|
"kind": "skills",
|
||||||
|
"action": action,
|
||||||
|
"status": "error",
|
||||||
|
"error_kind": "missing_argument",
|
||||||
|
"argument": argument,
|
||||||
|
"hint": hint,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_skill_install_error_json(target: &str, error: &std::io::Error) -> Value {
|
||||||
|
let source_kind = skill_install_source_kind(target);
|
||||||
|
json!({
|
||||||
|
"kind": "skills",
|
||||||
|
"action": "install",
|
||||||
|
"status": "error",
|
||||||
|
"error_kind": "invalid_install_source",
|
||||||
|
"source": target,
|
||||||
|
"source_kind": source_kind,
|
||||||
|
"reason": io_error_reason(error),
|
||||||
|
"message": format!("invalid install source: {error}"),
|
||||||
|
"hint": match source_kind {
|
||||||
|
"url" => "Remote skill install is not supported yet; pass a local directory containing SKILL.md or a markdown file.",
|
||||||
|
"name" => "Skill install expects a local path, not a registry name. Pass a directory containing SKILL.md or a markdown file.",
|
||||||
|
_ => "Check that the path exists and is a directory containing SKILL.md or a markdown file.",
|
||||||
|
},
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_skill_uninstall_report(skill: &UninstalledSkill) -> String {
|
||||||
|
format!(
|
||||||
|
"Skills\n Result uninstalled {}\n Registry {}\n Removed path {}\n Remaining {}",
|
||||||
|
skill.invocation_name,
|
||||||
|
skill.registry_root.display(),
|
||||||
|
skill.removed_path.display(),
|
||||||
|
format_optional_list(&skill.available_names)
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_skill_uninstall_report_json(skill: &UninstalledSkill) -> Value {
|
||||||
|
json!({
|
||||||
|
"kind": "skills",
|
||||||
|
"status": "ok",
|
||||||
|
"action": "uninstall",
|
||||||
|
"result": "removed",
|
||||||
|
"removed": &skill.invocation_name,
|
||||||
|
"skills_dir": skill.registry_root.display().to_string(),
|
||||||
|
"removed_path": skill.removed_path.display().to_string(),
|
||||||
|
"available_names": &skill.available_names,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_skill_uninstall_missing_json(
|
||||||
|
requested: &str,
|
||||||
|
registry_root: &Path,
|
||||||
|
available_names: &[String],
|
||||||
|
) -> Value {
|
||||||
|
json!({
|
||||||
|
"kind": "skills",
|
||||||
|
"status": "error",
|
||||||
|
"action": "uninstall",
|
||||||
|
"error_kind": "skill_not_found",
|
||||||
|
"requested": requested,
|
||||||
|
"skills_dir": registry_root.display().to_string(),
|
||||||
|
"available_names": available_names,
|
||||||
|
"message": format!("skill '{requested}' not found"),
|
||||||
|
"hint": "Run `claw skills list` to see available skills.",
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn skill_install_source_kind(source: &str) -> &'static str {
|
||||||
|
let trimmed = source.trim();
|
||||||
|
if trimmed.contains("://") {
|
||||||
|
"url"
|
||||||
|
} else if Path::new(trimmed).is_absolute()
|
||||||
|
|| trimmed.starts_with('.')
|
||||||
|
|| trimmed.contains('/')
|
||||||
|
|| trimmed.contains('\\')
|
||||||
|
{
|
||||||
|
"path"
|
||||||
|
} else {
|
||||||
|
"name"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn io_error_reason(error: &std::io::Error) -> &'static str {
|
||||||
|
match error.kind() {
|
||||||
|
std::io::ErrorKind::NotFound => "not_found",
|
||||||
|
std::io::ErrorKind::AlreadyExists => "already_exists",
|
||||||
|
std::io::ErrorKind::PermissionDenied => "permission_denied",
|
||||||
|
std::io::ErrorKind::InvalidInput => "invalid",
|
||||||
|
_ => "io_error",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
fn render_mcp_summary_report(
|
fn render_mcp_summary_report(
|
||||||
cwd: &Path,
|
cwd: &Path,
|
||||||
servers: &BTreeMap<String, ScopedMcpServerConfig>,
|
servers: &BTreeMap<String, ScopedMcpServerConfig>,
|
||||||
@@ -4188,8 +4595,10 @@ fn help_path_from_args(args: &str) -> Option<Vec<&str>> {
|
|||||||
fn render_agents_usage(unexpected: Option<&str>) -> String {
|
fn render_agents_usage(unexpected: Option<&str>) -> String {
|
||||||
let mut lines = vec![
|
let mut lines = vec![
|
||||||
"Agents".to_string(),
|
"Agents".to_string(),
|
||||||
" Usage /agents [list|help]".to_string(),
|
" Usage /agents [list|show <name>|create <name>|help]".to_string(),
|
||||||
" Direct CLI claw agents".to_string(),
|
" Direct CLI claw agents [list|show <name>|create <name>|help]".to_string(),
|
||||||
|
" Format TOML files (.toml); create scaffolds .claw/agents/<name>.toml"
|
||||||
|
.to_string(),
|
||||||
" Sources .claw/agents, ~/.claw/agents, $CLAW_CONFIG_HOME/agents".to_string(),
|
" Sources .claw/agents, ~/.claw/agents, $CLAW_CONFIG_HOME/agents".to_string(),
|
||||||
];
|
];
|
||||||
if let Some(args) = unexpected {
|
if let Some(args) = unexpected {
|
||||||
@@ -4205,8 +4614,10 @@ fn render_agents_usage_json(unexpected: Option<&str>) -> Value {
|
|||||||
"ok": unexpected.is_none(),
|
"ok": unexpected.is_none(),
|
||||||
"status": if unexpected.is_some() { "error" } else { "ok" },
|
"status": if unexpected.is_some() { "error" } else { "ok" },
|
||||||
"usage": {
|
"usage": {
|
||||||
"slash_command": "/agents [list|help]",
|
"slash_command": "/agents [list|show <name>|create <name>|help]",
|
||||||
"direct_cli": "claw agents [list|help]",
|
"direct_cli": "claw agents [list|show <name>|create <name>|help]",
|
||||||
|
"format": "toml",
|
||||||
|
"create": "claw agents create <name>",
|
||||||
"sources": [".claw/agents", "~/.claw/agents", "$CLAW_CONFIG_HOME/agents"],
|
"sources": [".claw/agents", "~/.claw/agents", "$CLAW_CONFIG_HOME/agents"],
|
||||||
},
|
},
|
||||||
"unexpected": unexpected,
|
"unexpected": unexpected,
|
||||||
@@ -4216,9 +4627,10 @@ fn render_agents_usage_json(unexpected: Option<&str>) -> Value {
|
|||||||
fn render_skills_usage(unexpected: Option<&str>) -> String {
|
fn render_skills_usage(unexpected: Option<&str>) -> String {
|
||||||
let mut lines = vec![
|
let mut lines = vec![
|
||||||
"Skills".to_string(),
|
"Skills".to_string(),
|
||||||
" Usage /skills [list|install <path>|help|<skill> [args]]".to_string(),
|
" Usage /skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]".to_string(),
|
||||||
" Alias /skill".to_string(),
|
" Alias /skill".to_string(),
|
||||||
" Direct CLI claw skills [list|install <path>|help|<skill> [args]]".to_string(),
|
" Direct CLI claw skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]".to_string(),
|
||||||
|
" Lifecycle install <path>, uninstall <name>".to_string(),
|
||||||
" Invoke /skills help overview -> $help overview".to_string(),
|
" Invoke /skills help overview -> $help overview".to_string(),
|
||||||
" Install root $CLAW_CONFIG_HOME/skills or ~/.claw/skills".to_string(),
|
" Install root $CLAW_CONFIG_HOME/skills or ~/.claw/skills".to_string(),
|
||||||
" Sources .claw/skills, .omc/skills, .agents/skills, .codex/skills, .claude/skills, ~/.claw/skills, ~/.omc/skills, ~/.claude/skills/omc-learned, ~/.codex/skills, ~/.claude/skills, legacy /commands".to_string(),
|
" Sources .claw/skills, .omc/skills, .agents/skills, .codex/skills, .claude/skills, ~/.claw/skills, ~/.omc/skills, ~/.claude/skills/omc-learned, ~/.codex/skills, ~/.claude/skills, legacy /commands".to_string(),
|
||||||
@@ -4236,9 +4648,10 @@ fn render_skills_usage_json(unexpected: Option<&str>) -> Value {
|
|||||||
"ok": unexpected.is_none(),
|
"ok": unexpected.is_none(),
|
||||||
"status": if unexpected.is_some() { "error" } else { "ok" },
|
"status": if unexpected.is_some() { "error" } else { "ok" },
|
||||||
"usage": {
|
"usage": {
|
||||||
"slash_command": "/skills [list|install <path>|help|<skill> [args]]",
|
"slash_command": "/skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]",
|
||||||
"aliases": ["/skill"],
|
"aliases": ["/skill"],
|
||||||
"direct_cli": "claw skills [list|install <path>|help|<skill> [args]]",
|
"direct_cli": "claw skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]",
|
||||||
|
"lifecycle": ["install <path>", "uninstall <name>"],
|
||||||
"invoke": "/skills help overview -> $help overview",
|
"invoke": "/skills help overview -> $help overview",
|
||||||
"install_root": "$CLAW_CONFIG_HOME/skills or ~/.claw/skills",
|
"install_root": "$CLAW_CONFIG_HOME/skills or ~/.claw/skills",
|
||||||
"sources": [
|
"sources": [
|
||||||
@@ -5113,16 +5526,17 @@ mod tests {
|
|||||||
#[test]
|
#[test]
|
||||||
fn rejects_invalid_agents_arguments() {
|
fn rejects_invalid_agents_arguments() {
|
||||||
// given
|
// given
|
||||||
let agents_input = "/agents show planner";
|
let agents_input = "/agents frobnicate";
|
||||||
|
|
||||||
// when
|
// when
|
||||||
let agents_error = parse_error_message(agents_input);
|
let agents_error = parse_error_message(agents_input);
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert!(agents_error.contains(
|
assert!(agents_error.contains(
|
||||||
"Unexpected arguments for /agents: show planner. Use /agents, /agents list, or /agents help."
|
"Unexpected arguments for /agents: frobnicate. Use /agents, /agents list, /agents show <name>, /agents create <name>, or /agents help."
|
||||||
));
|
));
|
||||||
assert!(agents_error.contains(" Usage /agents [list|help]"));
|
assert!(agents_error
|
||||||
|
.contains(" Usage /agents [list|show <name>|create <name>|help]"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -5144,6 +5558,13 @@ mod tests {
|
|||||||
"`skills {arg}` must be Local, not Invoke"
|
"`skills {arg}` must be Local, not Invoke"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
for arg in ["uninstall", "uninstall plan", "remove plan", "delete plan"] {
|
||||||
|
assert_eq!(
|
||||||
|
classify_skills_slash_command(Some(arg)),
|
||||||
|
SkillSlashDispatch::Local,
|
||||||
|
"`skills {arg}` must be Local, not Invoke"
|
||||||
|
);
|
||||||
|
}
|
||||||
// Bare invocable tokens still dispatch to Invoke.
|
// Bare invocable tokens still dispatch to Invoke.
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
classify_skills_slash_command(Some("plan")),
|
classify_skills_slash_command(Some("plan")),
|
||||||
@@ -5171,6 +5592,10 @@ mod tests {
|
|||||||
classify_skills_slash_command(Some("install ./skill-pack")),
|
classify_skills_slash_command(Some("install ./skill-pack")),
|
||||||
SkillSlashDispatch::Local
|
SkillSlashDispatch::Local
|
||||||
);
|
);
|
||||||
|
assert_eq!(
|
||||||
|
classify_skills_slash_command(Some("uninstall help")),
|
||||||
|
SkillSlashDispatch::Local
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -5263,8 +5688,10 @@ mod tests {
|
|||||||
"/plugin [list|install <path>|enable <name>|disable <name>|uninstall <id>|update <id>]"
|
"/plugin [list|install <path>|enable <name>|disable <name>|uninstall <id>|update <id>]"
|
||||||
));
|
));
|
||||||
assert!(help.contains("aliases: /plugins, /marketplace"));
|
assert!(help.contains("aliases: /plugins, /marketplace"));
|
||||||
assert!(help.contains("/agents [list|help]"));
|
assert!(help.contains("/agents [list|show <name>|create <name>|help]"));
|
||||||
assert!(help.contains("/skills [list|install <path>|help|<skill> [args]]"));
|
assert!(help.contains(
|
||||||
|
"/skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]"
|
||||||
|
));
|
||||||
assert!(help.contains("aliases: /skill"));
|
assert!(help.contains("aliases: /skill"));
|
||||||
assert!(!help.contains("/login"));
|
assert!(!help.contains("/login"));
|
||||||
assert!(!help.contains("/logout"));
|
assert!(!help.contains("/logout"));
|
||||||
@@ -5609,10 +6036,27 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn renders_agents_reports_as_json() {
|
fn renders_agents_reports_as_json() {
|
||||||
|
let _guard = env_guard();
|
||||||
let workspace = temp_dir("agents-json-workspace");
|
let workspace = temp_dir("agents-json-workspace");
|
||||||
let project_agents = workspace.join(".codex").join("agents");
|
let project_agents = workspace.join(".codex").join("agents");
|
||||||
let user_home = temp_dir("agents-json-home");
|
let user_home = temp_dir("agents-json-home");
|
||||||
let user_agents = user_home.join(".codex").join("agents");
|
let user_agents = user_home.join(".codex").join("agents");
|
||||||
|
let isolated_home = temp_dir("agents-json-isolated-home");
|
||||||
|
let config_home = temp_dir("agents-json-config-home");
|
||||||
|
let codex_home = temp_dir("agents-json-codex-home");
|
||||||
|
let claude_config = temp_dir("agents-json-claude-config");
|
||||||
|
fs::create_dir_all(&isolated_home).expect("isolated home");
|
||||||
|
fs::create_dir_all(&config_home).expect("config home");
|
||||||
|
fs::create_dir_all(&codex_home).expect("codex home");
|
||||||
|
fs::create_dir_all(&claude_config).expect("claude config");
|
||||||
|
let original_home = std::env::var_os("HOME");
|
||||||
|
let original_claw_config_home = std::env::var_os("CLAW_CONFIG_HOME");
|
||||||
|
let original_codex_home = std::env::var_os("CODEX_HOME");
|
||||||
|
let original_claude_config_dir = std::env::var_os("CLAUDE_CONFIG_DIR");
|
||||||
|
std::env::set_var("HOME", &isolated_home);
|
||||||
|
std::env::set_var("CLAW_CONFIG_HOME", &config_home);
|
||||||
|
std::env::set_var("CODEX_HOME", &codex_home);
|
||||||
|
std::env::set_var("CLAUDE_CONFIG_DIR", &claude_config);
|
||||||
|
|
||||||
write_agent(
|
write_agent(
|
||||||
&project_agents,
|
&project_agents,
|
||||||
@@ -5664,7 +6108,10 @@ mod tests {
|
|||||||
assert_eq!(help["kind"], "agents");
|
assert_eq!(help["kind"], "agents");
|
||||||
assert_eq!(help["action"], "help");
|
assert_eq!(help["action"], "help");
|
||||||
assert_eq!(help["status"], "ok");
|
assert_eq!(help["status"], "ok");
|
||||||
assert_eq!(help["usage"]["direct_cli"], "claw agents [list|help]");
|
assert_eq!(
|
||||||
|
help["usage"]["direct_cli"],
|
||||||
|
"claw agents [list|show <name>|create <name>|help]"
|
||||||
|
);
|
||||||
|
|
||||||
// `show <name>` is now valid. Known agent returns ok with matching entry.
|
// `show <name>` is now valid. Known agent returns ok with matching entry.
|
||||||
let show_planner = handle_agents_slash_command_json(Some("show planner"), &workspace)
|
let show_planner = handle_agents_slash_command_json(Some("show planner"), &workspace)
|
||||||
@@ -5686,6 +6133,14 @@ mod tests {
|
|||||||
|
|
||||||
let _ = fs::remove_dir_all(workspace);
|
let _ = fs::remove_dir_all(workspace);
|
||||||
let _ = fs::remove_dir_all(user_home);
|
let _ = fs::remove_dir_all(user_home);
|
||||||
|
restore_env_var("HOME", original_home);
|
||||||
|
restore_env_var("CLAW_CONFIG_HOME", original_claw_config_home);
|
||||||
|
restore_env_var("CODEX_HOME", original_codex_home);
|
||||||
|
restore_env_var("CLAUDE_CONFIG_DIR", original_claude_config_dir);
|
||||||
|
let _ = fs::remove_dir_all(isolated_home);
|
||||||
|
let _ = fs::remove_dir_all(config_home);
|
||||||
|
let _ = fs::remove_dir_all(codex_home);
|
||||||
|
let _ = fs::remove_dir_all(claude_config);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -5816,7 +6271,7 @@ mod tests {
|
|||||||
assert_eq!(help["usage"]["aliases"][0], "/skill");
|
assert_eq!(help["usage"]["aliases"][0], "/skill");
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
help["usage"]["direct_cli"],
|
help["usage"]["direct_cli"],
|
||||||
"claw skills [list|install <path>|help|<skill> [args]]"
|
"claw skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]"
|
||||||
);
|
);
|
||||||
|
|
||||||
let _ = fs::remove_dir_all(workspace);
|
let _ = fs::remove_dir_all(workspace);
|
||||||
@@ -5829,13 +6284,20 @@ mod tests {
|
|||||||
|
|
||||||
let agents_help =
|
let agents_help =
|
||||||
super::handle_agents_slash_command(Some("help"), &cwd).expect("agents help");
|
super::handle_agents_slash_command(Some("help"), &cwd).expect("agents help");
|
||||||
assert!(agents_help.contains("Usage /agents [list|help]"));
|
assert!(
|
||||||
assert!(agents_help.contains("Direct CLI claw agents"));
|
agents_help.contains("Usage /agents [list|show <name>|create <name>|help]")
|
||||||
|
);
|
||||||
|
assert!(agents_help
|
||||||
|
.contains("Direct CLI claw agents [list|show <name>|create <name>|help]"));
|
||||||
|
assert!(agents_help.contains(
|
||||||
|
"Format TOML files (.toml); create scaffolds .claw/agents/<name>.toml"
|
||||||
|
));
|
||||||
assert!(agents_help
|
assert!(agents_help
|
||||||
.contains("Sources .claw/agents, ~/.claw/agents, $CLAW_CONFIG_HOME/agents"));
|
.contains("Sources .claw/agents, ~/.claw/agents, $CLAW_CONFIG_HOME/agents"));
|
||||||
|
|
||||||
// `show <name>` is now valid. For an agent that doesn't exist it returns Err(NotFound).
|
// `show <name>` is now valid. For an agent that doesn't exist it returns Err(NotFound).
|
||||||
let agents_show_missing = super::handle_agents_slash_command(Some("show planner"), &cwd);
|
let agents_show_missing =
|
||||||
|
super::handle_agents_slash_command(Some("show definitely-missing-agent-431"), &cwd);
|
||||||
assert!(
|
assert!(
|
||||||
agents_show_missing.is_err(),
|
agents_show_missing.is_err(),
|
||||||
"show of a missing agent should Err"
|
"show of a missing agent should Err"
|
||||||
@@ -5854,9 +6316,11 @@ mod tests {
|
|||||||
|
|
||||||
let skills_help =
|
let skills_help =
|
||||||
super::handle_skills_slash_command(Some("--help"), &cwd).expect("skills help");
|
super::handle_skills_slash_command(Some("--help"), &cwd).expect("skills help");
|
||||||
assert!(skills_help
|
assert!(skills_help.contains(
|
||||||
.contains("Usage /skills [list|install <path>|help|<skill> [args]]"));
|
"Usage /skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]"
|
||||||
|
));
|
||||||
assert!(skills_help.contains("Alias /skill"));
|
assert!(skills_help.contains("Alias /skill"));
|
||||||
|
assert!(skills_help.contains("Lifecycle install <path>, uninstall <name>"));
|
||||||
assert!(skills_help.contains("Invoke /skills help overview -> $help overview"));
|
assert!(skills_help.contains("Invoke /skills help overview -> $help overview"));
|
||||||
assert!(skills_help.contains("Install root $CLAW_CONFIG_HOME/skills or ~/.claw/skills"));
|
assert!(skills_help.contains("Install root $CLAW_CONFIG_HOME/skills or ~/.claw/skills"));
|
||||||
assert!(skills_help.contains(".omc/skills"));
|
assert!(skills_help.contains(".omc/skills"));
|
||||||
@@ -5870,15 +6334,17 @@ mod tests {
|
|||||||
|
|
||||||
let skills_install_help = super::handle_skills_slash_command(Some("install --help"), &cwd)
|
let skills_install_help = super::handle_skills_slash_command(Some("install --help"), &cwd)
|
||||||
.expect("nested skills help");
|
.expect("nested skills help");
|
||||||
assert!(skills_install_help
|
assert!(skills_install_help.contains(
|
||||||
.contains("Usage /skills [list|install <path>|help|<skill> [args]]"));
|
"Usage /skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]"
|
||||||
|
));
|
||||||
assert!(skills_install_help.contains("Alias /skill"));
|
assert!(skills_install_help.contains("Alias /skill"));
|
||||||
assert!(skills_install_help.contains("Unexpected install"));
|
assert!(skills_install_help.contains("Unexpected install"));
|
||||||
|
|
||||||
let skills_unknown_help =
|
let skills_unknown_help =
|
||||||
super::handle_skills_slash_command(Some("show --help"), &cwd).expect("skills help");
|
super::handle_skills_slash_command(Some("show --help"), &cwd).expect("skills help");
|
||||||
assert!(skills_unknown_help
|
assert!(skills_unknown_help.contains(
|
||||||
.contains("Usage /skills [list|install <path>|help|<skill> [args]]"));
|
"Usage /skills [list|show <name>|install <path>|uninstall <name>|help|<skill> [args]]"
|
||||||
|
));
|
||||||
assert!(skills_unknown_help.contains("Unexpected show"));
|
assert!(skills_unknown_help.contains("Unexpected show"));
|
||||||
|
|
||||||
let skills_help_json =
|
let skills_help_json =
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -92,6 +92,7 @@ enum FieldType {
|
|||||||
Bool,
|
Bool,
|
||||||
Object,
|
Object,
|
||||||
StringArray,
|
StringArray,
|
||||||
|
HookArray,
|
||||||
RulesImport,
|
RulesImport,
|
||||||
Number,
|
Number,
|
||||||
}
|
}
|
||||||
@@ -104,6 +105,7 @@ impl FieldType {
|
|||||||
Self::Object => "an object",
|
Self::Object => "an object",
|
||||||
Self::StringArray => "an array of strings",
|
Self::StringArray => "an array of strings",
|
||||||
Self::RulesImport => "a string or an array of strings",
|
Self::RulesImport => "a string or an array of strings",
|
||||||
|
Self::HookArray => "an array of strings or hook objects",
|
||||||
Self::Number => "a number",
|
Self::Number => "a number",
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -116,6 +118,10 @@ impl FieldType {
|
|||||||
Self::StringArray => value
|
Self::StringArray => value
|
||||||
.as_array()
|
.as_array()
|
||||||
.is_some_and(|arr| arr.iter().all(|v| v.as_str().is_some())),
|
.is_some_and(|arr| arr.iter().all(|v| v.as_str().is_some())),
|
||||||
|
Self::HookArray => value.as_array().is_some_and(|arr| {
|
||||||
|
arr.iter()
|
||||||
|
.all(|entry| entry.as_str().is_some() || entry.as_object().is_some())
|
||||||
|
}),
|
||||||
Self::RulesImport => {
|
Self::RulesImport => {
|
||||||
value.as_str().is_some()
|
value.as_str().is_some()
|
||||||
|| value
|
|| value
|
||||||
@@ -218,15 +224,15 @@ const TOP_LEVEL_FIELDS: &[FieldSpec] = &[
|
|||||||
const HOOKS_FIELDS: &[FieldSpec] = &[
|
const HOOKS_FIELDS: &[FieldSpec] = &[
|
||||||
FieldSpec {
|
FieldSpec {
|
||||||
name: "PreToolUse",
|
name: "PreToolUse",
|
||||||
expected: FieldType::StringArray,
|
expected: FieldType::HookArray,
|
||||||
},
|
},
|
||||||
FieldSpec {
|
FieldSpec {
|
||||||
name: "PostToolUse",
|
name: "PostToolUse",
|
||||||
expected: FieldType::StringArray,
|
expected: FieldType::HookArray,
|
||||||
},
|
},
|
||||||
FieldSpec {
|
FieldSpec {
|
||||||
name: "PostToolUseFailure",
|
name: "PostToolUseFailure",
|
||||||
expected: FieldType::StringArray,
|
expected: FieldType::HookArray,
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
|
|
||||||
@@ -418,9 +424,10 @@ fn validate_object_keys(
|
|||||||
} else if DEPRECATED_FIELDS.iter().any(|d| d.name == key) {
|
} else if DEPRECATED_FIELDS.iter().any(|d| d.name == key) {
|
||||||
// Deprecated key — handled separately, not an unknown-key error.
|
// Deprecated key — handled separately, not an unknown-key error.
|
||||||
} else {
|
} else {
|
||||||
// Unknown key.
|
// Unknown key — preserve compatibility by surfacing it as a warning
|
||||||
|
// instead of blocking otherwise valid config files.
|
||||||
let suggestion = suggest_field(key, &known_names);
|
let suggestion = suggest_field(key, &known_names);
|
||||||
result.errors.push(ConfigDiagnostic {
|
result.warnings.push(ConfigDiagnostic {
|
||||||
path: path_display.to_string(),
|
path: path_display.to_string(),
|
||||||
field: field_path,
|
field: field_path,
|
||||||
line: find_key_line(source, key),
|
line: find_key_line(source, key),
|
||||||
@@ -599,10 +606,11 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
assert_eq!(result.errors[0].field, "unknownField");
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
assert_eq!(result.warnings[0].field, "unknownField");
|
||||||
assert!(matches!(
|
assert!(matches!(
|
||||||
result.errors[0].kind,
|
result.warnings[0].kind,
|
||||||
DiagnosticKind::UnknownKey { .. }
|
DiagnosticKind::UnknownKey { .. }
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
@@ -682,9 +690,10 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
assert_eq!(result.errors[0].line, Some(3));
|
assert_eq!(result.warnings.len(), 1);
|
||||||
assert_eq!(result.errors[0].field, "badKey");
|
assert_eq!(result.warnings[0].line, Some(3));
|
||||||
|
assert_eq!(result.warnings[0].field, "badKey");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -713,8 +722,32 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
|
assert!(result.errors.is_empty());
|
||||||
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
assert_eq!(result.warnings[0].field, "hooks.BadHook");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn validates_object_style_hook_entries() {
|
||||||
|
let source = r#"{"hooks":{"PreToolUse":["legacy",{"matcher":"Bash","hooks":[{"type":"command","command":"echo ok"}]}]}}"#;
|
||||||
|
let parsed = JsonValue::parse(source).expect("valid json");
|
||||||
|
let object = parsed.as_object().expect("object");
|
||||||
|
|
||||||
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
|
assert!(result.errors.is_empty(), "{:?}", result.errors);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn rejects_wrong_hook_entry_types() {
|
||||||
|
let source = r#"{"hooks":{"PreToolUse":[42]}}"#;
|
||||||
|
let parsed = JsonValue::parse(source).expect("valid json");
|
||||||
|
let object = parsed.as_object().expect("object");
|
||||||
|
|
||||||
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert_eq!(result.errors.len(), 1);
|
||||||
assert_eq!(result.errors[0].field, "hooks.BadHook");
|
assert_eq!(result.errors[0].field, "hooks.PreToolUse");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -756,8 +789,9 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
assert_eq!(result.errors[0].field, "permissions.denyAll");
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
assert_eq!(result.warnings[0].field, "permissions.denyAll");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -771,8 +805,9 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
assert_eq!(result.errors[0].field, "sandbox.containerMode");
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
assert_eq!(result.warnings[0].field, "sandbox.containerMode");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -786,8 +821,9 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
assert_eq!(result.errors[0].field, "plugins.autoUpdate");
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
assert_eq!(result.warnings[0].field, "plugins.autoUpdate");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -801,8 +837,9 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
assert_eq!(result.errors[0].field, "oauth.secret");
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
assert_eq!(result.warnings[0].field, "oauth.secret");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -837,8 +874,9 @@ mod tests {
|
|||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assert_eq!(result.errors.len(), 1);
|
assert!(result.errors.is_empty());
|
||||||
match &result.errors[0].kind {
|
assert_eq!(result.warnings.len(), 1);
|
||||||
|
match &result.warnings[0].kind {
|
||||||
DiagnosticKind::UnknownKey {
|
DiagnosticKind::UnknownKey {
|
||||||
suggestion: Some(s),
|
suggestion: Some(s),
|
||||||
} => assert_eq!(s, "model"),
|
} => assert_eq!(s, "model"),
|
||||||
@@ -849,7 +887,7 @@ mod tests {
|
|||||||
#[test]
|
#[test]
|
||||||
fn format_diagnostics_includes_all_entries() {
|
fn format_diagnostics_includes_all_entries() {
|
||||||
// given
|
// given
|
||||||
let source = r#"{"permissionMode": "plan", "badKey": 1}"#;
|
let source = r#"{"model": 42, "badKey": 1}"#;
|
||||||
let parsed = JsonValue::parse(source).expect("valid json");
|
let parsed = JsonValue::parse(source).expect("valid json");
|
||||||
let object = parsed.as_object().expect("object");
|
let object = parsed.as_object().expect("object");
|
||||||
let result = validate_config_file(object, source, &test_path());
|
let result = validate_config_file(object, source, &test_path());
|
||||||
@@ -861,7 +899,7 @@ mod tests {
|
|||||||
assert!(output.contains("warning:"));
|
assert!(output.contains("warning:"));
|
||||||
assert!(output.contains("error:"));
|
assert!(output.contains("error:"));
|
||||||
assert!(output.contains("badKey"));
|
assert!(output.contains("badKey"));
|
||||||
assert!(output.contains("permissionMode"));
|
assert!(output.contains("model"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ use std::time::Duration;
|
|||||||
|
|
||||||
use serde_json::{json, Value};
|
use serde_json::{json, Value};
|
||||||
|
|
||||||
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookCommand, RuntimeHookConfig};
|
||||||
use crate::permissions::PermissionOverride;
|
use crate::permissions::PermissionOverride;
|
||||||
|
|
||||||
const HOOK_PREVIEW_CHAR_LIMIT: usize = 160;
|
const HOOK_PREVIEW_CHAR_LIMIT: usize = 160;
|
||||||
@@ -182,7 +182,7 @@ impl HookRunner {
|
|||||||
) -> HookRunResult {
|
) -> HookRunResult {
|
||||||
Self::run_commands(
|
Self::run_commands(
|
||||||
HookEvent::PreToolUse,
|
HookEvent::PreToolUse,
|
||||||
self.config.pre_tool_use(),
|
self.config.pre_tool_use_entries(),
|
||||||
tool_name,
|
tool_name,
|
||||||
tool_input,
|
tool_input,
|
||||||
None,
|
None,
|
||||||
@@ -232,7 +232,7 @@ impl HookRunner {
|
|||||||
) -> HookRunResult {
|
) -> HookRunResult {
|
||||||
Self::run_commands(
|
Self::run_commands(
|
||||||
HookEvent::PostToolUse,
|
HookEvent::PostToolUse,
|
||||||
self.config.post_tool_use(),
|
self.config.post_tool_use_entries(),
|
||||||
tool_name,
|
tool_name,
|
||||||
tool_input,
|
tool_input,
|
||||||
Some(tool_output),
|
Some(tool_output),
|
||||||
@@ -282,7 +282,7 @@ impl HookRunner {
|
|||||||
) -> HookRunResult {
|
) -> HookRunResult {
|
||||||
Self::run_commands(
|
Self::run_commands(
|
||||||
HookEvent::PostToolUseFailure,
|
HookEvent::PostToolUseFailure,
|
||||||
self.config.post_tool_use_failure(),
|
self.config.post_tool_use_failure_entries(),
|
||||||
tool_name,
|
tool_name,
|
||||||
tool_input,
|
tool_input,
|
||||||
Some(tool_error),
|
Some(tool_error),
|
||||||
@@ -312,7 +312,7 @@ impl HookRunner {
|
|||||||
#[allow(clippy::too_many_arguments)]
|
#[allow(clippy::too_many_arguments)]
|
||||||
fn run_commands(
|
fn run_commands(
|
||||||
event: HookEvent,
|
event: HookEvent,
|
||||||
commands: &[String],
|
commands: &[RuntimeHookCommand],
|
||||||
tool_name: &str,
|
tool_name: &str,
|
||||||
tool_input: &str,
|
tool_input: &str,
|
||||||
tool_output: Option<&str>,
|
tool_output: Option<&str>,
|
||||||
@@ -342,17 +342,21 @@ impl HookRunner {
|
|||||||
let payload = hook_payload(event, tool_name, tool_input, tool_output, is_error).to_string();
|
let payload = hook_payload(event, tool_name, tool_input, tool_output, is_error).to_string();
|
||||||
let mut result = HookRunResult::allow(Vec::new());
|
let mut result = HookRunResult::allow(Vec::new());
|
||||||
|
|
||||||
for command in commands {
|
for command in commands
|
||||||
|
.iter()
|
||||||
|
.filter(|command| command.matches_tool(tool_name))
|
||||||
|
{
|
||||||
|
let command_text = command.command();
|
||||||
if let Some(reporter) = reporter.as_deref_mut() {
|
if let Some(reporter) = reporter.as_deref_mut() {
|
||||||
reporter.on_event(&HookProgressEvent::Started {
|
reporter.on_event(&HookProgressEvent::Started {
|
||||||
event,
|
event,
|
||||||
tool_name: tool_name.to_string(),
|
tool_name: tool_name.to_string(),
|
||||||
command: command.clone(),
|
command: command_text.to_string(),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
match Self::run_command(
|
match Self::run_command(
|
||||||
command,
|
command_text,
|
||||||
event,
|
event,
|
||||||
tool_name,
|
tool_name,
|
||||||
tool_input,
|
tool_input,
|
||||||
@@ -366,7 +370,7 @@ impl HookRunner {
|
|||||||
reporter.on_event(&HookProgressEvent::Completed {
|
reporter.on_event(&HookProgressEvent::Completed {
|
||||||
event,
|
event,
|
||||||
tool_name: tool_name.to_string(),
|
tool_name: tool_name.to_string(),
|
||||||
command: command.clone(),
|
command: command_text.to_string(),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
merge_parsed_hook_output(&mut result, parsed);
|
merge_parsed_hook_output(&mut result, parsed);
|
||||||
@@ -376,7 +380,7 @@ impl HookRunner {
|
|||||||
reporter.on_event(&HookProgressEvent::Completed {
|
reporter.on_event(&HookProgressEvent::Completed {
|
||||||
event,
|
event,
|
||||||
tool_name: tool_name.to_string(),
|
tool_name: tool_name.to_string(),
|
||||||
command: command.clone(),
|
command: command_text.to_string(),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
merge_parsed_hook_output(&mut result, parsed);
|
merge_parsed_hook_output(&mut result, parsed);
|
||||||
@@ -388,7 +392,7 @@ impl HookRunner {
|
|||||||
reporter.on_event(&HookProgressEvent::Completed {
|
reporter.on_event(&HookProgressEvent::Completed {
|
||||||
event,
|
event,
|
||||||
tool_name: tool_name.to_string(),
|
tool_name: tool_name.to_string(),
|
||||||
command: command.clone(),
|
command: command_text.to_string(),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
merge_parsed_hook_output(&mut result, parsed);
|
merge_parsed_hook_output(&mut result, parsed);
|
||||||
@@ -400,7 +404,7 @@ impl HookRunner {
|
|||||||
reporter.on_event(&HookProgressEvent::Cancelled {
|
reporter.on_event(&HookProgressEvent::Cancelled {
|
||||||
event,
|
event,
|
||||||
tool_name: tool_name.to_string(),
|
tool_name: tool_name.to_string(),
|
||||||
command: command.clone(),
|
command: command_text.to_string(),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
result.cancelled = true;
|
result.cancelled = true;
|
||||||
@@ -825,7 +829,7 @@ mod tests {
|
|||||||
HookAbortSignal, HookEvent, HookProgressEvent, HookProgressReporter, HookRunResult,
|
HookAbortSignal, HookEvent, HookProgressEvent, HookProgressReporter, HookRunResult,
|
||||||
HookRunner,
|
HookRunner,
|
||||||
};
|
};
|
||||||
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookCommand, RuntimeHookConfig};
|
||||||
use crate::permissions::PermissionOverride;
|
use crate::permissions::PermissionOverride;
|
||||||
|
|
||||||
struct RecordingReporter {
|
struct RecordingReporter {
|
||||||
@@ -851,6 +855,37 @@ mod tests {
|
|||||||
assert_eq!(result, HookRunResult::allow(vec!["pre ok".to_string()]));
|
assert_eq!(result, HookRunResult::allow(vec!["pre ok".to_string()]));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn object_style_hook_matchers_filter_runtime_execution() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::from_hook_commands(
|
||||||
|
vec![
|
||||||
|
RuntimeHookCommand::new(shell_snippet("printf 'legacy'")),
|
||||||
|
RuntimeHookCommand::with_matcher(
|
||||||
|
shell_snippet("printf 'bash only'"),
|
||||||
|
Some("Bash".to_string()),
|
||||||
|
),
|
||||||
|
RuntimeHookCommand::with_matcher(
|
||||||
|
shell_snippet("printf 'read only'"),
|
||||||
|
Some("Read*".to_string()),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
|
||||||
|
let read_result = runner.run_pre_tool_use("ReadFile", r#"{"path":"README.md"}"#);
|
||||||
|
let bash_result = runner.run_pre_tool_use("Bash", r#"{"command":"pwd"}"#);
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
read_result,
|
||||||
|
HookRunResult::allow(vec!["legacy".to_string(), "read only".to_string()])
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
bash_result,
|
||||||
|
HookRunResult::allow(vec!["legacy".to_string(), "bash only".to_string()])
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn denies_exit_code_two() {
|
fn denies_exit_code_two() {
|
||||||
let runner = HookRunner::new(RuntimeHookConfig::new(
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
|||||||
@@ -65,13 +65,13 @@ pub use compact::{
|
|||||||
get_compact_continuation_message, should_compact, CompactionConfig, CompactionResult,
|
get_compact_continuation_message, should_compact, CompactionConfig, CompactionResult,
|
||||||
};
|
};
|
||||||
pub use config::{
|
pub use config::{
|
||||||
suppress_config_warnings_for_json_mode, ConfigEntry, ConfigError, ConfigLoader, ConfigSource,
|
suppress_config_warnings_for_json_mode, ConfigEntry, ConfigError, ConfigFileReport,
|
||||||
McpConfigCollection, McpManagedProxyServerConfig, McpOAuthConfig, McpRemoteServerConfig,
|
ConfigFileStatus, ConfigInspection, ConfigLoader, ConfigSource, McpConfigCollection,
|
||||||
McpSdkServerConfig, McpServerConfig, McpStdioServerConfig, McpTransport,
|
McpManagedProxyServerConfig, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
||||||
McpWebSocketServerConfig, OAuthConfig, ProviderFallbackConfig, ResolvedPermissionMode,
|
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
||||||
RulesImportConfig, RuntimeConfig, RuntimeFeatureConfig, RuntimeHookConfig,
|
ProviderFallbackConfig, ResolvedPermissionMode, RulesImportConfig, RuntimeConfig,
|
||||||
RuntimePermissionRuleConfig, RuntimePluginConfig, ScopedMcpServerConfig,
|
RuntimeFeatureConfig, RuntimeHookCommand, RuntimeHookConfig, RuntimePermissionRuleConfig,
|
||||||
CLAW_SETTINGS_SCHEMA_NAME,
|
RuntimePluginConfig, ScopedMcpServerConfig, CLAW_SETTINGS_SCHEMA_NAME,
|
||||||
};
|
};
|
||||||
pub use config_validate::{
|
pub use config_validate::{
|
||||||
check_unsupported_format, format_diagnostics, validate_config_file, ConfigDiagnostic,
|
check_unsupported_format, format_diagnostics, validate_config_file, ConfigDiagnostic,
|
||||||
|
|||||||
@@ -12,7 +12,6 @@ path = "src/main.rs"
|
|||||||
[dependencies]
|
[dependencies]
|
||||||
api = { path = "../api" }
|
api = { path = "../api" }
|
||||||
commands = { path = "../commands" }
|
commands = { path = "../commands" }
|
||||||
compat-harness = { path = "../compat-harness" }
|
|
||||||
crossterm = "0.28"
|
crossterm = "0.28"
|
||||||
pulldown-cmark = "0.13"
|
pulldown-cmark = "0.13"
|
||||||
rustyline = "15"
|
rustyline = "15"
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -1,6 +1,7 @@
|
|||||||
#![allow(clippy::while_let_on_iterator)]
|
#![allow(clippy::while_let_on_iterator)]
|
||||||
|
|
||||||
use std::fs;
|
use std::fs;
|
||||||
|
use std::io::Write;
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
use std::process::{Command, Output, Stdio};
|
use std::process::{Command, Output, Stdio};
|
||||||
use std::sync::atomic::{AtomicU64, Ordering};
|
use std::sync::atomic::{AtomicU64, Ordering};
|
||||||
@@ -245,6 +246,119 @@ stderr:
|
|||||||
fs::remove_dir_all(&workspace).expect("workspace cleanup should succeed");
|
fs::remove_dir_all(&workspace).expect("workspace cleanup should succeed");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn prompt_subcommand_reads_prompt_from_stdin_when_no_positional_arg_423() {
|
||||||
|
let runtime = tokio::runtime::Runtime::new().expect("tokio runtime should build");
|
||||||
|
let server = runtime
|
||||||
|
.block_on(MockAnthropicService::spawn())
|
||||||
|
.expect("mock service should start");
|
||||||
|
let base_url = server.base_url();
|
||||||
|
|
||||||
|
let workspace = unique_temp_dir("prompt-stdin-423");
|
||||||
|
let config_home = workspace.join("config-home");
|
||||||
|
let home = workspace.join("home");
|
||||||
|
fs::create_dir_all(&workspace).expect("workspace should exist");
|
||||||
|
fs::create_dir_all(&config_home).expect("config home should exist");
|
||||||
|
fs::create_dir_all(&home).expect("home should exist");
|
||||||
|
|
||||||
|
let prompt = format!("{SCENARIO_PREFIX}streaming_text\n");
|
||||||
|
let output = run_claw_with_stdin(
|
||||||
|
&workspace,
|
||||||
|
&config_home,
|
||||||
|
&home,
|
||||||
|
&base_url,
|
||||||
|
&[
|
||||||
|
"prompt",
|
||||||
|
"--output-format",
|
||||||
|
"json",
|
||||||
|
"--compact",
|
||||||
|
"--permission-mode",
|
||||||
|
"read-only",
|
||||||
|
"--model",
|
||||||
|
"sonnet",
|
||||||
|
],
|
||||||
|
&prompt,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert!(
|
||||||
|
output.status.success(),
|
||||||
|
"prompt stdin run should succeed\nstdout:\n{}\n\nstderr:\n{}",
|
||||||
|
String::from_utf8_lossy(&output.stdout),
|
||||||
|
String::from_utf8_lossy(&output.stderr),
|
||||||
|
);
|
||||||
|
let parsed: Value = serde_json::from_slice(&output.stdout).expect("stdout should parse");
|
||||||
|
assert_eq!(
|
||||||
|
parsed["message"],
|
||||||
|
"Mock streaming says hello from the parity harness."
|
||||||
|
);
|
||||||
|
let captured = runtime.block_on(server.captured_requests());
|
||||||
|
assert!(
|
||||||
|
captured
|
||||||
|
.iter()
|
||||||
|
.any(|request| request.raw_body.contains("PARITY_SCENARIO:streaming_text")),
|
||||||
|
"stdin prompt should reach the provider request: {captured:?}"
|
||||||
|
);
|
||||||
|
|
||||||
|
fs::remove_dir_all(&workspace).expect("workspace cleanup should succeed");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn prompt_subcommand_stdin_flag_appends_pipe_context_423() {
|
||||||
|
let runtime = tokio::runtime::Runtime::new().expect("tokio runtime should build");
|
||||||
|
let server = runtime
|
||||||
|
.block_on(MockAnthropicService::spawn())
|
||||||
|
.expect("mock service should start");
|
||||||
|
let base_url = server.base_url();
|
||||||
|
|
||||||
|
let workspace = unique_temp_dir("prompt-stdin-flag-423");
|
||||||
|
let config_home = workspace.join("config-home");
|
||||||
|
let home = workspace.join("home");
|
||||||
|
fs::create_dir_all(&workspace).expect("workspace should exist");
|
||||||
|
fs::create_dir_all(&config_home).expect("config home should exist");
|
||||||
|
fs::create_dir_all(&home).expect("home should exist");
|
||||||
|
|
||||||
|
let prompt_context = format!("{SCENARIO_PREFIX}streaming_text\n");
|
||||||
|
let output = run_claw_with_stdin(
|
||||||
|
&workspace,
|
||||||
|
&config_home,
|
||||||
|
&home,
|
||||||
|
&base_url,
|
||||||
|
&[
|
||||||
|
"prompt",
|
||||||
|
"Use stdin context",
|
||||||
|
"--stdin",
|
||||||
|
"--output-format",
|
||||||
|
"json",
|
||||||
|
"--compact",
|
||||||
|
"--permission-mode",
|
||||||
|
"read-only",
|
||||||
|
"--model",
|
||||||
|
"sonnet",
|
||||||
|
],
|
||||||
|
&prompt_context,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert!(
|
||||||
|
output.status.success(),
|
||||||
|
"prompt --stdin run should succeed\nstdout:\n{}\n\nstderr:\n{}",
|
||||||
|
String::from_utf8_lossy(&output.stdout),
|
||||||
|
String::from_utf8_lossy(&output.stderr),
|
||||||
|
);
|
||||||
|
let captured = runtime.block_on(server.captured_requests());
|
||||||
|
let provider_body = captured
|
||||||
|
.iter()
|
||||||
|
.find(|request| request.raw_body.contains("Use stdin context"))
|
||||||
|
.expect("merged prompt should reach provider");
|
||||||
|
assert!(
|
||||||
|
provider_body
|
||||||
|
.raw_body
|
||||||
|
.contains("PARITY_SCENARIO:streaming_text"),
|
||||||
|
"merged prompt should include stdin context: {provider_body:?}"
|
||||||
|
);
|
||||||
|
|
||||||
|
fs::remove_dir_all(&workspace).expect("workspace cleanup should succeed");
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn compact_subcommand_json_help_fails_fast_when_stdin_closed() {
|
fn compact_subcommand_json_help_fails_fast_when_stdin_closed() {
|
||||||
let workspace = unique_temp_dir("compact-nontty-json-help");
|
let workspace = unique_temp_dir("compact-nontty-json-help");
|
||||||
@@ -356,6 +470,39 @@ fn run_claw(
|
|||||||
command.output().expect("claw should launch")
|
command.output().expect("claw should launch")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn run_claw_with_stdin(
|
||||||
|
cwd: &std::path::Path,
|
||||||
|
config_home: &std::path::Path,
|
||||||
|
home: &std::path::Path,
|
||||||
|
base_url: &str,
|
||||||
|
args: &[&str],
|
||||||
|
stdin: &str,
|
||||||
|
) -> Output {
|
||||||
|
let mut child = Command::new(env!("CARGO_BIN_EXE_claw"))
|
||||||
|
.current_dir(cwd)
|
||||||
|
.env_clear()
|
||||||
|
.env("ANTHROPIC_API_KEY", "test-compact-key")
|
||||||
|
.env("ANTHROPIC_BASE_URL", base_url)
|
||||||
|
.env("CLAW_CONFIG_HOME", config_home)
|
||||||
|
.env("HOME", home)
|
||||||
|
.env("NO_COLOR", "1")
|
||||||
|
.env("PATH", "/usr/bin:/bin")
|
||||||
|
.stdin(Stdio::piped())
|
||||||
|
.stdout(Stdio::piped())
|
||||||
|
.stderr(Stdio::piped())
|
||||||
|
.args(args)
|
||||||
|
.spawn()
|
||||||
|
.expect("claw should launch");
|
||||||
|
child
|
||||||
|
.stdin
|
||||||
|
.as_mut()
|
||||||
|
.expect("stdin should be piped")
|
||||||
|
.write_all(stdin.as_bytes())
|
||||||
|
.expect("stdin should write");
|
||||||
|
child.stdin.take();
|
||||||
|
child.wait_with_output().expect("output should collect")
|
||||||
|
}
|
||||||
|
|
||||||
fn run_claw_closed_stdin_with_timeout(
|
fn run_claw_closed_stdin_with_timeout(
|
||||||
cwd: &std::path::Path,
|
cwd: &std::path::Path,
|
||||||
config_home: &std::path::Path,
|
config_home: &std::path::Path,
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -514,7 +514,7 @@ pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
|||||||
"required": ["url", "prompt"],
|
"required": ["url", "prompt"],
|
||||||
"additionalProperties": false
|
"additionalProperties": false
|
||||||
}),
|
}),
|
||||||
required_permission: PermissionMode::ReadOnly,
|
required_permission: PermissionMode::DangerFullAccess,
|
||||||
},
|
},
|
||||||
ToolSpec {
|
ToolSpec {
|
||||||
name: "WebSearch",
|
name: "WebSearch",
|
||||||
@@ -535,7 +535,7 @@ pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
|||||||
"required": ["query"],
|
"required": ["query"],
|
||||||
"additionalProperties": false
|
"additionalProperties": false
|
||||||
}),
|
}),
|
||||||
required_permission: PermissionMode::ReadOnly,
|
required_permission: PermissionMode::DangerFullAccess,
|
||||||
},
|
},
|
||||||
ToolSpec {
|
ToolSpec {
|
||||||
name: "TodoWrite",
|
name: "TodoWrite",
|
||||||
@@ -1321,8 +1321,26 @@ fn execute_tool_with_enforcer(
|
|||||||
maybe_enforce_permission_check_with_mode(enforcer, name, input, required_mode)?;
|
maybe_enforce_permission_check_with_mode(enforcer, name, input, required_mode)?;
|
||||||
run_grep_search(grep_input)
|
run_grep_search(grep_input)
|
||||||
}
|
}
|
||||||
"WebFetch" => from_value::<WebFetchInput>(input).and_then(run_web_fetch),
|
"WebFetch" => {
|
||||||
"WebSearch" => from_value::<WebSearchInput>(input).and_then(run_web_search),
|
let web_input = from_value::<WebFetchInput>(input)?;
|
||||||
|
maybe_enforce_permission_check_with_mode(
|
||||||
|
enforcer,
|
||||||
|
name,
|
||||||
|
input,
|
||||||
|
PermissionMode::DangerFullAccess,
|
||||||
|
)?;
|
||||||
|
run_web_fetch(web_input)
|
||||||
|
}
|
||||||
|
"WebSearch" => {
|
||||||
|
let web_input = from_value::<WebSearchInput>(input)?;
|
||||||
|
maybe_enforce_permission_check_with_mode(
|
||||||
|
enforcer,
|
||||||
|
name,
|
||||||
|
input,
|
||||||
|
PermissionMode::DangerFullAccess,
|
||||||
|
)?;
|
||||||
|
run_web_search(web_input)
|
||||||
|
}
|
||||||
"TodoWrite" => from_value::<TodoWriteInput>(input).and_then(run_todo_write),
|
"TodoWrite" => from_value::<TodoWriteInput>(input).and_then(run_todo_write),
|
||||||
"Skill" => from_value::<SkillInput>(input).and_then(run_skill),
|
"Skill" => from_value::<SkillInput>(input).and_then(run_skill),
|
||||||
"Agent" => from_value::<AgentInput>(input).and_then(run_agent),
|
"Agent" => from_value::<AgentInput>(input).and_then(run_agent),
|
||||||
@@ -10264,6 +10282,26 @@ printf 'pwsh:%s' "$1"
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn given_workspace_write_enforcer_when_web_tools_then_denied() {
|
||||||
|
let registry = workspace_write_registry();
|
||||||
|
for (tool, input) in [
|
||||||
|
(
|
||||||
|
"WebFetch",
|
||||||
|
json!({"url":"https://example.com", "prompt":"summarize"}),
|
||||||
|
),
|
||||||
|
("WebSearch", json!({"query":"rust language"})),
|
||||||
|
] {
|
||||||
|
let err = registry
|
||||||
|
.execute(tool, &input)
|
||||||
|
.expect_err("network tools should require explicit full access");
|
||||||
|
assert!(
|
||||||
|
err.contains("requires 'danger-full-access'"),
|
||||||
|
"{tool} should require elevated mode: {err}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn given_workspace_write_enforcer_when_bash_uses_shell_expansion_then_denied() {
|
fn given_workspace_write_enforcer_when_bash_uses_shell_expansion_then_denied() {
|
||||||
let registry = workspace_write_registry();
|
let registry = workspace_write_registry();
|
||||||
|
|||||||
Reference in New Issue
Block a user