Compare commits

..

1 Commits

Author SHA1 Message Date
YeonGyu-Kim
7cd5277a88 test(output_format_contract): add plugins json coverage to inventory_commands test
Add four assertions to inventory_commands_emit_structured_json_when_requested:
- kind == "plugin"
- action == "list"
- reload_runtime is boolean
- target is null when no plugin is targeted

Closes the only major --output-format json surface with zero contract
coverage. All other surfaces (agents, mcp, skills, status, sandbox,
doctor, help, version, acp, bootstrap-plan, system-prompt, init, diff,
config) already had test assertions.
2026-05-01 05:34:42 +09:00
3 changed files with 5 additions and 50 deletions

View File

@@ -2627,15 +2627,12 @@ fn print_version(output_format: CliOutputFormat) -> Result<(), Box<dyn std::erro
} }
fn version_json_value() -> serde_json::Value { fn version_json_value() -> serde_json::Value {
let executable_path = env::current_exe().ok().map(|p| p.display().to_string());
json!({ json!({
"kind": "version", "kind": "version",
"message": render_version_report(), "message": render_version_report(),
"version": VERSION, "version": VERSION,
"git_sha": GIT_SHA, "git_sha": GIT_SHA,
"target": BUILD_TARGET, "target": BUILD_TARGET,
"build_date": DEFAULT_DATE,
"executable_path": executable_path,
}) })
} }
@@ -3526,10 +3523,10 @@ fn run_resume_command(
Ok(ResumeCommandOutcome { Ok(ResumeCommandOutcome {
session: session.clone(), session: session.clone(),
message: Some(handle_agents_slash_command(args.as_deref(), &cwd)?), message: Some(handle_agents_slash_command(args.as_deref(), &cwd)?),
json: Some( json: Some(serde_json::json!({
serde_json::to_value(handle_agents_slash_command_json(args.as_deref(), &cwd)?) "kind": "agents",
.unwrap_or_else(|_| serde_json::json!(null)), "text": handle_agents_slash_command(args.as_deref(), &cwd)?,
), })),
}) })
} }
SlashCommand::Skills { args } => { SlashCommand::Skills { args } => {

View File

@@ -30,15 +30,6 @@ fn version_emits_json_when_requested() {
let parsed = assert_json_command(&root, &["--output-format", "json", "version"]); let parsed = assert_json_command(&root, &["--output-format", "json", "version"]);
assert_eq!(parsed["kind"], "version"); assert_eq!(parsed["kind"], "version");
assert_eq!(parsed["version"], env!("CARGO_PKG_VERSION")); assert_eq!(parsed["version"], env!("CARGO_PKG_VERSION"));
// Provenance fields must be present for binary identification (#507).
assert!(
parsed["build_date"].is_string(),
"build_date must be a string in version JSON"
);
assert!(
parsed["executable_path"].is_string(),
"executable_path must be a string in version JSON so callers can identify which binary is running"
);
} }
#[test] #[test]
@@ -369,34 +360,6 @@ fn resumed_inventory_commands_emit_structured_json_when_requested() {
assert_eq!(skills["action"], "list"); assert_eq!(skills["action"], "list");
assert!(skills["summary"]["total"].is_number()); assert!(skills["summary"]["total"].is_number());
assert!(skills["skills"].is_array()); assert!(skills["skills"].is_array());
let agents = assert_json_command_with_env(
&root,
&[
"--output-format",
"json",
"--resume",
session_path.to_str().expect("utf8 session path"),
"/agents",
],
&[
(
"CLAW_CONFIG_HOME",
config_home.to_str().expect("utf8 config home"),
),
("HOME", home.to_str().expect("utf8 home")),
],
);
assert_eq!(agents["kind"], "agents");
assert_eq!(agents["action"], "list");
assert!(
agents["agents"].is_array(),
"agents field must be a JSON array"
);
assert!(
agents["count"].is_number(),
"count must be a number, not a text render"
);
} }
#[test] #[test]

View File

@@ -227,8 +227,6 @@ fn resumed_status_command_emits_structured_json_when_requested() {
// given // given
let temp_dir = unique_temp_dir("resume-status-json"); let temp_dir = unique_temp_dir("resume-status-json");
fs::create_dir_all(&temp_dir).expect("temp dir should exist"); fs::create_dir_all(&temp_dir).expect("temp dir should exist");
let config_home = temp_dir.join("config-home");
fs::create_dir_all(&config_home).expect("isolated config home should exist");
let session_path = temp_dir.join("session.jsonl"); let session_path = temp_dir.join("session.jsonl");
let mut session = workspace_session(&temp_dir); let mut session = workspace_session(&temp_dir);
@@ -240,9 +238,7 @@ fn resumed_status_command_emits_structured_json_when_requested() {
.expect("session should persist"); .expect("session should persist");
// when // when
// Use an isolated CLAW_CONFIG_HOME so ~/.claw/settings.json is not loaded, let output = run_claw(
// which would cause loaded_config_files to be non-zero (#65).
let output = run_claw_with_env(
&temp_dir, &temp_dir,
&[ &[
"--output-format", "--output-format",
@@ -251,7 +247,6 @@ fn resumed_status_command_emits_structured_json_when_requested() {
session_path.to_str().expect("utf8 path"), session_path.to_str().expect("utf8 path"),
"/status", "/status",
], ],
&[("CLAW_CONFIG_HOME", config_home.to_str().expect("utf8 path"))],
); );
// then // then