From 040f86d50ddd4ec4952e149a2730f7a7ba8b89ad Mon Sep 17 00:00:00 2001
From: Nova <technobaboo@gmail.com>
Date: Thu, 21 Aug 2025 13:47:19 -0700
Subject: [PATCH] refactor: remove as_any function from Aspect since trait
 upcasting added

---
 codegen/src/lib.rs | 3 ---
 src/nodes/alias.rs | 3 ---
 src/nodes/mod.rs   | 2 --
 3 files changed, 8 deletions(-)

diff --git a/codegen/src/lib.rs b/codegen/src/lib.rs
index a050ad9..54fed88 100644
--- a/codegen/src/lib.rs
+++ b/codegen/src/lib.rs
@@ -281,9 +281,6 @@ fn generate_aspect(aspect: &Aspect) -> TokenStream {
 		}
 		macro_rules! #aspect_macro_name {
 			() => {
-				fn as_any(self: Arc<Self>) -> Arc<dyn std::any::Any + Send + Sync + 'static> {
-					self
-				}
 				#[allow(clippy::all)]
 				fn run_signal(
 					&self,
diff --git a/src/nodes/alias.rs b/src/nodes/alias.rs
index 6ccd64d..82f3a50 100644
--- a/src/nodes/alias.rs
+++ b/src/nodes/alias.rs
@@ -71,9 +71,6 @@ impl AspectIdentifier for Alias {
 	const ID: u64 = 0;
 }
 impl Aspect for Alias {
-	fn as_any(self: Arc<Self>) -> Arc<dyn std::any::Any + Send + Sync + 'static> {
-		self
-	}
 	fn run_signal(
 		&self,
 		_calling_client: Arc<Client>,
diff --git a/src/nodes/mod.rs b/src/nodes/mod.rs
index 762b55e..11f62e4 100644
--- a/src/nodes/mod.rs
+++ b/src/nodes/mod.rs
@@ -303,7 +303,6 @@ pub trait AspectIdentifier: Aspect {
 	const ID: u64;
 }
 pub trait Aspect: Any + Send + Sync + 'static {
-	fn as_any(self: Arc<Self>) -> Arc<dyn Any + Send + Sync + 'static>;
 	fn run_signal(
 		&self,
 		calling_client: Arc<Client>,
@@ -337,7 +336,6 @@ impl Aspects {
 			.get(&A::ID)
 			// .cloned doesn't work for some reason
 			.map(|v| v.clone())
-			.map(|a| a.as_any())
 			.and_then(|a| Arc::downcast(a).ok())
 			.ok_or(ServerError::NoAspect(TypeId::of::<A>()))
 	}