StardustXR/server
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 5 Wiki Activity

fix(spatial): proper visibility culling scaling

Browse Source
This commit is contained in:
Nova
2025-10-23 15:46:02 -07:00
parent 6e2de6ac87
commit 392eaf4ee5
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/nodes/spatial/mod.rs
View File

@@ -115,6 +115,8 @@ static SPATIAL_REGISTRY: Registry<Spatial> = Registry::new();
#[require(BevyTransform, Visibility)] #[require(BevyTransform, Visibility)]
pub struct SpatialNode(pub Weak<Spatial>); pub struct SpatialNode(pub Weak<Spatial>);
const EPSILON: f32 = 0.00001;
stardust_xr_server_codegen::codegen_spatial_protocol!(); stardust_xr_server_codegen::codegen_spatial_protocol!();
impl Transform { impl Transform {
pub fn to_mat4(&self, position: bool, rotation: bool, scale: bool) -> Mat4 { pub fn to_mat4(&self, position: bool, rotation: bool, scale: bool) -> Mat4 {
@@ -128,14 +130,13 @@ impl Transform {
.unwrap_or_else(|| Quat::IDENTITY.into()); .unwrap_or_else(|| Quat::IDENTITY.into());
// Zero scale values break everything // Zero scale values break everything
let epsilon = 0.00001;
let scale = scale let scale = scale
.then_some(self.scale) .then_some(self.scale)
.flatten() .flatten()
.map(|s| Vector3 { .map(|s| Vector3 {
x: if s.x == 0.0 { epsilon } else { s.x }, x: if s.x == 0.0 { EPSILON } else { s.x },
y: if s.y == 0.0 { epsilon } else { s.y }, y: if s.y == 0.0 { EPSILON } else { s.y },
z: if s.z == 0.0 { epsilon } else { s.z }, z: if s.z == 0.0 { EPSILON } else { s.z },
}) })
.unwrap_or_else(|| Vector3::from([1.0; 3])); .unwrap_or_else(|| Vector3::from([1.0; 3]));
@@ -245,7 +246,7 @@ impl Spatial {
let y_scale = mat.y_axis.length_squared(); let y_scale = mat.y_axis.length_squared();
let z_scale = mat.z_axis.length_squared(); let z_scale = mat.z_axis.length_squared();
!(x_scale == 0.0 && y_scale == 0.0 && z_scale == 0.0) x_scale >= EPSILON.powi(2) || y_scale >= EPSILON.powi(2) || z_scale >= EPSILON.powi(2)
} }
/// Check if this node or any ancestor has zero scale (for visibility culling) /// Check if this node or any ancestor has zero scale (for visibility culling)
pub fn visible(&self) -> bool { pub fn visible(&self) -> bool {