docs(roadmap): add #681 — unsupported mcp mutation verbs return help with exit 0

ROADMAP.md

@@ -6429,44 +6429,42 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed)
 
 450. **`prompt` emits `kind:"missing_credentials"` JSON on STDERR (not stdout), leaving stdout at 0 bytes — automation pattern `output=$(claw prompt hello --output-format json)` captures nothing on auth-absent failure; `doctor` correctly surfaces `auth.status:"warn"` with `api_key_present:false` but exposes no `prompt_ready:false` field that automation can check before invoking `prompt`** — dogfooded 2026-05-16 by Jobdori on `a35ee9a0` in response to Clawhip pinpoint nudge at `1505208225321062521`. Exact reproduction (isolated env, no creds, fresh git repo, HEAD `a35ee9a0`): `timeout 5 env -i HOME=$ISOLATED_HOME PATH=$PATH CLAW_CONFIG_HOME=$PROBE/.claw-cfg claw prompt hello --output-format json > stdout.txt 2> stderr.txt` → stdout = **0 bytes**, stderr = 195 bytes containing `{"error":"missing Anthropic credentials…","exit_code":1,"hint":null,"kind":"missing_credentials","type":"error"}`, exit code 1. Confirms Gaebal's `1505208553793781792` pinpoint that `prompt` timeout + zero bytes was the prior state — HEAD `a35ee9a0` now correctly exits 1 with `kind:"missing_credentials"` **but the envelope is still routed to stderr** (issue #447 class, same class as prior entries #422, #435). **Contrast with `doctor`:** `claw doctor --output-format json 2>/dev/null` succeeds to stdout with `checks[auth].status:"warn"`, `api_key_present:false`, `auth_token_present:false` — but the auth check has no `prompt_ready:false` field. Automation that gates on `doctor` before invoking `prompt` must re-derive readiness from `api_key_present && auth_token_present` — there is no single canonical boolean. **Three compound problems:** (a) **stdout-empty on `--output-format json` failure**: same class as #447; `prompt`'s error envelope goes to stderr, not stdout. The canonical automation idiom `if ! result=$(claw prompt "q" --output-format json); then echo "$result" | jq .kind; fi` sees `$result=""` on failure — the jq call gets nothing. All `--output-format json` error paths must route JSON to stdout per #447 contract; (b) **`doctor` missing `prompt_ready` field**: `doctor --output-format json` already knows auth is absent (`api_key_present:false`) but surfaces no derived `prompt_ready:bool` or `prompt_blocked_reason:string` field. Automation must infer readiness from `api_key_present || auth_token_present || legacy_*_present` — a 5-field OR across legacy fields that is fragile as auth mechanisms evolve. A single `prompt_ready:false` (with `prompt_blocked_reason:"auth_missing"`) inside the `auth` check would give downstream a stable contract; (c) **`claw prompt` with no auth does no preflight and fires straight at the API**: the preflight check that `doctor` runs (auth discovery) is not reused by `prompt` to emit a fast typed error before attempting the network call. Both Gaebal's pinpoint (prompt hanging silently on older HEAD) and the current behavior (prompt hitting auth gate after a brief API attempt) stem from the same root: prompt does not short-circuit at the point where `doctor` already knows auth is absent. If `doctor` can emit `kind:"doctor"` with `auth.status:"warn"` in ~20ms without a network call, `prompt` should emit `kind:"missing_credentials"` in the same window and output it to stdout. **Required fix shape:** (a) `prompt --output-format json` must write the `kind:"missing_credentials"` JSON envelope to **stdout**, not stderr — same fix as #447 for all error envelopes; (b) add `prompt_ready:bool` and `prompt_blocked_reason:string|null` to the `auth` check in `doctor --output-format json`; derive it as `api_key_present || auth_token_present || legacy_saved_oauth_present`; (c) `prompt` must run the credential preflight check (same codepath as doctor's auth check) before attempting any API call and emit `{"kind":"missing_credentials","prompt_blocked_reason":"auth_missing"}` on **stdout** with exit 1 if the check fails; (d) `--output-format json` stdout routing fix must cover: `prompt`, `session list` (cross-ref #449), `skills uninstall` (cross-ref #431), `resume` (cross-ref #435), `acp serve` (cross-ref #443) — the full `kind:"missing_credentials"` class; (e) regression test: `claw prompt hello --output-format json` with no creds writes JSON to stdout (0 bytes stderr), exits 1, `kind:"missing_credentials"`, in under 200ms (no network attempt). **Why this matters:** `prompt` is the primary consumer entry point. Auth-absent failure routing to stderr breaks every automation wrapper that captures `$(claw prompt ... --output-format json)`. The `doctor` preflight metadata gap means auth-readiness checks require parsing 5 legacy fields instead of reading one boolean. Cross-references #447 (all JSON error envelopes on stderr), #449 (session list hits auth gate), #431 (skills uninstall hits auth gate), #357 (auth gate on local ops cluster), #422 (exit-code parity). Source: Jobdori live dogfood, `a35ee9a0`, 2026-05-16.
 
-466. **Provider `*_BASE_URL` env vars are accepted as routing/transport configuration but `doctor` / `status` do zero validation and surface zero provenance: 24 malformed/unsupported values across `ANTHROPIC_BASE_URL`, `OPENAI_BASE_URL`, `XAI_BASE_URL`, and `DASHSCOPE_BASE_URL` all return `doctor_exit=0`, `has_failures=false`, `auth ok`, `config ok`, and `system ok`, even for `not-a-url`, `ftp://example.com`, `http://`, `http://localhost:99999`, `javascript:alert(1)`, and empty string. This makes the preflight surface say “green” while the next prompt call will fail later in the HTTP client / URL parser / provider edge, with no machine-readable clue which base URL env var poisoned the lane** — dogfooded 2026-05-24 for the 17:00–17:30 Clawhip nudge window (finalized for message `1508160182386167961`), reproduced on local `./rust/target/debug/claw` `git_sha 003b739d` (origin/main `f8e1bb72`) in a clean isolated env.
+681. **Unsupported `claw mcp` mutation verbs (`add`, `remove`, `delete`, `enable`, `disable`) return a help payload with `exit=0` instead of a typed unsupported/not-implemented error: `claw mcp add demo -- /bin/echo hi --output-format json` emits `{kind:"mcp", action:"help", unexpected:"add demo -- /bin/echo hi", usage:{...}}` on stdout, no stderr, and no file changes. The command clearly did not add anything, but shell/CI sees success; `unexpected` is the only clue, and it is embedded in a help object rather than a `status:"unsupported"` / `kind:"error"` envelope** — dogfooded 2026-05-24 for the 20:00 Clawhip nudge at message `1508197932497899740`, reproduced on local `./rust/target/debug/claw` `git_sha 003b739d` (origin/main `f8e1bb72`) in a clean isolated env. Number intentionally jumps to #681 because Jobdori publicly filed/announced ROADMAP #680 in this channel; avoiding distributed queue collision.
 
-    Reproduction matrix (credential-free except fake API key env vars so auth check passes):
+    Reproduction:
 
     ```bash
-    for var in ANTHROPIC_BASE_URL OPENAI_BASE_URL XAI_BASE_URL DASHSCOPE_BASE_URL; do
-      for url in 'not-a-url' 'ftp://example.com' 'http://' 'http://localhost:99999' 'javascript:alert(1)' ''; do
-        env -i HOME=/tmp/iso24/home ANTHROPIC_API_KEY=sk-ant-fake OPENAI_API_KEY=sk-openai-fake \
-          "$var=$url" PATH=/usr/bin:/bin TERM=dumb \
-          claw doctor --output-format json
-      done
-    done
-    ```
-
-    Every row produced the same health shape:
-
-    ```text
-    doctor_exit=0 stderr_bytes=0
-    has_failures false
-    auth ok 'supported auth env vars are configured'
-    config ok 'no config files present; defaults are active'
-    system ok 'captured local runtime metadata'
-    ```
-
-    No diagnostic says the lane is configured to talk to `javascript:alert(1)`, `ftp://example.com`, `http://`, or an invalid port `99999`.
-
-    **Root cause traced:** provider metadata knows which env var controls each provider's base URL (`rust/crates/api/src/providers/mod.rs:42-43`, with `base_url_env` / `default_base_url` fields), and the Anthropic client reads `ANTHROPIC_BASE_URL` directly in `anthropic.rs:765-766`:
-
-    ```rust
-    pub fn read_base_url() -> String {
-        std::env::var("ANTHROPIC_BASE_URL").unwrap_or_else(|_| DEFAULT_BASE_URL.to_string())
+    $ env -i HOME=/tmp/iso29/home PATH=/usr/bin:/bin TERM=dumb \
+        claw mcp add demo -- /bin/echo hi --output-format json
+    {
+      "action": "help",
+      "kind": "mcp",
+      "unexpected": "add demo -- /bin/echo hi",
+      "usage": {
+        "direct_cli": "claw mcp [list|show <server>|help]",
+        "slash_command": "/mcp [list|show <server>|help]",
+        "sources": [".claw/settings.json", ".claw/settings.local.json"]
+      }
     }
+    # exit 0, stderr empty, no .claw/settings.json written
     ```
 
-    OpenAI-compat providers carry the same metadata in `openai_compat.rs` (`XAI_BASE_URL`, `OPENAI_BASE_URL`, `DASHSCOPE_BASE_URL`). But `check_auth_health()` only checks auth booleans, `check_config_health()` only checks config files/MCP counts, and `check_system_health()` only reports local runtime metadata. There is no provider-endpoint check and no `base_url_source` field in `status`. The runtime will later concatenate/parse/use these env vars as actual URLs (`anthropic.rs:470` builds `{base_url}/v1/messages`), but the preflight surfaces do not validate scheme, host, parseability, or port range.
+    Same shape for:
 
-    **Why distinct from existing items:** ROADMAP #28/#29 cover provider routing and auth-copy issues, including OpenRouter guidance and prefix routing, but not malformed base URL validation. ROADMAP #248 asks non-interactive prompt lifecycle events to include provider/model/base-url identity after a prompt starts; this entry is the *preflight* counterpart: `doctor` / `status` should surface bad base URLs before any prompt/API call. ROADMAP #465 covers effective auth source when both Anthropic auth env vars are set; this entry covers endpoint configuration across all provider env vars. ROADMAP #111 says `/providers` should list providers/base URLs/reachability, but `/providers` is a slash-command spec mismatch; this entry is specifically about the existing `doctor`/`status` green-light surfaces ignoring base URL env vars. No existing entry documents that every malformed `*_BASE_URL` value tested leaves doctor green.
+    ```bash
+    claw mcp add demo /bin/echo hi --output-format json
+    claw mcp remove demo --output-format json
+    claw mcp delete demo --output-format json
+    claw mcp disable demo --output-format json
+    claw mcp enable demo --output-format json
+    ```
 
-    **Why this matters:** (1) **Startup friction:** users configuring OpenRouter/Ollama/local proxy inevitably touch `OPENAI_BASE_URL`. A one-character typo (`http://`, trailing junk, unsupported scheme) currently passes doctor and fails only during a live prompt. (2) **Automation cannot preflight lanes.** Clawhip wants to know whether a lane is safe before spending tokens / starting a long prompt. Green doctor with poisoned base URL is false confidence. (3) **Security posture:** accepting `javascript:` / `ftp:` / empty string as silently “configured” is not just UX badness; provider clients should only ever use HTTP(S) URLs, and diagnostics should reject or warn on anything else. (4) **The metadata already exists.** Provider metadata names every env var and default URL; the missing layer is just validation and redaction-safe surfacing. (5) **Base URL is provider identity.** Status currently reports model and permission mode, but not where requests will be sent. For OpenAI-compatible providers especially, `OPENAI_BASE_URL` is the difference between OpenAI, OpenRouter, Ollama, local proxy, or malicious typo.
+    All return `exit=0`, `kind:"mcp"`, `action:"help"`, `unexpected:"<verb ...>"` and no stderr. The supported action list in `mcp help --output-format json` is only `list|show <server>|help`, so these mutation verbs are unsupported by contract, but the failure mode is success/help.
 
-    **Required fix shape:** (a) Add a provider endpoint diagnostics check to `doctor` that iterates provider metadata, reads each `*_BASE_URL` env var if present, trims it, parses it with `Url`, and validates `scheme in {http, https}`, non-empty host, valid port, and no unsupported schemes. Empty string should be treated as unset or explicit invalid with a dedicated warning, not silent ok. (b) Add redaction-safe fields to `status --output-format json`: active provider, `base_url_env`, `base_url_source: "default" | "env"`, `base_url_valid`, `base_url_scheme`, `base_url_host`, and `base_url_error` if invalid. Do not include credentials or path secrets; host/scheme are enough. (c) When the selected model/provider is affected by an invalid base URL, `doctor` should be `warn` or `fail` and `status.status` should be `degraded`, not `ok`. (d) Add tests for the 24-row matrix above plus a valid local URL (`http://127.0.0.1:11434/v1`) and valid HTTPS URL. (e) Optional: `/providers` (when fixed from #111) should reuse the same endpoint validation so base URL truth has one source. **Acceptance check:** `env OPENAI_API_KEY=sk-test OPENAI_BASE_URL=javascript:alert\(1\) claw doctor --output-format json | jq -e '.checks[] | select(.name=="providers" or .name=="provider_endpoints") | .status != "ok" and (.details[]? | test("OPENAI_BASE_URL"))'` should pass; currently there is no such check and doctor is green. Source: gaebal-gajae dogfood for the 2026-05-24 17:00/17:30 Clawhip nudges. Coordination note: still avoided F/CLAW_CONFIG_HOME because Jobdori publicly queued it; this endpoint-validation surface is orthogonal and credential-free.
+    **Root cause shape:** the MCP command parser treats unknown sub-actions as a help-topic request and preserves the raw tail in `unexpected`, but does not convert that branch into a command failure. The help JSON schema has no `status`, `ok`, `error_kind`, `exit_ok`, or `unsupported_action` field, so automation must special-case `action:"help" && unexpected != null` to detect that a requested operation did not run.
+
+    **Why distinct from existing items:** ROADMAP #327 covers `mcp help` source-list mismatch (`.claw.json` omitted while accepted). This entry covers unsupported mutation verbs returning success. ROADMAP #347 covers `mcp show <missing>` returning `status:"ok"` with `found:false`; this entry is broader/different: unsupported *verbs* (`add/remove/enable/disable/delete`) return help with exit 0 and no command-status field. ROADMAP #102/#129 cover MCP server liveness/runtime startup; this is control-plane mutation command semantics. ROADMAP #78 covered `plugins` route falling through to prompt; this is the `mcp` route resolving locally but reporting failed mutation as successful help. No existing entry found for `mcp add/remove` write-target or unsupported mutation verbs.
+
+    **Why this matters:** (1) **Automation false success.** A setup script can run `claw mcp add demo ...` and proceed because exit code is 0, even though no server was added. (2) **Mutation verbs are common user expectation.** MCP CLIs often support `add`/`remove`; users will try them. If not implemented, fail closed with a clear typed error. (3) **No write-target clarity.** Since help claims sources `.claw/settings.json` / `.claw/settings.local.json`, a user may reasonably expect `add` to write one. Returning success/help leaves them guessing. (4) **Machine contract ambiguity.** `unexpected` inside help is not an error field; claws should not have to infer failure from a non-null optional help attribute. (5) **Compounds #327.** The help object shown in the failure path also repeats the stale source-list problem, so the unsupported-action error points at incomplete config-source docs.
+
+    **Required fix shape:** (a) For unsupported MCP sub-actions, return a typed JSON error such as `{type:"error", kind:"unsupported_mcp_action", action:"add", supported_actions:["list","show","help"], hint:"MCP mutation commands are not implemented; edit .claw/settings.json manually or use ..."}` and exit non-zero. (b) Preserve a human help fallback only for explicit `mcp help` / `mcp --help`, not for attempted mutations. (c) If mutation verbs are intended roadmap features, add `not_implemented` status with non-zero exit and no file writes. (d) Add tests for `add/remove/enable/disable/delete` proving they are distinguishable from successful help and successful list/show. (e) When mutation support lands, include explicit write-target/source-layer semantics (`project`, `local`, `user`) instead of guessing. **Acceptance check:** `claw mcp add demo -- /bin/echo hi --output-format json >/tmp/out 2>/tmp/err; test $? -ne 0 && jq -e '.kind == "unsupported_mcp_action" and .action == "add"' /tmp/err` should pass; currently exit is 0 and stdout is a help object. Source: gaebal-gajae dogfood for the 2026-05-24 20:00 Clawhip nudge. Coordination note: avoided Jobdori-claimed #680/session-sort and F/CLAW_CONFIG_HOME; targeted MCP mutation semantics after pre-grep showed common MCP lifecycle gaps already covered.