MayaTheShy/opus-apps
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

WIP: Try to update Milo for 1.19 #63

Draft
Kan18 wants to merge 27 commits from Kan18/develop-1.8 into develop-1.8
pull from: Kan18/develop-1.8
merge into: MayaTheShy:develop-1.8
Conversation 7 Commits 27 Files Changed 25 +6776 -4610
Kan18 commented 2022-12-28 11:40:28 -05:00 (Migrated from github.com)
Copy Link

Removes Milo trying to access damage on items (nil because of The Flattening). Changes "getItemMeta" to "getItemDetail". We might also need to reimplement showing durability in the item's display name - I got a little too carried away with removing mentions of "damage". Also renames nbtHash to nbt to be consistent with new CC:T naming. I tried not to touch anything related to MiloRemote for now, and there are probably still many bugs remaining that need to be ironed out. Most of the basic functionality works now, though.

Removes Milo trying to access damage on items (`nil` because of The Flattening). Changes "getItemMeta" to "getItemDetail". We might also need to reimplement showing durability in the item's display name - I got a little too carried away with removing mentions of "damage". Also renames nbtHash to nbt to be consistent with new CC:T naming. I tried not to touch anything related to MiloRemote for now, and there are probably still many bugs remaining that need to be ironed out. Most of the basic functionality works now, though.
Kan18 commented 2022-12-28 16:32:37 -05:00 (Migrated from github.com)
Copy Link

We might also have to fix all the recipes as well, by removing the damage values

We might also have to fix all the recipes as well, by removing the damage values
Kan18 commented 2022-12-29 07:23:29 -05:00 (Migrated from github.com)
Copy Link

Actually, half the recipes are broken because of renamed items; maybe dump them again or something

Actually, half the recipes are broken because of renamed items; maybe dump them again or something
Nerdpie (Migrated from github.com) reviewed 2023-01-02 17:12:14 -05:00
milo/apis/init.lua
Nerdpie (Migrated from github.com) commented 2023-01-02 17:12:14 -05:00
Copy Link

Won't this still need to check the damage? For instance, a hammer used to turn an ingot into a plate, but uses durability.

Won't this still need to check the damage? For instance, a hammer used to turn an ingot into a plate, but uses durability.
Nerdpie (Migrated from github.com) reviewed 2023-01-02 17:12:26 -05:00
milo/apis/turtleInv.lua
@@ -0,0 +20,4 @@
function TurtleInv.list()
local list = {}
for slot = 1, inventorySize do
list[slot] = turtle.getItemDetail(slot)
Nerdpie (Migrated from github.com) commented 2023-01-02 17:12:26 -05:00
Copy Link

Only includes the NBT hash with the 'true' second arg. At least in my testing in 1.18.2; may be different in 1.19

Only includes the NBT hash with the 'true' second arg. At least in my testing in 1.18.2; may be different in 1.19
Nerdpie (Migrated from github.com) reviewed 2023-01-02 17:13:49 -05:00
Nerdpie (Migrated from github.com) left a comment
Copy Link

Just a couple thoughts; I was poking at updating for 1.18.2.

Just a couple thoughts; I was poking at updating for 1.18.2.
Kan18 commented 2023-01-07 09:17:16 -05:00 (Migrated from github.com)
Copy Link

Thanks for the feedback! Sorry I'm getting to this just now. The PR still has weird bugs involving items with NBT, so I am marking this as draft right now. Also, somebody brought up the issue of 1.12.2 compatibility on Discord - not exactly sure how to solve this (having two different branches/versions, maybe?)

Thanks for the feedback! Sorry I'm getting to this just now. The PR still has weird bugs involving items with NBT, so I am marking this as draft right now. Also, somebody brought up the issue of 1.12.2 compatibility on Discord - not exactly sure how to solve this (having two different branches/versions, maybe?)
Kan18 (Migrated from github.com) reviewed 2023-01-18 17:19:46 -05:00
milo/apis/turtleInv.lua
@@ -0,0 +20,4 @@
function TurtleInv.list()
local list = {}
for slot = 1, inventorySize do
list[slot] = turtle.getItemDetail(slot)
Kan18 (Migrated from github.com) commented 2023-01-18 17:19:46 -05:00
Copy Link

Instead of fixing this, I could just wait for cc-tweaked/cc-tweaked#1306 😴

Instead of fixing this, I could just wait for cc-tweaked/cc-tweaked#1306 😴
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Kan18/develop-1.8:Kan18/develop-1.8
git checkout Kan18/develop-1.8
Sign in to join this conversation.
Reviewers
No Reviewers
Nerdpie
Kan18
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MayaTheShy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MayaTheShy/opus-apps#63
Delete Branch "Kan18/develop-1.8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?