Fix incorrect textures being rendered #29

2024-11-18T11:40:04-05:00

Schmarni-Dev commented

2024-11-18 11:40:04 -05:00

(Migrated from github.com)

as far as i can tell the previous hashing should work but it didn't and this works.
this may break batching, not sure

as far as i can tell the previous hashing should work but it didn't and this works. this may break batching, not sure

technobaboo commented

2024-11-18 14:18:49 -05:00

(Migrated from github.com)

unfortunately it does seem to break batching, not sure why...

![image](https://github.com/user-attachments/assets/e7a0bc56-badb-4cfb-b78e-6f0edd9c691e) unfortunately it does seem to break batching, not sure why...

technobaboo commented

2024-11-18 14:20:36 -05:00

(Migrated from github.com)

for reference

this is the GL call that draws all of them at once with a batched material (commit right before yours), saving a lot of the frametime

for reference ![image](https://github.com/user-attachments/assets/fb6bc345-8be9-42b6-b70b-96a8fdeb4f7e) this is the GL call that draws all of them at once with a batched material (commit right before yours), saving a lot of the frametime

technobaboo commented

2024-11-18 14:33:42 -05:00

(Migrated from github.com)

ah i see why it didn't batch, the material's value is a pointer to memory and it's got different memory locations despite an equivalent value

technobaboo commented

2024-12-29 21:37:05 -05:00

(Migrated from github.com)

being replaced with bevy which has inbuilt material batching

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: StardustXR/server#29