fix(nix): fix nix build #44

2025-05-22T15:45:49-04:00

Nervyalloy5 commented

2025-05-22 15:45:49 -04:00

(Migrated from github.com)

Update flake.lock
Switch to correct version of sk_gpu.zip in /nix/sk_gpu.nix
Add xkeyboard_config and libgbm to dependencies in /nix/stardust-xr-server.nix
Add openxr-loader to github fetches and add it to CPM local packages

Summary by CodeRabbit

New Features
- Integrated OpenXR SDK support into the server package, enabling enhanced XR capabilities.
Chores
- Updated the GPU package to the latest version for improved compatibility and performance.
- Added new dependencies to the server package to support additional graphics and input features.

- Update flake.lock - Switch to correct version of sk_gpu.zip in /nix/sk_gpu.nix - Add xkeyboard_config and libgbm to dependencies in /nix/stardust-xr-server.nix - Add openxr-loader to github fetches and add it to CPM local packages  ## Summary by CodeRabbit - **New Features** - Integrated OpenXR SDK support into the server package, enabling enhanced XR capabilities. - **Chores** - Updated the GPU package to the latest version for improved compatibility and performance. - Added new dependencies to the server package to support additional graphics and input features.

coderabbitai[bot] commented

2025-05-22 15:45:57 -04:00

(Migrated from github.com)

📝 Walkthrough

Walkthrough

The changes update the sk_gpu package to a newer version with a corresponding checksum and enhance the stardust-xr-server Nix package by adding OpenXR SDK support. This includes fetching the OpenXR loader source, introducing new build inputs, and setting an environment variable for the loader source.

Changes

File(s)	Change Summary
nix/sk_gpu.nix	Updated `sk_gpu_zip` fetchurl to version `v2024.9.26` and replaced the SHA256 checksum.
nix/stardust-xr-server.nix	Added OpenXR loader as a `fetchFromGitHub` source, set `DEP_OPENXR_LOADER_SOURCE` environment variable, added `xkeyboard_config` and `libgbm` to build inputs, included `makeWrapper` in native build inputs, and wrapped the binary to set `XKB_CONFIG_ROOT`.

Sequence Diagram(s)

sequenceDiagram
    participant Builder as Nix Builder
    participant GitHub as GitHub (KhronosGroup/OpenXR-SDK)
    participant sk_gpu_src as sk_gpu Source
    participant Stardust as stardust-xr-server Build

    Builder->>sk_gpu_src: Fetch sk_gpu v2024.9.26 archive (new version)
    Builder->>GitHub: Fetch OpenXR loader source (new dependency)
    Builder->>Stardust: Set DEP_OPENXR_LOADER_SOURCE env variable
    Builder->>Stardust: Add xkeyboard_config and libgbm to build inputs
    Stardust->>Builder: Build with new dependencies and sources

Poem

A hop and a skip, a version anew,
With OpenXR, the stardust crew
Gains loader and keys,
For immersive sprees—
Fresh hashes, new dreams to pursue!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5dcffd7c0 and 08c7a5efea.

📒 Files selected for processing (1)

nix/stardust-xr-server.nix (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

nix/stardust-xr-server.nix

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

<details> <summary>📝 Walkthrough</summary> ## Walkthrough The changes update the `sk_gpu` package to a newer version with a corresponding checksum and enhance the `stardust-xr-server` Nix package by adding OpenXR SDK support. This includes fetching the OpenXR loader source, introducing new build inputs, and setting an environment variable for the loader source. ## Changes | File(s) | Change Summary | |------------------------|---------------------------------------------------------------------------------------------------------------------------------| | nix/sk_gpu.nix | Updated `sk_gpu_zip` fetchurl to version `v2024.9.26` and replaced the SHA256 checksum. | | nix/stardust-xr-server.nix | Added OpenXR loader as a `fetchFromGitHub` source, set `DEP_OPENXR_LOADER_SOURCE` environment variable, added `xkeyboard_config` and `libgbm` to build inputs, included `makeWrapper` in native build inputs, and wrapped the binary to set `XKB_CONFIG_ROOT`. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Builder as Nix Builder participant GitHub as GitHub (KhronosGroup/OpenXR-SDK) participant sk_gpu_src as sk_gpu Source participant Stardust as stardust-xr-server Build Builder->>sk_gpu_src: Fetch sk_gpu v2024.9.26 archive (new version) Builder->>GitHub: Fetch OpenXR loader source (new dependency) Builder->>Stardust: Set DEP_OPENXR_LOADER_SOURCE env variable Builder->>Stardust: Add xkeyboard_config and libgbm to build inputs Stardust->>Builder: Build with new dependencies and sources ``` ## Poem > A hop and a skip, a version anew, > With OpenXR, the stardust crew > Gains loader and keys, > For immersive sprees— > Fresh hashes, new dreams to pursue! > 🐇✨ </details>   > [!NOTE] > <details> > <summary>⚡️ AI Code Reviews for VS Code, Cursor, Windsurf</summary> > > CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. > Learn more [here](http://coderabbit.ai/ide). > > </details> --- > [!NOTE] > <details> > <summary>⚡️ Faster reviews with caching</summary> > > CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure `Review - Disable Cache` at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the `Data Retention` setting under your Organization Settings. > Enjoy the performance boost—your workflow just got faster. > > </details>  --- <details> <summary>📜 Recent review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between b5dcffd7c0ee46c8318d5cc4104bb23fb41cc12e and 08c7a5efea261d72b524b5e6cfa27c1590eb8b63. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `nix/stardust-xr-server.nix` (5 hunks) </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary> * nix/stardust-xr-server.nix </details> </details>     --- <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=StardustXR/server&utm_content=44): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Explain this complex logic.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai explain this code block.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and explain its main purpose.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` ### Support Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. - `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details>

technobaboo commented

2025-05-22 15:47:50 -04:00

(Migrated from github.com)

@coderabbitai review

coderabbitai[bot] commented

2025-05-22 15:47:56 -04:00

(Migrated from github.com)

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

<details> <summary>✅ Actions performed</summary> Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused. </details>

coderabbitai[bot] (Migrated from github.com) reviewed 2025-05-22 15:49:11 -04:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 0

🧹 Nitpick comments (1)

nix/stardust-xr-server.nix (1)
52-57: OpenXR SDK integration looks good

The addition of the OpenXR SDK source fetch and corresponding environment variable DEP_OPENXR_LOADER_SOURCE complements the existing openxr-loader dependency (line 24). This allows the build process to access specific OpenXR SDK source files when needed.

I notice you're pinning to a specific commit hash (288d3a7e). For maintenance purposes, it might be helpful to add a comment indicating which OpenXR release version this corresponds to.
  openxr_loader = fetchFromGitHub {
    owner = "KhronosGroup";
    repo = "OpenXR-SDK";
    rev = "288d3a7ebc1ad959f62d51da75baa3d27438c499";
+   # OpenXR SDK version X.Y.Z
    sha256 = "sha256-RdmnBe26hqPmqwCHIJolF6bSmZRmIKVlGF+TXAY35ig=";
  };
Also applies to: 62-62

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d0e1ce021 and b5dcffd7c0.

⛔ Files ignored due to path filters (1)

flake.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

nix/sk_gpu.nix (1 hunks)
nix/stardust-xr-server.nix (4 hunks)

🔇 Additional comments (3)

nix/sk_gpu.nix (1)

6-7: Version update looks good

The change updates the sk_gpu package from a previous version to v2024.9.26 with the corresponding SHA256 hash. This aligns with the PR objective to fix the nix build by switching to the correct version of sk_gpu.zip.

nix/stardust-xr-server.nix (2)

9-9: Addition of xkeyboard_config is appropriate

Adding xkeyboard_config as a dependency is a good call for an XR application, as it provides keyboard layout definitions that may be needed for input handling.

Also applies to: 90-90

19-19: Addition of libgbm is appropriate

Adding libgbm (Generic Buffer Management) is a good addition for a graphics-heavy application like StardustXR. This library provides abstraction for graphics memory management and is often required for Mesa-based rendering pipelines.

Also applies to: 94-94

**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>nix/stardust-xr-server.nix (1)</summary><blockquote> `52-57`: **OpenXR SDK integration looks good** The addition of the OpenXR SDK source fetch and corresponding environment variable `DEP_OPENXR_LOADER_SOURCE` complements the existing `openxr-loader` dependency (line 24). This allows the build process to access specific OpenXR SDK source files when needed. I notice you're pinning to a specific commit hash (288d3a7e). For maintenance purposes, it might be helpful to add a comment indicating which OpenXR release version this corresponds to. ```diff openxr_loader = fetchFromGitHub { owner = "KhronosGroup"; repo = "OpenXR-SDK"; rev = "288d3a7ebc1ad959f62d51da75baa3d27438c499"; + # OpenXR SDK version X.Y.Z sha256 = "sha256-RdmnBe26hqPmqwCHIJolF6bSmZRmIKVlGF+TXAY35ig="; }; ``` Also applies to: 62-62 </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 9d0e1ce021ccacd6a4c2ca5c0c84484d1c37ceb7 and b5dcffd7c0ee46c8318d5cc4104bb23fb41cc12e. </details> <details> <summary>⛔ Files ignored due to path filters (1)</summary> * `flake.lock` is excluded by `!**/*.lock` </details> <details> <summary>📒 Files selected for processing (2)</summary> * `nix/sk_gpu.nix` (1 hunks) * `nix/stardust-xr-server.nix` (4 hunks) </details> <details> <summary>🔇 Additional comments (3)</summary><blockquote> <details> <summary>nix/sk_gpu.nix (1)</summary> `6-7`: **Version update looks good** The change updates the sk_gpu package from a previous version to v2024.9.26 with the corresponding SHA256 hash. This aligns with the PR objective to fix the nix build by switching to the correct version of `sk_gpu.zip`. </details> <details> <summary>nix/stardust-xr-server.nix (2)</summary> `9-9`: **Addition of xkeyboard_config is appropriate** Adding xkeyboard_config as a dependency is a good call for an XR application, as it provides keyboard layout definitions that may be needed for input handling. Also applies to: 90-90 --- `19-19`: **Addition of libgbm is appropriate** Adding libgbm (Generic Buffer Management) is a good addition for a graphics-heavy application like StardustXR. This library provides abstraction for graphics memory management and is often required for Mesa-based rendering pipelines. Also applies to: 94-94 </details> </blockquote></details> </details>

This pull request has changes conflicting with the target branch.

flake.lock
nix/stardust-xr-server.nix

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin Nervyalloy5/dev:Nervyalloy5/dev

git checkout Nervyalloy5/dev

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: StardustXR/server#44

fix(nix): fix nix build #44

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Checkout

CodeRabbit Configuration File (`.coderabbit.yaml`)