StardustXR/server
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 5 Wiki Activity

upgrade: tracy-client #50

Closed
nondescriptpointer wants to merge 1 commits from upgrade/tracy-client into dev
pull from: upgrade/tracy-client
merge into: StardustXR:dev
Conversation 4 Commits 1 Files Changed 2 +10 -10
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Cargo.lock generated
View File

@@ -3490,7 +3490,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "07033963ba89ebaf1584d767badaa2e8fcec21aedea6b8c0346d487d49c28667"
dependencies = [
"cfg-if",
"windows-targets 0.48.5",
"windows-targets 0.53.2",
]
[[package]]
@@ -4031,7 +4031,7 @@ version = "0.7.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "77e878c846a8abae00dd069496dbe8751b16ac1c3d6bd2a7283a938e8228f90d"
dependencies = [
"proc-macro-crate 1.3.1",
"proc-macro-crate 3.3.0",
"proc-macro2",
"quote",
"syn 2.0.104",
@@ -4769,7 +4769,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8a56d757972c98b346a9b766e3f02746cde6dd1cd1d1d563472929fdd74bec4d"
dependencies = [
"anyhow",
"itertools 0.11.0",
"itertools 0.14.0",
"proc-macro2",
"quote",
"syn 2.0.104",
@@ -6099,9 +6099,9 @@ dependencies = [
[[package]]
name = "tracy-client"
version = "0.18.0"
version = "0.18.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d90a2c01305b02b76fdd89ac8608bae27e173c829a35f7d76a345ab5d33836db"
checksum = "ef54005d3d760186fd662dad4b7bb27ecd5531cdef54d1573ebd3f20a9205ed7"
dependencies = [
"loom",
"once_cell",
@@ -6110,12 +6110,12 @@ dependencies = [
[[package]]
name = "tracy-client-sys"
version = "0.24.3"
version = "0.26.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "69fff37da548239c3bf9e64a12193d261e8b22b660991c6fd2df057c168f435f"
checksum = "319c70195101a93f56db4c74733e272d720768e13471f400c78406a326b172b0"
dependencies = [
"cc",
"windows-targets 0.48.5",
"windows-targets 0.52.6",
]
[[package]]
@@ -6711,7 +6711,7 @@ version = "0.1.9"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "cf221c93e13a30d793f7645a0e7762c55d169dbb0a49671918a2319d289b10bb"
dependencies = [
"windows-sys 0.48.0",
"windows-sys 0.59.0",
]
[[package]]

2
Cargo.toml
View File

@@ -80,7 +80,7 @@ thiserror = "2.0.11"
tracing = { version = "0.1.40", features = ["release_max_level_warn"] }
tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
tracing-tracy = { version = "0.11.1", optional = true }
tracy-client = { version = "=0.18.0" }
tracy-client = { version = "=0.18.2" }
coderabbitai[bot] commented 2025-08-17 16:13:53 -04:00 (Migrated from github.com)
Review
Copy Link

💡 Verification agent

🧩 Analysis chain

Double-check upstream compatibility matrix

Please confirm tracing-tracy 0.11.1’s supported tracy-client range to ensure 0.18.2 is within bounds.

🌐 Web query:

What tracy-client version(s) does tracing-tracy 0.11.1 depend on or support?

💡 Result:

tracing-tracy 0.11.1 depends on and supports tracy-client version 0.16.x.

The crates.io page for tracing-tracy (not directly in your search results) specifies:

  • tracing-tracy 0.11.1 has a required dependency:
    tracy-client >=0.16.0, <0.17.0

This means tracing-tracy 0.11.1 is compatible with tracy-client versions from 0.16.0 up to, but not including, 0.17.0.

Supporting context:

  • No search result directly lists the version mapping for 0.11.1, but tracing-tracy and tracy-client exhibit tight version coupling.
  • The tracing-tracy documentation describes features requiring tracy-client and refers to additional profiling capabilities from that dependency[9].
  • Community discussions highlight frequent incompatibilities between the embedded Tracy library and the external client, but do not list the current version mapping for 0.11.1[2][7].
  • Previous traceable examples indicate that major tracing-tracy releases consistently bump their tracy-client requirement.

Therefore, for tracing-tracy 0.11.1 specifically, use tracy-client 0.16.x.
Using other versions (e.g., 0.15.x or 0.17.x) will likely result in protocol incompatibility errors[7].

If you need to check or update this mapping for future releases, always check the Cargo.toml of the tracing-tracy version or its crates.io listing.

Citations:

Address tracy-client compatibility with tracing-tracy 0.11.1

tracing-tracy v0.11.1 requires tracy-client >=0.16.0, <0.17.0, but the PR pins tracy-client = "0.18.2", which is out of range and will cause protocol mismatches.

• Cargo.toml, line 83

- tracy-client = { version = "=0.18.2" }
+ # Option A: downgrade to the supported 0.16.x series
+ tracy-client = "0.16"

+ # Option B: upgrade tracing-tracy to a version that supports 0.18.x
+ # e.g., in Cargo.toml
+ # tracing-tracy = "0.12.0"

Please choose one of the above or align both dependencies to a matching compatibility range.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

# Option A: downgrade to the supported 0.16.x series
tracy-client = "0.16"

# Option B: upgrade tracing-tracy to a version that supports 0.18.x
# e.g., in Cargo.toml
# tracing-tracy = "0.12.0"
🤖 Prompt for AI Agents 
In Cargo.toml around line 83, the PR pins tracy-client = "0.18.2" which is
incompatible with tracing-tracy v0.11.1 (it requires tracy-client >=0.16.0,
<0.17.0); fix by aligning the two dependencies — either downgrade tracy-client
to a 0.16.x release that satisfies tracing-tracy (e.g., set tracy-client to a
0.16-compatible version/range) or upgrade tracing-tracy to a version that
supports tracy-client 0.18.2; pick one approach and update the Cargo.toml
dependency entries so their version ranges overlap, then run cargo update/build
to verify dependency resolution succeeds.
_💡 Verification agent_ <details> <summary>🧩 Analysis chain</summary> **Double-check upstream compatibility matrix** Please confirm tracing-tracy 0.11.1’s supported tracy-client range to ensure 0.18.2 is within bounds. --- 🌐 Web query: ```web What tracy-client version(s) does tracing-tracy 0.11.1 depend on or support? ``` 💡 Result: **tracing-tracy 0.11.1 depends on and supports tracy-client version 0.16.x.** The [crates.io page for tracing-tracy](https://crates.io/crates/tracing-tracy/0.11.1) (not directly in your search results) specifies: - **tracing-tracy 0.11.1** has a required dependency: `tracy-client >=0.16.0, <0.17.0` This means tracing-tracy 0.11.1 is compatible with **tracy-client versions from 0.16.0 up to, but not including, 0.17.0**. **Supporting context:** - No search result directly lists the version mapping for 0.11.1, but tracing-tracy and tracy-client exhibit tight version coupling. - The `tracing-tracy` documentation describes features requiring `tracy-client` and refers to additional profiling capabilities from that dependency[9]. - Community discussions highlight frequent incompatibilities between the embedded Tracy library and the external client, but do not list the current version mapping for 0.11.1[2][7]. - Previous traceable examples indicate that major `tracing-tracy` releases consistently bump their `tracy-client` requirement. Therefore, for **tracing-tracy 0.11.1 specifically**, use **tracy-client 0.16.x**. Using other versions (e.g., 0.15.x or 0.17.x) will likely result in protocol incompatibility errors[7]. **If you need to check or update this mapping for future releases, always check the `Cargo.toml` of the tracing-tracy version or its crates.io listing.** Citations: - 1: https://github.com/MethanePowered/Tracy/releases - 2: https://users.rust-lang.org/t/tracy-profiler-version-hell/94190 - 3: https://github.com/wolfpld/tracy/releases - 4: https://docs.cvedia.com/support/tracy_profiler.html - 5: https://www.libhunt.com/compare-minitrace-vs-tracy - 6: https://iree.dev/developers/performance/profiling-with-tracy/ - 7: https://forums.developer.nvidia.com/t/tracy-profiler-mismatch-version/328676 - 8: https://docs.rs/crate/tracing-tracy/0.8.0 - 9: https://docs.rs/tracing-tracy/latest/tracing_tracy/ - 10: https://escholarship.org/content/qt5vb169rb/qt5vb169rb.pdf --- </details> **Address tracy-client compatibility with tracing-tracy 0.11.1** tracing-tracy v0.11.1 requires `tracy-client >=0.16.0, <0.17.0`, but the PR pins `tracy-client = "0.18.2"`, which is out of range and will cause protocol mismatches. • Cargo.toml, line 83 ```diff - tracy-client = { version = "=0.18.2" } + # Option A: downgrade to the supported 0.16.x series + tracy-client = "0.16" + # Option B: upgrade tracing-tracy to a version that supports 0.18.x + # e.g., in Cargo.toml + # tracing-tracy = "0.12.0" ``` Please choose one of the above or align both dependencies to a matching compatibility range. <!-- suggestion_start --> <details> <summary>📝 Committable suggestion</summary> > ‼️ **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. ```suggestion # Option A: downgrade to the supported 0.16.x series tracy-client = "0.16" # Option B: upgrade tracing-tracy to a version that supports 0.18.x # e.g., in Cargo.toml # tracing-tracy = "0.12.0" ``` </details> <!-- suggestion_end --> <details> <summary>🤖 Prompt for AI Agents</summary> ``` In Cargo.toml around line 83, the PR pins tracy-client = "0.18.2" which is incompatible with tracing-tracy v0.11.1 (it requires tracy-client >=0.16.0, <0.17.0); fix by aligning the two dependencies — either downgrade tracy-client to a 0.16.x release that satisfies tracing-tracy (e.g., set tracy-client to a 0.16-compatible version/range) or upgrade tracing-tracy to a version that supports tracy-client 0.18.2; pick one approach and update the Cargo.toml dependency entries so their version ranges overlap, then run cargo update/build to verify dependency resolution succeeds. ``` </details> <!-- fingerprinting:phantom:triton:chinchilla --> <!-- This is an auto-generated comment by CodeRabbit -->
# (de)serialization
serde = { version = "1.0.205", features = ["derive"] }